concatenation trouble

[vinylblare]

can someone tell me if this concatenation is right? i'm getting an error.
i have wrote a script to open a document in a new window using the following code

<script>
//function to open new window
function openWindow() {
PopupWindow=window.open
("","name","width=850, height=950");
}
</script>

inside the php tags i have the following

echo"<tr><td bgcolor='#FFFFEE'><a href='" .moredetail . ".php?Moduleno=$Modno. "'target='".name. "' onClick='".openWindow()."'> " . $Modname . "</td>";

whats wrong with this ?

[diego25]

What are moredetail and name? Are they PHP variables? Then they need to have a $ before it. Also, openWindows() is a Javascript function, so it should be inside the string, not outside. Try

 echo"<tr><td bgcolor='#FFFFEE'><a href='" .$moredetail . ".php?Moduleno=$Modno. "'target='".$name. "' onClick='openWindow()'> " . $Modname . "</td>"; 

Diego