Parse Error - Little help please

[vornn]

Hi.

I've been trying to get this code to work for a few days now, but to no avail.

Here's what I want to do:

A list of reviews are presented on one page, and when clicked the review is pulled from the database.

I've got the variable passing from one page to the next, but I'm having problems retreving the information from the database.

Here's the error:

Parse error: parse error in /home/sites/site46/web/getreview.php on line 18

Here's the code:

<?php

/* Method to select the information forom the database and display the text */

include('mysqlsettings.php');

//Trap to stop the page if no connection to the database
if (! mysql_connect(MYSQL_HOST, MYSQL_USER, MYSQL_PASS) )
{
	echo 'Failed to connect to host "' . MYSQL_HOST . '".';
	exit;
}

mysql_select_db(MYSQL_DB);

$review_id = (integer) $HTTP_GET_VARS['rev_id']



// Select all the records  


$query     = "SELECT * FROM reviews LIMIT 1 WHERE reviewid = $HTTP_GET_VARS['rev_id']";           
$result    = mysql_query($query) or die("Error: " . mysql_error());  

if(mysql_num_rows($result) == 0) 
    echo("Nothing to Display!"); 



include('pur_top.html');


//Loop to display the results
while ($row = mysql_fetch_array($result))
{
	echo "<table cellspacing=1 cellpadding=3 width=100% bgcolor=#9966FF border=0>";
	echo "<tbody><tr><td class=bmtext bgcolor=#e6e6fa height=13><b><font size=2>";
	echo "{$row['title']}<br>";
	echo "</font></b></td></tr><tr><td height=29 bgcolor=white ><font size=2>";
	echo "{$row['review']}<br> ";
	echo " ";
}
echo "</font></td></tr></tbody></table></td></tr><tr> ";

include('pur_bot.html');
?>

Any ideas will be greatly appreciated.

🙂

[andrewtayloruk]

Hi,

You're just missing a semi-colon:

$review_id = (integer) $HTTP_GET_VARS['rev_id']

Should be:

$review_id = (integer) $HTTP_GET_VARS['rev_id'];

Thanks

Andrew

[jpmoriarty]

parse error is usually something really stupid...

like you forgetting the ";" at the end of the $review_id line

[vornn]

Ok, amended the code and now I get this errir:

Parse error: parse error, expecting T_STRING' orT_VARIABLE' or `T_NUM_STRING' in /home/sites/site46/web/getreview.php on line 26

Ayny ideas?

[sanu]

$query = "SELECT * FROM reviews LIMIT 1 WHERE reviewid = $HTTP_GET_VARS['rev_id']";

i think it should be
$query = "SELECT * FROM reviews LIMIT 1 WHERE reviewid = ' ".$HTTP_GET_VARS['rev_id']." ' ";

[jpmoriarty]

...or alternatively

$query = "SELECT * FROM reviews LIMIT 1 WHERE reviewid = \"$HTTP_GET_VARS['rev_id']\"";

[vornn]

OK...

Sanu, you were almost right. Here's the new error:

Error: You have an error in your SQL syntax near 'WHERE reviewid= (integer) ' 4 ' ' at line 1

JP's line didn't work, but the line you gave me gives me the number I require, but not in the right format.

I've tried removing the spaces from the string, taking out the quote marks and moving the string to another part of the script. But to no avail.

Any other ideas?

🙂

[vornn]

If I strip out the Where statement, the script works fine, apart from loading the correct article, it will only load review 1.

(thinks to self) is there another way to select the right review?

(wanders off pondering..)

🙂

[stolzyboy]

$query = "SELECT * FROM reviews LIMIT 1 WHERE reviewid = '$HTTP_GET_VARS['rev_id']';";

[xblue]

always put the limit clause after the where clause, otherwise it will confuse mysql:

$query = "SELECT * FROM reviews WHERE reviewid = '".$HTTP_GET_VARS['rev_id']."' LIMIT 1";

[vornn]

Blue, you are God of all things PHP.

Many thanks to all who have helped.

🙂

[xblue]

oh no, not really, but glad it helped 🙂

[stolzyboy]

lol, didn't even notice the limit statement or i would have said that, didn't think it would be where it was so just skipped over it like it was part of the select fields, oh well, glad you got it figured out