emails from textfile print runtogether

[glennn]

i have a newsletter script that saves to a textfile and shows all from said file; the problem is it runs the email addresses together like so: "[e-mail]@thecrimsonmoon.com" - i was hoping someone could show me how to edit the script to make it print them separately... Please?

code for saving the address to file:

// save to listfile
$fp = fopen($cfg['file'], "a+");
flock($fp, 2);
$ok = fputs($fp, trim($_GET['mail'])."\n" );
flock($fp, 3);
fclose($fp);

	if($ok)	return "<div id='box'>".THANKS_SAVED."</div>";
	else	return "Sorry, could not save email ...";
}

code for showing all in the webpage:

/ show all eMail's in list /
function showall() {

	global $cfg;

	// get them
	$fp  = fopen($cfg['file'], "r");
	$str = fread( $fp, filesize($cfg['file']) );	
	fclose($fp);
	clearstatcache();

	$adr = explode("%", $str);
	asort($adr);

	<?php echo "[ <a href='".$_SERVER['PHP_SELF']."?secure=".$_GET['secure']."' title='menu'>back to menu</a> ]"; ?>
	<p>
	<h3>All Addresses in List sorted from A - Z</h3>
	<b>Click one to delete!</b>
	<p>
	<div id='box'>
	<?php

	// print them
	foreach($adr as $mail) {

		if($mail != "")	echo "\n\t<li><a href=\"javascript:del('".$_SERVER['PHP_SELF']."?act=unsubscribe&mail=".$mail."','".$mail."')\" title=\"delete ".$mail."\">".$mail."</a>"-</li>";
	}

	echo "\n</div>\n";
}

i appreciate whoever can help very much,
glenn

[dalecosp]

UNIX? Windows?

Windoze doesn't like just a "\n".....

Not saying that's the reason, but it's definitely a possibility...

[glennn]

i don't know php - just L.B.CnP... (learning by cuttin' n pastin')

my mistake - the original code to save the email was

"$ok = fputs($fp, trim($_GET['mail'])."%" );" and not

"$ok = fputs($fp, trim($_GET['mail'])."\n" );" // (i tried this first)

what that was doing was saving the entries to file like so:

[e-mail]% for some reason...

i stuck the \n after the % and it saved them like it should with line breaks, so now the echo returns them like it's supposed to.

i guess that's work, right?

thanks for your help,
glenn

[Damien_Buttler]

Glenn, I bet you find that if you open the file in an editor that the emails will be on seperate lines. However, when echoing to the screen try using the '<br>' code instead of '\n' to have each print on a seperate line.

Damien.

[glennn]

in fact, it did (i was so proud) and then i was able to get it to echo on screen right (somehow) - only now, when i ask it to go and delete an entry it returns that it cannot find the email address, presumably because it's looking for it in a string.

i don't want to end up with a textfile with a few thousand entries in one solid string; i have to maintain this site for a growing business. wonder if you'd be ok with looking at the original file for me?

the admin website in question is http://www.thecrimsonmoon.com/xNewsletter/xNewsletter.php?

pwd crimsonmoon

i'd be glad to mail you the php file if you could gimme a hand? i understand if you can't, totally

thanks much
glenn

[Damien_Buttler]

I am not great with files. I suggest rather the read the whole file as one variable, work with one line at a time. eg.

while(!feof($fp)) {
$line = fgets($fp, 1024);
// formatting or printing can go here
}

With this method you can work with one line at a time. The next bit is not the best way but what I do is write each line to a temp file, then use ereg() to check (in your case) is an email exists, and if so, don't copy it to the temp file. Then rename() the file back to the original.

If someone wants to let me know a better way. Please tell.

Damien.