POST Problem

firest0rm

I have a script called user.php. In this script i have the function:

function user_login($user_name,$password)

I am posting (from index.php) to user.php the user_name and password, but the function wont fire.

Please help! 🙁

cgraz

ummm. . . what does your function look like? All you have there is you declare a function named user_login but it doesn't do anything. You don't even have brackets.

Cgraz

firest0rm

function user_login($_POST['user_name'],$_POST['password']) {
	global $feedback;
	if (!$user_name || !$password) {
		$feedback .=  ' ERROR - Missing user name or password ';
		return false;
	} else {
		$user_name=strtolower($user_name);
		$password=strtolower($password);
		$sql="SELECT * FROM user WHERE user_name='$user_name' AND password='". md5($password) ."'";
		$result=db_query($sql);
		if (!$result || db_numrows($result) < 1){
			$feedback .=  ' ERROR - User not found or password incorrect ';
			return false;
		} else {
			if (db_result($result,0,'is_confirmed') == '1') {
				user_set_tokens($user_name);
				$feedback .=  ' SUCCESS - You Are Now Logged In ';
				return true;
			} else {
				$feedback .=  ' ERROR - You haven\'t Confirmed Your Account Yet ';
				return false;
			}
		}
	}
}

cgraz

just at quick glance:

You define your function, then you give the variable names using $_POST, but you refer to them in the function as $username and $password.

What you want to do is define that first line of your function like this

function user_login($username,$password)

Then to call it up, if the username and password variables are coming out of a form with a method of post, call it up like this

user_login($POST['username'], $POST['password']);

That way, $POST['username'] is in the $username spot in your function, and $POST['password'] is in the $password spot in your function.

Also

$feedback .= ' ERROR - You haven't Confirmed Your Account Yet ';

watch the apostrophe on haven't. You should escape it or use double quotes surrounding the string instead of single quotes.

Cgraz