Please explain the coding axiom "all functions should return a value."

redneck

I have many cases where I want a function simply to process something, not return a value. But I want to follow good coding practice.

So does this make any sense or is it pretentious bollox?

trooper

I'm not 100% sure why you think that you want to get a function to perform an action yet not return anything ????

Hmmm functions are meant to make performing actions easier.

Think about it this way. If you pass 2 numbers to a function and the function adds them together then how do you know what the result is?

Answer you have to return the result of the two numbers being added together.

If you don't return anything from the function (even a true/false) then there would be no point in having the function in the first place!

HTH

redneck

Originally posted by trooper
If you don't return anything from the function (even a true/false) then there would be no point in having the function in the first place!

I use functions for structured coding. Done this with every language I've ever used. Some of my functions simply echo complicated text, basically do anything I don't want to have to repeat again and again in my main code.

Also, I like code which reads like this:

if ($question) {
  $user_stuff = process_user($username);
  echo_header($username);
  build_table();
  echo_stuff($user_stuff);
  finish_table();
  echo_footer();
} // end of if $question

Does this mean I am bad?

ahundiak

If a returned value is not needed then don't return one.

Lot's of silly people write guidelines for programing. Experience will show you which ones to follow and which ones to ignore.

Another guide line is that if a function returns a value then the value should be checked by the calling routine. Imagine how painful that would be if a function returned a value for no reason.