Problem with code

raouleduke

I have this code, everything works correctly but when I display multiple records, I can only submit the first one, when I try do do the second or third, etc. I click the submit and nothing happens.
If you have any ideas please help.

 <?php 
	mysql_connect(""); 
	mysql_select_db(""); 
	$query = "SELECT * FROM KEYCAD WHERE Hold LIKE 'N' AND CustomerNotReached LIKE '0' AND FollowUpContact LIKE '0' ORDER BY CUSTNO AND ContactDate DESC";
	$result = mysql_query($query);
	if($result){
	echo "<form method='post' action='submit.php?action=change'>"; 
	while ($row = mysql_fetch_array($result)) {
	echo "<table border=2 bordercolor=#5E3964>\n";
	echo "<tr>
			<td><font color=#FF0000>Name</font></td>
			<td><font color=#FF0000>Home #</font></td>
			<td><font color=#FF0000>Work #</font></td>
			<td><font color=#FF0000>Car Model</font></td>
		 </tr>\n";
	printf("
	<tr>
	<input type='hidden' name=RO value='%s'>
	<td>%s</td>
	<td>%s</td>
	<td>%s</td>
	<td>%s</td>
	</tr>\n",

$row["RO"], 
$row["CUSTOMERNAME"], 
$row["HOMEPHONE"], 
$row["BUSPHONE"],
$row["MODEL"]
);
echo "<tr>
		<td><font color=#FF0000>Follow-Up Needed</font></td>
		<td><font color=#FF0000>Customer Not Reached</font></td>
		<td><font color=#FF0000>Fixed Correctly?</font></td>
		<td><font color=#FF0000>Treatment?</font></td>
	 </tr>\n";
printf("
<tr>
<td><input type=checkbox name=FollowUpContact value='1'></td>
<td><input type=checkbox name=CustomerNotReached value='1'></td>
<td><input type=text name=Q1></td>
<td><input type=text name=Q2></td>
</tr>\n",

$row["FollowUpContact"],
$row["CustomerNotReached"], 
$row["Q1"], 
$row["Q2"]
);
echo "<tr>
		<td><font color=#FF0000>Clear Explanation?</font></td>
		<td><font color=#FF0000>Overall Service?</font></td>
		<td><font color=#FF0000>Why Not Fixed?</font></td>
		<td><font color=#FF0000>Labor Code</font></td>
	</tr>\n";
printf("
<tr>
<td><input type=text name=Q3></td>
<td><input type=text name=Q4></td>
<td><input type=text name=Q5></td>
<td><input type=text name=LaborCode></td>
</tr>\n",

$row["Q3"],
$row["Q4"], 
$row["Q5"], 
$row["LaborCode"]	
);
echo "<tr>
		<td><font color=#FF0000>Comments</font></td>
		<td><font color=#FF0000>Happy</font></td>
		<td><font color=#FF0000>Close Date</font></td>
		<td></td>
	 </tr>\n";
printf("
<tr>
<td><input type=text name=Comments></td>
<td><input type=checkbox name=HAPPY value='1'></td>
<td>%s</td>
<td><input type=Submit name=submit value=Submit></td>	
</tr>
</form></table>\n",

$row["CLOSEDATE"]	
);
}
}else{
echo "Sorry No Pending Calls!\n";
}
?>

Thanks in advance

ednark

ok well if you look at your html thats being printed out you will see that you write the open form tag once at the beginning, before your while loop... then you write the close form tag each time to loop runs...

so the first table thingy with the first button is actually closing off the form... the the other buttons are homeless formless guys that shouldn't do anything, which is why they don't

raouleduke

Do you have any ideas on how to fix this or is it not possible.
Thanks in advance!

Weedpacket

Of course it's possible; ednark told you how to fix it; move the <form> tag inside the loop. Shift it down one line, in other words.

(Since you're supplying a submit button with each record, I assume you're only wanting to submit one record at a time.)

raouleduke

I tried that but it is still not working, I moved the </form> tag and still no work. Yes I only want to submit one form at once, but I want to be able to submit any one of the records listed.
thanks in advance.

ednark

ok maybe you need some more feedback on what your page is recieving once you have submitted the form

there is a very good function for this: [man]print_r/man stands for... PRINT in human Readable format..

here is what i suggest you do

make two pages:

1 - the page you already have

2 - the recieving page, this should not do anything but show what form values there are

### SUBMIT.PHP
<pre>THESE VALUES WERE FOUND IN GET
<?php print_r($_GET); ?>
</pre>

<pre>THESE VALUES WERE FOUND IN POST
<?php print_r($_POST); ?>
</pre>

<pre>THESE VALUES WERE FOUND IN REQUEST
<?php print_r($_REQUEST); ?>
</pre>

this new page should show you everything you need to know to about what you form is actually submitting. maybe with this you can figure out what you form is really doing and tweak it.