I just released a script...

Henri

hello everyone, I just made my first script release early this morning. you can download it here: http://php.squarehq.net/

it is a script called PHPD.randomquote, wich is a random quote manager. It includes an installation script and an Admin Panel.

comments or critiques?

intenz

Ok, first...

if (is_file("install.php")) {

Why not use file_exists instead?

$max = rand(0, $count-1);

Basicly, rand sucks.

Use instead...

srand ((double) microtime() * 1000000);
$max = mt_rand(0, $count-1);

$random_quote = mysql_fetch_array($query);

Use mysql_fetch_assoc instead.

$db_name = "$mysql_database";

Why not just?...

$db_name = $mysql_database;

Why name a file .php when there's no PHP code in it (style.php) ?

Escaping so much HTML inside PHP is the most stupid thing ever (it's slow too).

Henri

Why name a file .php when there's no PHP code in it (style.php) ?

Escaping so much HTML inside PHP is the most stupid thing ever (it's slow too). [/B][/QUOTE]

I named it .php because then noone can view whats inside when it's executed, but I guess it does'nt matter.

And when you say that escaping so much HTML inside PHP is stupid, what else would you recommend doing when I have to set cookies?

intenz

Originally posted by Henri
I named it .php because then noone can view whats inside when it's executed, but I guess it does'nt matter.

Ehh, you can always see the HTML. In this case you can see all the contents of this file. You can't see the PHP, but you can see the HTML. And in this case this file is all HTML 🙂

Originally posted by Henri
And when you say that escaping so much HTML inside PHP is stupid, what else would you recommend doing when I have to set cookies?

Err.. How about:

<?
php stuff
?>
HTML here
<?
more php stuff
?>
more HTML
<?
more more more php stuff
?>
more more more HTML
<?
phpphphphphphphphphp
?>