Whats wrong with isset?

Nik

while (isset($quote=file_diary[rand(0, count($file_diary)-1)]) && $i==0)
{
echo $quote;
$i++;
}

Xzone5

Nothing, you need to separate the conditions in multi-conditionals like so:

while (  (isset ( $quote=file_diary [rand (0, count ( $file_diary )-1) ] ) ) && ( $i==0 ) )
{
echo $quote;
$i++;
}

An extra pair of paranthesis goes around the entire thing, while each condition is nested in its own set.

Matt

Nik

Parse error: parse error, unexpected '=', expecting ',' or ')' in e:\web\index.php on line 86

as with mine!

Why?

Weedpacket

isset() can only test to see if a variable is set or not. You haven't got a variable there, you've got a whole expression ($quote=blahblahblah).

[man]isset[/man]
Warning: isset() only works with variables as passing anything else will result in a parse error.

So PHP gets through reading "$quote" and then chokes on the "=".

But think about it; if you're trying to see if $quote isset() or not, the answer will always be "yes" - it's set to the output of file_diary.

Are you sure isset() is what you want? What are you trying to test for?

Xzone5

Try this:

while (  (isset ( $quote=file_diary [rand (0, ( count ( $file_diary )-1) ) ] ) ) && ( $i==0 ) )
{
echo $quote;
$i++;
}

Matt

Nik

Xzone stiil the same error!

Weedpacket i think u r right!

isset is not going to wotk this way

i need to way to get a random single line from my text file
but NOT blank lines as my text file is like this:

line1
blank line
line2
blank line
line3
blank line

and so on.....

Any ideas?

Xzone5

Try this:

$quote=file_diary [rand (0, count ( $file_diary )-1) ];

while (($quote != "\n") && ( $i == 0 ))
{
echo $quote;
$quote=file_diary [rand (0, count ( $file_diary )-1) ];
$i++;
}

Matt

Nik

Parse error: parse error, unexpected '[' in e:\web\index.php on line 86

🙁

Xzone5

Is file_diary a variable or a function right here:

file_diary [rand (0, coun...

diego25

Shouldn't file_diary be a variable? You're missing 2 dollar signs ($) before the file_diary variable.

Diego

Xzone5

That's what I was thinking, although I don't see why the first instance of it on each line needs to be there at all...

Nik

yes i notices that myself 1 minute before your posts guys! @file_diary is a varibale but when i putted the $ it worked but not as i intended!

it gives blank lines too so "\n" is not helping us out!!

empty or isset neither!!

any ideas left? 🙂

Xzone5

I don't understand, aren't the blank lines just \n's?

diego25

How is $file_diary defined? Using the file() function?

Diego

Nik

yes! $file_diary = file("diary.txt");

🙂

Xzone5

Alright, so are the blank lines \n's, and are the blank lines even or odd?

Weedpacket

$file_diary = file('diary.txt');
foreach($file_diary as $lineno=>$line)
{ if($line=="\n") unset($file_diary[$lineno]);
}
$file_diary = array_values($file_diary);

Now there aren't any blank lines, so there's no need to worry about them any more. (It's nice when you can get your data into a usable form before you try and use it!)

(Unless the file was made by a Windows machine, in which case you might want to use "\r\n" instead of "\n").

Xzone5

Ok, so that just about solves everything except why he is using the while loop. Wouldn't a do...while loop be what he needs?

Xzone5

So, why the loop at all if it is only being done once? Why not just echo and get on with it?

Nik

foreach($file_diary as $lineno=>$line)
if($line=="\r\n") unset($file_diary[$lineno]);

$file_diary = array_values($file_diary);
$quote=$file_diary[rand(0, count ($file_diary)-1)];

Thanks Weed packet that worked just how i wanted to work!!

But how did u do it anyway? Can u u explain in it a bit pls?