Help Please....

liquidchild

I am designing an intranet site and have a system.config.php file, I use the following code to include this file:

include( '../../../system/system.config.php' );

system.config.php contains:

?php

/ DOCUMENT SETTINGS /

$DOCTYPE = '<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">';

$PAGE_TITLE = ':: Corporate Intranet';

$ODBC_ERROR_FILE = 'C:/Intranet/errorLogs/odbc_error.txt';

$SQL_ERROR_FILE = 'C:/Intranet/errorLogs/sql_error.txt';

Is this the correct / best way of doing this?

notionlogic

Seems to make sense to me... use it to hold stuff that is generic and applies to all pages unless specifically overwritten!

I might suggest that you use include_once(...) instead though - it's just a safety precaution that I always try to use!

Cleric

As from personal experience and usage, I would encourage you to change those variables into constants. This is the usual scenario about why:

If you keep them declared as variables and try to use them with functions within your site, you will find that though you include the variables with files that have the functions you want to use, the functions cannot see them as they do not live in the same scopes. So you end up going to each function you need variables for and declare them using GLOBAL $blah1, blah2, ... so on and so forth. Eventually, any time you need a new variable, you must remember to tell the function "Oh yeah, this is a global variable that you can't see, just trust me and use it."

However, if you declare those variables as constants, there is no need to do the GLOBAL thing in any functions.

Just for some edification, including files with constants is a good way of working with things, 😉.