desperatly if checking

da_marek

maybe this is really for newbies but i posted this there too...
i have a form with various fields and some of them are not optional. after pushing submit (submit_f_charter_hr) button form should go through check.php page to validate some fields. this is check.php

<?php
error_reporting(1);
if($submit_f_charter_hr!=''){

if (!empty($_POST['model_jahte']) || !empty($_POST['br_kabina']) || !empty($_POST['br_kreveta'])
 || !empty($_POST['br_putnika']) || !empty($_POST['skiper']) || !empty($_POST['mjesto_polaska'])
 || !empty($_POST['datum_polaska']) || !empty($_POST['trajanje']))

printf("<META HTTP-EQUIV='refresh' content='2;URL=osobni_hr.html'>");

else

printf("<META HTTP-EQUIV='refresh' content='2;URL=nepotpuna_hr.html'>");

}
?>

i dont know what is the error because server doesnt tell me nothing... it just stops on check.php page and thats it... theres no redirecting...

am i too sleppy or just blind we will see...

sarahk

I'd be inclined to recode it as

<?php
function checkit($varname)
{
  // I don't user _POST but normally I'd do an isset() first
  $chk = $_POST($varname);
  return !empty($chk);
}// end of function checkit

error_reporting(1);
$chkflag = true;

if($submit_f_charter_hr!='')
{
  if ($chkflag) checkit('model_jahte');
  if ($chkflag) checkit('br_kabina');
  if ($chkflag) checkit('br_kreveta');
  if ($chkflag) checkit('br_putnika');
  if ($chkflag) checkit('skiper');
  if ($chkflag) checkit('mjesto_polaska');
  // and so on

  if ($chkflag)
    printf("<META HTTP-EQUIV='refresh' content='2;URL=osobni_hr.html'>");
  else
    printf("<META HTTP-EQUIV='refresh' content='2;URL=nepotpuna_hr.html'>");

}
?>

this is more readable, debuggable and extendable. All those brackets and || made me dizzy.

da_marek

well, of course i agree this is more readable/debuggable/extendable code but isnt that just the same thing i had before but written different? the problem is still here: i stop on check.php page... theres no redirecting... why?
here is the form if that will help, just click on 'salji'... http://www.mesmerized.ws/dimare/f-charter_hr.html
and heres the new code:

<?php

function checkit($submit_f_charter_hr)
{
  $chk = $_POST($submit_f_charter_hr);
  return !empty($chk);
}

error_reporting(1);
$chkflag = true;

if($submit_f_charter_hr!='')
{
	if ($chkflag) checkit('model_jahte');
	if ($chkflag) checkit('br_kabina');
	if ($chkflag) checkit('br_kreveta');
	if ($chkflag) checkit('br_putnika');
	if ($chkflag) checkit('skiper');
	if ($chkflag) checkit('mjesto_polaska');
	if ($chkflag) checkit('datum_polaska');
	if ($chkflag) checkit('trajanje');

if ($chkflag)

printf("<HTML><HEAD><META HTTP-EQUIV='refresh' content='2;URL=osobni_hr.html'></HEAD></HTML>");

else

printf("<HTML><HEAD><META HTTP-EQUIV='refresh' content='2;URL=nepotpuna_hr.html'></HEAD></HTML>");

}
?>

Weedpacket

Is there a reason why you're using a META refresh to redirect instead of header("Location:...")?

(Ps, Minor typo: $POST[...], not $POST(...).)

da_marek

well i tried to change meta tags into 'header...' but that didnt work... neither did change from $POST (...) to $POST [...]
so that piece of code now looks like this:

  $chk = $_POST[$submit_f_charter_hr];

and

	if ($chkflag)

header("Location: osobni_hr.php");
else

header("Location: nepotpuna.php");

i really dont get it... is it maybe because i have checkboxes and radio buttons in my form? is there any easier way to validate form and if all required fields are filled to redirect to one page or if they are not to redirect to another??

im dying to know this!

:mad:

Weedpacket

(Why have "function checkit($submit_f_charter_hr)" instead of sarahk's "function checkit($varname)"? That's only going to cause confusion.)

Let's think about the problem for a bit:

The only reason why it wouldn't redirect at all is if it never gets to the bit that says "if this then redirect to here, else redirect to there".

That bit of code won't be reached if
($submit_f_charter_hr!='')
is false, in other words, if $submit_f_charter_hr is empty.

So maybe $submit_f_charter_hr is empty?

I take it that's the name of the submit button? If so, why isn't it treated the same as all the other form fields; i.e., as $_POST['submit_f_charter_hr']?

If you hadn't turned your error reporting down so low you might have been told about this.

sarahk

aaah, weedpacket, love your work!

Yep, I kindof figured that by making it more debuggable da_marek might do that. such as

<?php

function checkit($submit_f_charter_hr)
{
  $chk = $_POST($submit_f_charter_hr);
echo "$submit_f_charter_hr: $chk<br>\n";
  return !empty($chk);
}

and that way you can see what data is coming through. Then when it's right there's only one line to remove.

da_marek

woow! thanks for all the help... i improved my code with some details and error reporting is now on but i still have problems...
hey weedpacket! i dont know what you mean by 'treating like all other form fields'... how do i do that? i tried many combinations but none of them is working... please give me a tip!
and just for case this is my code:

<?php

function checkit($submit_f_charter_hr)
{
  $chk = $_POST[$submit_f_charter_hr];
  echo "$submit_f_charter_hr: $chk<br>\n";
  return !empty($chk);
}

error_reporting(63);
error_reporting (E_ALL);
$chkflag = true;

if($submit_f_charter_hr!='')
{
	if ($chkflag) checkit('model_jahte');
	if ($chkflag) checkit('br_kabina');
	if ($chkflag) checkit('br_kreveta');
	if ($chkflag) checkit('br_putnika');
	if ($chkflag) checkit('skiper');
	if ($chkflag) checkit('mjesto_polaska');
	if ($chkflag) checkit('datum_polaska');
	if ($chkflag) checkit('trajanje');

if ($chkflag)

header("Location: osobni_hr.php");
else
	header("Location: nepotpuna_hr.html");
}
else
	header("Location: nepotpuna_hr.html");
?>

and this is the error i get:
Warning: Undefined variable: submit_f_charter_hr in /home/virtual/site45/fst/var/www/html/dimare/check.php on line 14
line 14 is

if($submit_f_charter_hr!='')

please help! it midnight here and i have a headache and i cant think anymore...

🙁 🙁 🙁

Weedpacket

Originally posted by da_marek
i dont know what you mean by 'treating like all other form fields'... how do i do that?

Use $_POST['submit_f_charter_hr'].

And in the function checkit, don't use $submit_f_charter_hr there either. The variable you're calling $submit_f_charter_hr there and sarahk called $varname has nothing to do with your submit button. Save yourself the confusion and just call it $varname.

and this is the error i get:
Warning: Undefined variable: submit_f_charter_hr in /home/virtual/site45/fst/var/www/html/dimare/check.php on line 14

Exactly as I suspected 🙂 - hence the suggestion to use $POST['submit_f_charter_hr'] there. Best way to do the test in full would be

if(!empty($_POST['submit_f_charter_hr']))

Reasons for all this behaviour are covered in the manual section on Variables from Outside PHP.

da_marek

its me again...
look, i really appreciate your help! it means very much to me but as i said its really late (2.10am) and my headache is getting stronger and stronger and i just cant stand it anymore. the only problem is that i must have this thing finished at 8.00am today!!!
im sorry if i sound like a lamer but maybe i really am 🙂
ill try to post this problem to all sections of this forum and i hope that there will be some good answer that will save my ass when i wake up...
ps: weedpacket, your replies make me think in different (better) ways and things are getting clearer... 🙂 thanks!

so, from the begging:

i have a form with various fields (textboxes, radio buttons and checkboxes). some fields MUST be filled and that is schecked through check.php file. that file looks like this:

<?php

function checkit($varname)
{
  $chk = $_POST[$varname];
  echo "$submit_f_charter_hr: $chk<br>\n";
  return !empty($chk);
}

error_reporting(63);
error_reporting (E_ALL);
$chkflag = true;

if(!empty($_POST['submit_f_charter_hr']))
	{
	if ($chkflag) checkit('model_jahte');
	if ($chkflag) checkit('br_kabina');
	if ($chkflag) checkit('br_kreveta');
	if ($chkflag) checkit('br_putnika');
	if ($chkflag) checkit('skiper');
	if ($chkflag) checkit('mjesto_polaska');
	if ($chkflag) checkit('datum_polaska');
	if ($chkflag) checkit('trajanje');

if ($chkflag)

header("Location: osobni_hr.php");

else

header("Location: nepotpuna_hr.html");

}
else

header("Location: neposlana_hr.html");

?>

submit_f_charter_hr is the name of the button on the first page...
so, if all required fields are filled user should be redirected to osobni_hr.php where is another form. if some required fields are not filled he should be redirected to nepotpuna_hr.html and if there was some other problem he should go to neposlana_hr.html.
(btw: osobni_hr means something like personal information, nepotpuna_hr is a warning page that some fields are not filled and neposlana_hr says that there was a problem, please email blah blah...)
you can see this thing in live at http://www.mesmerized.ws/dimare/f-charter_hr.html. just click on 'salji' button.
and the problem is that whatever i do i am redirected to neposlana_hr.html.
i really dont know why this is happening and even if there was lots of explanations and good advices its still not working.

Weedpacket

Hmmm.... Ah... the submit_f_charter_hr field is an image field, not a submit (I didn't check earlier for technical reasons)...

So $POST['submit_f_charter_hr'] is empty! Instead there are two fields" $POST['submit_f_charter_hr_x'] and $POST['submit_f_charter_hr_y'], which contain the x and y coordinates (the field type was designed for image maps); you'll be wanting to check one of those ("...x" would be my choice).

Now if I'd designed this part of PHP's interface with the outside world, I'd have had $POST['submit_f_charter_hr']['x'] and $POST['submit_f_charter_hr']['y'], and the problem wouldn't have arisen (it makes more sense conceptually, too); but I didn't design this part of the interface.

da_marek

...and i woke up in 6.30 to complete my mission... but it wasnt successful!
suddenly i realized that the problem is in validating fields. why? because the script ALWAYS redirects me to neposlana_hr.html. but i cant figure out is the problem in first part

function checkit.....

or later in validation part

if(!empty($_POST'submit_f_charter_hr')).......

is there any easier way to perform this stupid validating???
ps: i looked on other forums and some people had had same problem and the solution was same as mine:
if(!empty($_POST['submit_f_charter_hr'])) must be changed to if(!empty($_POST['submit_f_charter_hr_x'])).
so i was trying and trying and trying but nothing... wtf am i doing wrong?????