Oh crap...

SpyTechDESIGNS

Ok, let me try to explain this one.

I'm working on a login script, that will check the user's data from a database and then set cookies on their computer so they will be logged in when they return. Here is my problem. On the login script, I have it like so:

HTML UP HERE

<?

if(mysql_num_rows($select_login) == 1) {

setcookie("uid", mysql_result($select_login, 0, 0), time() + 15768000);
setcookie("upass", mysql_result($select_login, 0, 1), time() + 15768000);

$message = "You have been logged in. <a href=\"$site_url\">Return to Home Page</a>.";

} else {

$message = "You could not be logged in. You may have entered invalid information. <a href=\"$site_url/login/index.phtml\">Return to login</a>.";

echo "$message";

}

?>

HTML DOWN HERE

Now that works just fine. But, what I am having a problem with is that I want to include a error if the user is already logged in, so it says "Sorry, you are alreadly logged in.". Now, the actual problem is that when I do a if() statement and see if there are cookies set, and if there are, it will display the message. But, when I put that code in it doesn't stop there, it goes through to the next line of code starts to set the cookies, example of what I was using.

HTML UP HERE

<?

if(empty($uid) or empty($upass)) {

$message = "You are already logged in.";

} else if(mysql_num_rows($select_login) == 1) {

setcookie("uid", mysql_result($select_login, 0, 0), time() + 15768000);
setcookie("upass", mysql_result($select_login, 0, 1), time() + 15768000);

$message = "You have been logged in. <a href=\"$site_url\">Return to Home Page</a>.";

} else {

$message = "You could not be logged in. You may have entered invalid information. <a href=\"$site_url/login/index.phtml\">Return to login</a>.";

}

echo "$message";

?>

HTML DOWN HERE

Now what happens is that even if the user is already logged in, it doesn't stop and display the message, it keeps going. I know I can use the die() or exit;, but I have HTML bellow this that needs to be dispalyed, so I don't want to kill the script. Can someone please give some input! Thank you to anyone that will help.

Weedpacket

Sorry, I'm missing something here...

Are you sure checking to see if $uid or $password are empty is the way to tell if they're already logged in? It just seems a bit odd, is all.

(The cookies will only be set if (a) $password and $uid are both nonempty, and (b) the $select_login record has one row.)

If it's saying that they're already logged in AND setting the cookies, then it wouldn't say they're already logged in, because that $message would have been overwritten by the one that says "You have been logged in...".

I'm just not sure I understand your problem rightly.

SpyTechDESIGNS

Ok, guess it is hard to explain. The problem is that I want to first check if $uid and $upass are on the person's computer, and if they are make $message = "You are already logged in.";. Now, if they are not logged in then I want to to go on and next check to see if the form fields are not empty, if they are empty make $message = "You need to input a username and password.";. Now, if they are not empty then I want it to next check in the database and see if the username and password match what $username and $password were in the form. If so, set the cookies and make $message = "You have been logged in.";. Now if the username and password were incorrect, then display $message = "Your login information was incorrect, please put in correct login information.";.

I am somehow coding this wrong and it is not working as I described. Got an answer or maybe example on the best way to do it?

SpyTechDESIGNS

Weedpacket, any help?

Weedpacket

if(empty($uid) or empty($upass)) {
$message = "You are already logged in.";
}

Ah, so $uid and $upass are your cookie values! (I'm never going to get used to register_globals). Using $_COOKIE['uid'] et al. would make things a lot clearer.

But my question is much the same as last time: you're deciding they're already logged in if they don't have both of those cookies on their machine? Because that's what your code says.

SpyTechDESIGNS

Ok, put aside what I've written real fast. This is the login script. Now, there is a form with the two fields, $username and $password in it. I want it to first check and see if there are cookies set, or that they are already logged in. If so, then put a message that says they are already logged in. Now, lets say the user doens't put anything in a presses submit, then I want it to display a message saying that they need to input data. Now, if they do put something in I want it to make sure that their data is correct to what it is in the database, if so then set the cookies. If not display a message saying that they need to input correct data. The thing that is making this difficult for me is that I need to do this without killing the script, using exit; or die(). This is because there is HTML bellow the code that needs to be display, so if it dies then it won't be displayed. I can't figure out how to code it to where all the differenet aspects work.

Weedpacket

I'm still suggesting that the very first test (where you check the values of their cookies) is the complete opposite of what you want.

SpyTechDESIGNS

Well, even if I change it it won't work right. The thing is that if it does find that there are cookies and the user is already logged in, it keeps going onto the checking to see if the input is correct, and logging them in again. I can easily solve that by using exit; after each $message tag, but I can't have it die since there is HTML below. Understand my problem now?

SpyTechDESIGNS

Well, I figured out my problem. Something real easy and was just stupid on my part. Recoded it in a easier way and it seemed to work perfect, so thanks for putting up with my crap Weedpacket. Got it all fixed now though.