PHP/MySQL Problem

[Kudose]

<?

mysql_connect('localhost', 'XXXXXX', 'XXXXXX') or die(mysql_error());
mysql_select_db('DB_XXXXXX) or die(mysql_error());
$query = "SELECT * FROM users";
$rows = mysql_num_rows($query);

print('<left>');
print('<table width="50%" border="0">');

for($counter = 0; $counter < $rows; $counter++)
{
print('<tr>');
print('<td>$username</td>');
print('<td>$fname $lname</td>');
print('</tr>');
print('</table>');
print('</left>');
}
?>

I get a error on line 6 ( $rows ) that looks like this:

Warning: Supplied argument is not a valid MySQL-Link resource in /users/XXXXXX.com/XXXXXX/showmembers.php on line 6

[bjwilke]

You define your query, but you don't query the Database 🙂

$query = "SELECT * FROM users";
$return = mysql_query($query);
$rows = mysql_num_rows($query);

[Kudose]

Now I dont get an error but when I do this:

print('<left>');
print('<table width="50%" border="0">');
print('<tr><td> Username </td><td>Name</td></tr>');
while ($row = mysql_fetch_assoc($return)) {
print('<tr>');
print('<td> $row[username] </td>');
print('<td> $row[fname], $row[lname] </td>');
print('</tr>');
print('</table>');
print('</left>');
}

It displays the $row['username'] and such under the right table, but it wont pull the info and print it. Any suggestions?

[Azazeal]

Try this instead. Use the mysql_fetch_array() function. Also, it may be easier to escape php then hop back in. This is a good idea if you are used to HTML formatting.

<?php
mysql_connect('localhost', 'XXXXXX', 'XXXXXX') or die(mysql_error());
mysql_select_db('DB_XXXXXX) or die(mysql_error()); 

$query = mysql("SELECT * FROM users");
$rows = mysql_num_rows($query);

while($data=mysql_fetch_array($query)){
?>
<br>
<table width="50%" align="left" border="0">
<tr>
<td><?php echo $data['username']?> </td>
<td><?php echo $data['fname'].''.$data['lname'] ?></td>
</tr>
</table>
</left>
<?php
}
?>

You can also define the variables before jumping into HTML. Like this:

while($data=mysql_fetch_array($query)){
$username = $data['username'];
$fullname   = $data['fname'].''.$data['lname'];

?>
<br>
<table width="50%" align="left" border="0">
<tr>
<td><?php echo $username ?> </td>
<td><?php echo $fullname    ?></td>
</tr>
</table>
</left>
<?php
}
?>

The above is great, because you define the variables ahead of time, and can use it through the rest of the while loop.