PHP Links

Mistah_Roth

im trying to make a link thing so it takes whats ALREADY THERE + &music=yes

so if I click this link from

index.php?nav=menu&main=news

it will goto

index.php?nav=menu&main=news&music=yes

what do I link to, to make that happen? 🙂 (this link is through an echo in the PHP coding)

Mirrorball


$link = $_SERVER['REQUEST_URI'] . (strstr($_SERVER['REQUEST_URI'], '?') ? '&music=yes' : '?music=yes');

Mistah_Roth

ok thats great thanks, but theres one problem. I have it so if you click it it plays music and displays another link to turn the music off "music=no" when you click it, it ALSO adds that to the address, and if you keep clicking it, it starts to look like this:

index.php?nav=menu&music=yes&music=no&music=yes&music=no

how do I fix it so it just replaces the old 'music=' with the new one?

Mistah_Roth

... can anyone help me?

kilbey1

Hope this is right...

I would assume that snippet of code has a switch statement built into it, so it would read more like this:

$link = $_SERVER['REQUEST_URI'] . (strstr($_SERVER['REQUEST_URI'], '?') ? '&music=yes' : '&music=no');

But I don't do it that way. I build a switch statement that says, basically, if user clicks on link to hear music, then make $link A. If user clicks on link to NOT hear music, then make $link B. Somewhat like this:

<?
switch($_REQUEST[mode]){

///////////////////////////
// Display correct head title
case "yes_music":
$link = $_SERVER['REQUEST_URI'] . (strstr($_SERVER['REQUEST_URI'], '?') ? '&music=yes');
break;
case "no_music":
$link = $_SERVER['REQUEST_URI'] . (strstr($_SERVER['REQUEST_URI'], '?') ? '&music=no');
break;
default:
$link = $_SERVER['REQUEST_URI'] . (strstr($_SERVER['REQUEST_URI'], '?') ? '&music=yes');
}

echo $link;
?>

With the link from the previous page being written out like so:

<a href=\"index.php?mode=yes_music\">Play Music</a> <BR>
<a href=\"index.php?mode=no_music\">Don't Play Music</a>

Maybe this isn't what you're looking for.

Mistah_Roth

Well this is what my current code looks like:

<?php

$soundtracks = array(
   '/shop.php' => 'MIDI/shop.mid',
   '/chocobo.php' => 'MIDI/chocobo.mid',
   '/index3.php' => 'MIDI/welcome.mid',
);

if(isset($soundtracks[$_SERVER['PHP_SELF']])){ 
   if ($music == "yes") {
   		$soundtrack = $soundtracks[$_SERVER['PHP_SELF']];
   		echo "<embed src=$soundtrack hidden=true></embed>";
  		if ($soundtrack == "MIDI/welcome.mid") {
			$link = $_SERVER['REQUEST_URI'] . (strstr($_SERVER['REQUEST_URI'], '?') ? '&music=no' : '?music=no');
   			echo "<font size=1 face=Verdana color=CCCCCC><strong><a href=$link><img border=0 alt='Click Here to Turn Off Music' src=MIDI/music.gif> FFVII - Intro</a></strong></font>";
  		}
   }
   else {
   		$link = $_SERVER['REQUEST_URI'] . (strstr($_SERVER['REQUEST_URI'], '?') ? '&music=yes' : '?music=yes');
		echo "<font size=1 face=Verdana color=CCCCCC><strong><a href=$link><img border=0 src=MIDI/music.gif> Music Turned Off</a></strong></font>\n";
   }
}

else{ 
	echo "<font size=1 face=Verdana color=CCCCCC><strong><img src=MIDI/music.gif> No Music Available</strong></font>\n";
}


?>

If I had links like yours then it wouldnt ADD the &music=yes to the existing would it? It looks like it would goto index and I dont want that, I just want it so it adds the &music=yes to the address and then when you turn it off it replaces it with &music=no

kilbey1

Ah, well, you wouldn't have to make your links index.php. You could set it up like so:

<a href="$SERVER['REQUEST_URI']?mode=yes_music\">Play Music</a> <BR>
<a href=\"$SERVER['REQUEST_URI']?mode=no_music\">Don't Play Music</a>

or replace $SERVER['REQUEST_URI'] with $SERVER['PHP_SELF'] if necessary; I haven't used REQUEST_URI yet.

Mistah_Roth

Alright I did that, and maybe I put your switch in the wrong place but it gives me errors, can you show me what the code should look like after changes?

kilbey1

Can you tell me what error it's giving you?

Mistah_Roth

<style>
A:link, A:visited, A:active {
	COLOR: #FFFFFF;
	TEXT-DECORATION: none;
	font-weight:bold;
}
A:hover {
	COLOR: #FFFFFF;
	TEXT-DECORATION: none;
	font-weight:bold;
}
</style>

<?php

$soundtracks = array(
   '/shop.php' => 'MIDI/shop.mid',
   '/chocobo.php' => 'MIDI/chocobo.mid',
   '/index3.php=' => 'MIDI/welcome.mid',
);

switch($_REQUEST[mode]){
case "yes_music":
$link = $_SERVER['REQUEST_URI'] . (strstr($_SERVER['REQUEST_URI'], '?') ? '&music=yes');
break;
case "no_music":
$link = $_SERVER['REQUEST_URI'] . (strstr($_SERVER['REQUEST_URI'], '?') ? '&music=no');
break;
default:
$link = $_SERVER['REQUEST_URI'] . (strstr($_SERVER['REQUEST_URI'], '?') ? '&music=yes');
}

echo $link;

if(isset($soundtracks[$_SERVER['PHP_SELF']])){ 
   if ($music == "yes") {
   		$soundtrack = $soundtracks[$_SERVER['PHP_SELF']];
   		echo "<embed src=$soundtrack hidden=true></embed>";
  		if ($soundtrack == "MIDI/welcome.mid") {
			$link = $_SERVER['REQUEST_URI'] . (strstr($_SERVER['REQUEST_URI'], '?') ? '&music=no' : '?music=no');
   			echo "<font size=1 face=Verdana color=FFFFFF><strong><a href=\"$_SERVER['REQUEST_URI']?mode=no_music\"><img border=0 alt='Click Here to Turn Off Music' src=MIDI/music.gif> FFVII - Intro</a></strong></font>";
  		}
   }
   else {
   		$link = $_SERVER['REQUEST_URI'] . (strstr($_SERVER['REQUEST_URI'], '?') ? '&music=yes' : '?music=yes');
		echo "<font size=1 face=Verdana color=FFFFFF><strong><a href=\"$_SERVER['REQUEST_URI']?mode=yes_music\"><img border=0 src=MIDI/music.gif> Music Turned Off</a></strong></font>\n";
   }
}

else{ 
	echo "<font size=1 face=Verdana color=FFFFFF><strong><img src=MIDI/music.gif> No Music Available</strong></font>\n";
}


?>

and the error:

Parse error: parse error, unexpected ')' in /home/virtual/site34/fst/var/www/html/music.php on line 24

I dont get the error when I take out your links and switch

kilbey1

Perhaps this will work for you:

<style>
A:link, A:visited, A:active {
    COLOR: #FFFFFF;
    TEXT-DECORATION: none;
    font-weight:bold;
}
A:hover {
    COLOR: #FFFFFF;
    TEXT-DECORATION: none;
    font-weight:bold;
}
</style>

<?php

$soundtracks = array(
   '/shop.php' => 'MIDI/shop.mid',
   '/chocobo.php' => 'MIDI/chocobo.mid',
   '/index3.php=' => 'MIDI/welcome.mid',
);

switch($_REQUEST[mode]){
case "yes_music":
$link = "$_SERVER[REQUEST_URI]&music=yes";
break;
case "no_music":
$link = "$_SERVER[REQUEST_URI]&music=no";
break;
default:
$link = "$_SERVER[REQUEST_URI]&music=yes";
}

echo $link;

if(isset($soundtracks[$_SERVER['PHP_SELF']])){ 
   if ($music == "yes") {
           $soundtrack = $soundtracks[$_SERVER['PHP_SELF']];
           echo "<embed src=$soundtrack hidden=true></embed>";
          if ($soundtrack == "MIDI/welcome.mid") {
            //$link = $_SERVER['REQUEST_URI'] . (strstr($_SERVER['REQUEST_URI'], '?') ? '&music=no' : '?music=no');
               echo "<font size=1 face=Verdana color=FFFFFF><strong><a href=\"?$link\"><img border=0 alt='Click Here to Turn Off Music' src=MIDI/music.gif> FFVII - Intro</a></strong></font>";
          }
   }
   else {
           //$link = $_SERVER['REQUEST_URI'] . (strstr($_SERVER['REQUEST_URI'], '?') ? '&music=yes' : '?music=yes');
        echo "<font size=1 face=Verdana color=FFFFFF><strong><a href=\"?$link\"><img border=0 src=MIDI/music.gif> Music Turned Off</a></strong></font>\n";
   }
}

else{ 
    echo "<font size=1 face=Verdana color=FFFFFF><strong><img src=MIDI/music.gif> No Music Available</strong></font>\n";
}


?>

Mistah_Roth

That doesnt work properly and I know why.....

theres nothing that determines yes_music or no_music so it always just goes to the default....

jebster

Simple(I think) I use something simplier on my site but not for music!

Have this :

<FORM METHOD=GET ACTION="<?php echo "$PHP_SELF"; ?>">
Music:
<SELECT NAME="music">
	<OPTION>Yes</OPTION>
	<OPTION>No</OPTION>
</Select>
<input TYPE=SUBMIT VALUE="Submit">
</form>

<a href="notherpage.php?music=<?php echo "$music"; ?>">

That should get the job done! Works for my sites style sheets..

Weedpacket

switch($_REQUEST[mode]){
case "yes_music":
	$link = "$_SERVER[REQUEST_URI]&music=yes";
	break;
case "no_music":
	$link = "$_SERVER[REQUEST_URI]&music=no";
	break;
default:
	$link = "$_SERVER[REQUEST_URI]&music=yes";
}

Instead of using $SERVER['REQUEST_URI'] (which includes the querystring), use $SERVER['PHP_SELF'] (which doesn't). That stops the yesnoyesnoyesno businesss.

And, since the variable is in the querystring, you might as well use $GET[] instead of $REQUEST[]. More importantly, since the name of the field is 'music', that's what you need to look at in the array, not 'mode'. I.e., $_GET['music]. Third, since its possible values are 'yes' and 'no', those are the cases the switch has to check for. And of course, if the case is 'yes', the new link should say 'no' and vice-versa.

switch($_GET['music']){
case "no":
	$link = "$_SERVER['PHP_SELF']&music=yes";
	break;
case "yes":
	$link = "$_SERVER['PHP_SELF']&music=no";
	break;
default:
	$link = "$_SERVER['PHP_SELF']&music=yes";
}

Oh, and PS. Use $_GET['music'] lower down there instead of $music - there's a good chance that $music won't have a value.

Xzone5

I'm just curious...why not just show the media player console, and let the people hit play or stop or whatever they want. Set autostart as you wish. No PHP required.

Matt

stolzyboy

cuz that doesn't appeal to the eye, some people care about design, as do i

Xzone5

Well, perhaps, although smallconsole doesn't look all that bad, but of course it is your choice.

Matt

Mistah_Roth

Thanks weedpacket ill replace it with that code

And I still dont have anything DETERMINING which case it will goto (I dont want to use the forum because all I want is that link that when you click, it starts the music and changes to a different link, and then when clicked again turns it off and changes link again.

jebster

<a href="youpage.php?music=on">On</a>
<a href="youpage.php?music=off">Off</a>


<a href="notherpage.php?music=<?php echo "$_GET['music']"; ?>">

Simple enough... but probaly not the best way 🙁

Mistah_Roth

erm first of all it could be ANY link so i can just but whatever.php, it has to be the link thats already existing.

Second, the link thing is in an echo so how would I do that without the "