please check this out - what's wrong?

[virva]

You there! Can you help?

At first this code worked, but now it doesn't. I can't figure out what's wrong, I don't remember I had changed anything. So can you possibly tell me what's wrong there? (This piece of code may seem familiar to some people here 😉 )

//list all the files in the directory (this file is in the same directory)
listall("../php/"); 

function listall($dir_name)
{
   chdir($dir_name);  //change to directory

   $handle=opendir($dir_name);  // open the diretory 

   //loop
   $filearray = Array();
   while (false !== ($file = readdir($handle))) {

 // this far it works, I've tested with echo :-)

//this if-clause is somehow wrong??

   if((ereg(".shtml$", $file)) && ($file != '.') && ($file != '..') && !empty ($file)) {

   $filearray[] = $file;
   echo "$file<br>";

}
  }
}

Any idea? Thanks for your time anyway.

[bjwilke]

ereg(".*shtml$", $file)

should work better i think

[jayant]

See ur code

while (false !== ($file = readdir($handle))) {

 // this far it works, I've tested with echo :-)

I dont think so.

see the double '=' -> '==' in while condition.

try using:

while (false != ($file = readdir($handle))) {

 // this far it works, I've tested with echo :-)

[virva]

Sorry, but your advice didn't help at all. 🙁

Anyway, when I place something like 'echo "this far it works";' -stuff after the while-clause, it still gets printed out. But if I place it after if-clause, it doesn't. So I thought that maybe there's something wrong with it then.

I got the initial code from this thread: ( by shawon22)

www.phpbuilder.com/board/showthread.php?s=&threadid=10228110&highlight=directory

I changed it a bit, as you can see. And at first it worked, though it printed out not the filenames as I expected, but the word 'Array' as many times as I had .shtml files in my directory. But anyway it recognized the right files (I had links pointing to those pages too).

So, any other suggestions?

[xblue]

hi, I can't see why it fails right now, but a debugging suggestion:
split your conditions into several to see where it fails, something like this in your while loop:

// does this say Array? I think it shouldn't.
echo "file $file:<br />";

if((ereg(".shtml$", $file)) && ($file != '.') && ($file != '..') && !empty ($file)) {
    echo "shtml file<br />";

} else {
    if (!ereg(".shtml$", $file)){
        echo "ereg failed<br />";
    }
    if ($file == '.'){
        echo "file is .<br />";
    }
    if ($file == '..'){
        echo "file is ..<br />";
    }
    if (empty ($file)) {
        echo "empty variable<br />";
    }
}
// to separate files:
echo "<hr />";

hope it makes sense to you (and possibly helps)

[The_Chancer]

Try this one out for size... - Many thanks to Darren Beale see THIS thread for the example

$the_path="../php";

$handle = dir($the_path);
print "\n<b>File List</b><br>";
while ($file = $handle->read()) {
	if (($file != ".") && ($file != "..")) {
		print "\n" . $file . "<br>";
   }
}
print "<hr>";

Works for me...