Account Activation Key problem

[baffled_in_UK]

Hi,
I use the following code (taken from a thread on this board) to generate an account activation key.

function key_create() {
$letters = " ABCDEFGHIJKLMOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz1234567890";
$len=strlen($letters);
$num="12";
for ($i=0; $i < $num; $i++)
{
$_rand=rand(0,$len);
$key.=$letters{$_rand};
}
return($key);
}
key_create() ;
$key_act = md5($key);

the problem is that is always returns the same value... am I missing something.

Thanks

[nnichols]

function key_create() {
$letters = "  ABCDEFGHIJKLMOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz1234567890";
$len=strlen($letters);
$num="12";
for ($i=0; $i < $num; $i++)
{
$_rand=rand(0,$len);
$key.=$letters{$_rand};
}
return($key);
}

$key = key_create() ;
$key_act = md5($key);

You didn't store the value returned from the function 🙂

Hope this helps 😉

[baffled_in_UK]

The last line of the code is doing that. The problem is I get the same result not that I don't get a result at all.

But thanks for trying.

[nnichols]

The reason you are always getting the same result is because you are always passing a null into the md5() function.

You must assign the returned value to a variable (as in my previous post), which you are not doing with your current code.