what's wrong with this?

[itworks]

i have this function:

// função que mostra a lista de marcas existentes em marca
		function opcaoAMDDimm() {
			$sql = "SELECT DISTINCT modelo FROM produtos WHERE tipo LIKE '%intel%'";
			$rs=$this->bd->executarSQL($sql);

		$n=0;
		while(mysql_fetch_row($rs)){
		echo "<table width=\"100%\" border=\"0\" cellspacing=\"1\" cellpadding=\"5\" class=\"caixas\"><tr><td class=\"caixa\">";
		echo "<form method=\"post\" action=\"index.php?pagina=pc&status=ver
			&processador=".mysql_result($rs, 0, "processador")."\">";
		echo "<br><select name=\"processador\">";
		echo "<option value=\"" .mysql_result($rs, $n, "modelo"). "\">" .mysql_result($rs, $n, "modelo"). "\n";
		echo "</select><br>";
		echo "<br><input type=\"submit\" value=\"Construir PC\"></form>";
		echo "</td></tr></table>";
		$n++;
		}
	}

this prints a drop menu for each row found, which isn't very helpful.
how can o make it deliver all the results in one drop menu?

[trooper]

the reason you are getting many drop down boxes is because you have the line

echo "<br><select name=\"processador\">";

within the while loop. Move it outside the while loop and also move the line

echo "</select><br>";

outside the end of the while loop and it shoul work just fine

HTH

GM

Originally posted by itworks
i have this function:

// função que mostra a lista de marcas existentes em marca
		function opcaoAMDDimm() {
			$sql = "SELECT DISTINCT modelo FROM produtos WHERE tipo LIKE '%intel%'";
			$rs=$this->bd->executarSQL($sql);

		$n=0;
		while(mysql_fetch_row($rs)){
		echo "<table width=\"100%\" border=\"0\" cellspacing=\"1\" cellpadding=\"5\" class=\"caixas\"><tr><td class=\"caixa\">";
		echo "<form method=\"post\" action=\"index.php?pagina=pc&status=ver
			&processador=".mysql_result($rs, 0, "processador")."\">";
		echo "<br><select name=\"processador\">";
		echo "<option value=\"" .mysql_result($rs, $n, "modelo"). "\">" .mysql_result($rs, $n, "modelo"). "\n";
		echo "</select><br>";
		echo "<br><input type=\"submit\" value=\"Construir PC\"></form>";
		echo "</td></tr></table>";
		$n++;
		}
	}

this prints a drop menu for each row found, which isn't very helpful.
how can o make it deliver all the results in one drop menu? [/B]

[itworks]

i don't think i understood, is this what you meen?

// função que mostra a lista de marcas existentes em marca
		function opcaoAMDDimm() {
			$sql = "SELECT * FROM produtos WHERE tipo LIKE '%intel%'";
			$rs=$this->bd->executarSQL($sql);

		$n=0;
		echo "<table width=\"100%\" border=\"0\" cellspacing=\"1\" cellpadding=\"5\" class=\"caixas\"><tr><td class=\"caixa\">";
		echo "<form method=\"post\" action=\"index.php?pagina=pc&status=ver
			&processador=".mysql_result($rs, 0, "processador")."&memoria=".mysql_result($rs, 0, "memoria")."
			&motherboard=".mysql_result($rs, 0, "motherboard")."&disco=".mysql_result($rs, 0, "disco")."
			&cdrom=".mysql_result($rs, 0, "cdrom")."&dvd=".mysql_result($rs, 0, "dvd")."
			&placassom=".mysql_result($rs, 0, "placassom")."&placasgraficas=".mysql_result($rs, 0, "placasgraficas")."\">";
		echo "<br><select name=\"processador\">";
		while(mysql_fetch_row($rs)){
		echo "<option value=\"" .mysql_result($rs, $n, "modelo"). "\">" .mysql_result($rs, $n, "modelo"). "\n";
		}
		echo "</select><br>";
		echo "<br><input type=\"submit\" value=\"Construir PC\"></form>";
		echo "</td></tr></table>";
		$n++;

	}

this doesn't work!

thanks in advance

[trooper]

everything that is in the while loop will get executed for every record that is returned.

As you have <select name=...> and the </select> within the while loop then they are going to cause there to be many select boxes with only one value inside them

What you need to do is take the <select name =...> statement and put it outside the while loop and also take the </select> and put it at the bottom (out side the while loop)

HTH

GM

[itworks]

isn't the above what you meen?

i can't get this right!

thanks for helping.

[diego25]

Read this:

http://www.php.net/manual/en/function.mysql-result.php

It says:

Calls to mysql_result() should not be mixed with calls to other functions that deal with the result set

So you shouldn't be mixing mysql_result with mysql_fetch_row.

And in this case, if you're using mysql_result, you don't even need mysql_fetch_row....

And also, if you read the above page, it will tell you that mysql_fetch_* functions are generally faster than mysql_result, so try to learn how to use those functions.

Diego

[itworks]

thanks a lot, i'll read it.

people have been told me that before, it's just that this is a retalively large site and it's almost done, i'm not sure how to change it 'cause i'm very inexperienced and i have no idea how much work would it take.

i would very much like to follow your advice but i don't think i will without help.

anyway can anyone help me with the function in hand, what's wrong?

why do i get a drop menu for each result found, i want a drop menu with all the results.

thanks in advance.