What is run with my code?

timsharpe

I am getting the following error message:

Notice: Undefined variable: headline in e:\inetpub\wwwroot\news\news.php on line 5

Notice: Undefined variable: text in e:\inetpub\wwwroot\news\news.php on line 5

Notice: Undefined variable: link in e:\inetpub\wwwroot\news\news.php on line 5

and the code that I am using is:

<html>
<body>
<?php $db = mysql_connect("localhost", "user", "password");
mysql_select_db("mysql",$db);
$sql = "INSERT INTO news (headline, text, link) VALUES ('$headline','$text','$link')";
$result = mysql_query($sql);
echo "Thank you! Information entered.\n";
?>
<form method="post" action="<?php echo $PHP_SELF?>">
Headline:<input type="Text" name="headline"><br>
Text:<input type="Text" name="text"><br>
Link:<input type="Text" name="link"><br>

what am I doing wrong?

Thanks

Tim

eoghain

Well I'd guess that you either don't have a form submitting to this page with the variables $headline, $text, and $link. From your code it look like you do have this form submitting the proper values. But your code is setup to expect those values even if this is the first time the user has come to this page. Also you might not have register globals turned on in your php setup.

I'd suggest that you change your code to look like this:

<html> 
   <body> 
      <?php
         if (isset($_POST["submit"])) {
            $headline = $_POST["headline"];
            $text = $_POST["text"];
            $link = $_POST["link"];
            $db = mysql_connect("localhost", "user", "password"); 
            mysql_select_db("mysql",$db); 
            $sql = "INSERT INTO news (headline, text, link) VALUES ('$headline','$text','$link')"; 
            $result = mysql_query($sql); 
            echo "Thank you! Information entered.\n"; 
         }
      ?> 
      <form method="post" action="<?php echo $PHP_SELF?>"> 
      Headline:<input type="Text" name="headline"><br> 
      Text:<input type="Text" name="text"><br> 
      Link:<input type="Text" name="link"><br> 

  <input type="Submit" name="submit" value="Enter information"> 
  </form> 
   </body> 
</html>

This is safer code since it specifies that it's looking for the POSTED variables, and it also doesn't do anything if the user got to this page by not using the form.

timsharpe

Ok tried that and got this error why?

Parse error: parse error, unexpected '{' in e:\inetpub\wwwroot\news\news.php on line 4

Tim

eoghain

Oops, my bad I left out the closing ) on the IF statement. I've edited the above code so you shouldn't get that error.