Parse error when creating function(<-complete newbie)

[Darkbolt]

ok, I'm trying to create a system where the users on my site can
1)submit a review to the sql database
2)have it send me an email confirming they did this
3)create a page dynamically displaying the review

I've got one and two down, but on the third one i get a parse error on line 32

<?php 
include("db.php");
$review = $_POST['review'];
$name = $_POST['name'];
$email = $_POST['email'];
$review_name = $_POST['review_name'];

$query = "insert into reviews values ('$review_name', '$name', '$email', '$review')";
$result = mysql_query($query);
if(!$result){ 
    echo 'There has been an error submitting the review, please contact Darkbolt.'; 
} else {   

    $subject = "A user submitted a review!"; 
    $message = "$name has submitted a review called $review_name under the email adress of $email put it up until you learn how to automatically do that"; 
   mail("[e-mail]", "$subject", "$message"); 
    echo 'Your review has been submitted!  It will be posted within 72 hours! '; 

$fp = fopen("http://www.sfexplore.com/newnav/$reviewname.php", "w+");

function create_review()
{
$display = mysql_query ("SELECT * FROM reviews WHERE review_name = $review_name");

$row = mysql_fetch_array($display);

print $row["review"];
echo 'Written by $row["name"], $row["email"]';
}

$dbreview = create_review($review_name)

function review_file()
{
<?
include("http://www.sfexplore.com/reviewheader.php"); 
$dbreview;
include("http://www.sfexplore.com/reviewfooter.php");
?>
}

$outputstring = review_file($dbreview)

fwrite($fp,$outputstring)
} 

?>

now if you look at it, this is line 32

function review_file()

would someone please explain to me why I'm getting the parse error?

[mogster]

Erm... why the open and close <??> tags inside the function review_file() ?

And how is review_file supposed to know the value of $dbreview ?

At least you'll have to specify the function like this:

function review_file($dbreview) {
do_the_stuff;
}

This is what causes the error in my opinion - you have to specify the values to be sent into the function IF they're not created inside it.

knutm :-)

[mogster]

Here's how I'd written it - specifying the function first, then processing the script/calling the functions below 😉

knutm

<?php
include("db.php");

Functions

function create_review($review_name)
{
$display = mysql_query ("SELECT * FROM reviews WHERE review_name = $review_name");

$row = mysql_fetch_array($display);

print $row["review"];
echo 'Written by $row["name"], $row["email"]';
}

function review_file()
{
include("http://www.sfexplore.com/reviewheader.php");
$dbreview;
include("http://www.sfexplore.com/reviewfooter.php");
}

Script start

$review = $POST['review'];
$name = $POST['name'];
$email = $POST['email'];
$review_name = $POST['review_name'];

$query = "insert into reviews values ('$review_name', '$name', '$email', '$review')";
$result = mysql_query($query);
if(!$result){
echo 'There has been an error submitting the review, please contact Darkbolt.';
} else {

$subject = "A user submitted a review!";
$message = "$name has submitted a review called $review_name under the email adress of $email put it up until you learn how to automatically do that";
mail("[e-mail]", "$subject", "$message");
echo 'Your review has been submitted! It will be posted within 72 hours! ';

$fp = fopen("http://www.sfexplore.com/newnav/$reviewname.php", "w+");
$dbreview = create_review($review_name)
$outputstring = review_file($dbreview)
fwrite($fp,$outputstring)
}
?>

[mogster]

OH! :eek:

I noticed three syntax errors:

$dbreview = create_review($review_name)
$outputstring = review_file($dbreview)
fwrite($fp,$outputstring)

where each line needs a ;

knutm 😃

[mogster]

Honk-honk! :rolleyes:

Posting before reading again...

Fill in the value $dbreview again where the function is specified: function review_file($dbreview)

Then:
Cross your fingers and lo! - no parse errors (we hope) 😃

[Darkbolt]

first off, please excuse me if I seem rather ignorant on the matter, I'm new to php, and the best way of learning is with experiance, no?

anywho, i tried out that code that mr.mogster graciously edited for me (and i fixed his syntax errors as he pointed them out i might add)

there is an improvement, however now I get these errors:

Your review has been submitted! It will be posted within 72 hours!
Warning: fopen("http://www.sfexplore.com/newnav/.php", "w+") - Success in /home/sites/site14/web/postreview.php on line 37

Warning: Supplied argument is not a valid MySQL result resource in /home/sites/site14/web/postreview.php on line 8
Written by $row["name"], $row["email"]
Warning: Supplied argument is not a valid File-Handle resource in /home/sites/site14/web/postreview.php on line 40

now incase I hadnt made myself clear the first time,
what i want this script to do is create a page where the newly created page gets the review from the sql database and displays it

[mogster]

Ah...

I didn't check for sql-errors and the general exec of the script 😉

Well, since I'm already committed:
Why write a file to fetch the data from the db?

If you organize this in a different way, use an id (number) as key instead of review name. Then you might link this in to the "thing" 😃 the review is about.

A way to do it:
- create a table for what you're reviewing (with an unique id as key)
- create a field for this id in the table reviews.

Now you can ask for the "thing" you're reviewing, and do a subrequest for all reviews containing the "thingy"-id :p

App. like this:
select from thingy where thingy_id = 'x'
will give you the row where the reviewed articles data is contained.
Then you do a second request:
select from reviews where thingy_id = 'x' order by reg_time

This will produce the data from the main description of what is to be reviewed, then the reviews.

All you then need is one php-script to handle the data.
I'll post a suggestion later for the php IF you reveal what is to be reviewed 😉

Difficult to guess what the php may look like when I don't know the purpose.

knutm

[Darkbolt]

lol, the "thing" thats being reviewed is all sorts of sci-fi movies, and games and the like (if you're interested, www.sfexplore.com ...free plug 😛, but hey you asked 😛)

as for your question 'why write a file to fetch data from the db', the simple answer, as that's what I could figure out how to do easiest, as Ive said i'm quite new to php, so obviously I dont have the experiance as you or anyone else that may decide to help me🙂

[mogster]

Well, I HAD written a long and complete reply, but this #%¤¤% forum logged me out while writing it - thus erasing the whole post.

Why, oh why don't just use session cookies.... :rolleyes:

knutm

[Darkbolt]

you should have used the back button for it :p

[mogster]

Hir-hir, yeah, tried that, but the text was gone.

Ah well, here's some sql to create the id'ed table for reviews:

CREATE TABLE reviews (
review_id int(10) unsigned zerofill NOT NULL auto_increment,
rev_reg_time int(20) NOT NULL default '0',
review_name varchar(150) NOT NULL default '0',
name varchar(150) NOT NULL default '0',
email varchar(150) NOT NULL default '0',
review text,
PRIMARY KEY (review_id)
) TYPE=MyISAM;

There's many ways to do the timestamp, you may use mysql's timestamp/datetime, but here I just use a standard unix time inserted into an integer-field.

Here's a suggestion for the php for viewing the reviews:

<?PHP

The file for viewing reviews

include("db.php");

Functions

function view_review($review_id) {
$findDetails = mysql_query ("SELECT * FROM reviews WHERE review_id = '$review_id'");
$thisRow = mysql_fetch_array($findDetails);
$timed = date("m.d - Y", $thisRow[review_reg_time]);
echo "<h3>".$thisRow[review_name]."</h3><br>";
echo "<small>".$timed."</small><br>";
echo "By:&nbsp;<b>".$thisRow[name]."</b><br>";
echo "".$thisRow[review]."<br><hr width="100%" noshade><br>";
}

Page start

include("reviewheader.php");
$findId = mysql_query ("SELECT review_id, review_reg_time FROM reviews ORDER by review_reg_time DESC");
while($thisId = mysql_fetch_array($findId)) {
view_review($thisId[review_id]);
}
include("reviewfooter.php");
?>

To insert into mysql:

$review = $POST['review'];
$name = $POST['name'];
$email = $POST['email'];
$review_name = $POST['review_name'];
$thisTime = time();
$query = "insert into reviews values ('', '$thisTime' '$review_name', '$name', '$email', '$review')";
$result = mysql_query($query);
if(!$result){
echo 'There has been an error submitting the review, please contact Darkbolt.';
} else {
$subject = "A user submitted a review!";
$message = "$name has submitted a review called $review_name under the email adress of $email put it up until you learn how to automatically do that";
mail("[e-mail]", "$subject", "$message");
echo "Your review has been submitted! It will be posted within 72 hours!";
}
Note the empty '' first in the sql-sentence.

This code is meant as a suggestion only, since it's not tested ;-) It is also very quickly assembled...

I'm not sure how you're gonna get the 72 hrs time limit - in this code the review will be visible instantly.

knutm

[Darkbolt]

near as I can tell that looks good (which isnt very far lol), and I thank you for all your help thus far, tho I'm curious as to how I would link to that, to get it to display a review?

additionally, would it be too much to ask for you to explain to me exactly how the codes funtion?

[mogster]

To print a table with all headers as links, you might use a switch to switch 😉 between view headers-mode and view review-mode:

<?PHP
## The switched page between single/multi-mode ## 
include("db.php"); 

## Functions ## 
function doHeaders() { 
$findHeaders = mysql_query ("SELECT review_id, review_name, review_reg_time FROM reviews"); 
while($headerRow = mysql_fetch_array($findHeaders) { 
$htimed = date("m.d - Y", $headerRow[review_reg_time]); 
echo "<a href=\"review.php?run_control=single&review_id=$review_id\">".$headerRow[review_name]."</a><br>"; 
echo "<small>".$htimed."</small><br>";
}
}

function view_review($review_id) { 
$findDetails = mysql_query ("SELECT * FROM reviews WHERE review_id = '$review_id'"); 
$thisRow = mysql_fetch_array($findDetails); 
$timed = date("m.d - Y", $thisRow[review_reg_time]); 
echo "<h3>".$thisRow[review_name]."</h3><br>"; 
echo "<small>".$timed."</small><br>"; 
echo "By: <b>".$thisRow[name]."</b><br>"; 
echo "".$thisRow[review]."<br><hr width="100%" noshade><br>"; 
}

## Switch start ##
switch($run_control) {

# Single-mode #
case "single":
$review_id = $_GET['review_id'];
include("reviewheader.php");
view_review($review_id);
include("reviewfooter.php");
break;

# Default: list headers #
default:
include("reviewheader.php");
doHeaders();
include("reviewfooter.php");
}
?>

This will use the GET-variable. review_id, propagated by the link, to find the correct review to read
In addition you should print a link back to the header-list in the single-view, I suppose.
That would be the scriptname (review.php), without any run_control or id values.

Erm...again - this code comes with no guarantee as it's not tested by me 😃

knutm

[mogster]

There's a parse error in the above:

while($headerRow = mysql_fetch_array($findHeaders) {

should be

while($headerRow = mysql_fetch_array($findHeaders)) {

Forgot the closing )

knutm 😃

[Darkbolt]

i think you may have misunderstood my question, how would I link to that php page to have it display different reviews
ie
http://www.sfexplore.com/showreview.php?review_id=1

im assuming something to that sort, or am I mistaken?

[Darkbolt]

the code you posted gets me the defined error when i try to use the submit form i should add aswell

<?
$review = $_POST['review']; 
$name = $_POST['name']; 
$email = $_POST['email']; 
$review_name = $_POST['review_name']; 
$thisTime = time(); 
$query = "insert into reviews values ('', '$thisTime' '$review_name', '$name', '$email', '$review')"; 
$result = mysql_query($query); 
if(!$result){ 
echo 'There has been an error submitting the review, please contact Darkbolt.'; 
} else { 
$subject = "A user submitted a review!"; 
$message = "$name has submitted a review called $review_name under the email adress of $email put it up until you learn how to automatically do that"; 
mail("[e-mail]", "$subject", "$message"); 
echo "Your review has been submitted! It will be posted within 72 hours!"; 
} 
?>

[mogster]

Erm..yes, I don't understand what you mean. You should fill out your error-reporting a bit 😉

But:
Use the switched script as a standalone view-reviews page, then create another standalone page for posting reviews.

knutm

[mogster]

Code now cleaned up! For the fifth time!!

Or:
You could use a single file (index.php) to treat the whole process 😃

This makes for that file:

<?PHP
# The switched page between single/multi-mode with POST-routines ##
include("db.php"); 

###############
## Functions ##
###############

# Find headers #
function goHead() { 
$findThem = mysql_query("SELECT review_id, review_name, rev_reg_time FROM reviews ORDER by rev_reg_time desc"); 
while($hRow = mysql_fetch_array($findThem)) {
$htimed = date("m.d - Y", $hRow[rev_reg_time]); 
echo "<a href=\"index.php?run_control=single&review_id=$hRow[review_id]\">".$hRow[review_name]."</a><br>"; 
echo "<small>".$htimed."</small><br>";
}
}

# View review #
function view_review($review_id) { 
$findDetails = mysql_query("SELECT * FROM reviews WHERE review_id = '$review_id'"); 
$thisRow = mysql_fetch_array($findDetails);
$timed = date("m.d - Y", $thisRow[rev_reg_time]); 
echo "<h3>".$thisRow[review_name]."</h3>"; 
echo "<small>".$timed."</small><br>"; 
echo "By: <b>".$thisRow[name]."</b><br>"; 
echo "".$thisRow[review]."<br><hr width=\"100%\" noshade><br>";
}

# Clean up submitted vars prior to db-insert #
function dbIn($text) {
$text = strip_tags ($text);
$text = str_replace(chr(10),"",$text);
$text = str_replace(chr(13), "<br>", $text);
$text = addslashes($text);
return($text);
}

# Redirect-function #
function jump($file) {
echo "
<script> 
window.location.replace(\"$file\");
</script>
";
}
#######################
## Switch/page start ##
#######################
switch($run_control) {

# Treat submitted data and redirect to index #
case "Submit review":
$review = $_POST['review']; 
$name = $_POST['name']; 
$email = $_POST['email']; 
$review_name = $_POST['review_name'];
# Mail message - just compile the stuff prior to the db-safing #
$mailmessage = "$name has submitted a review called $review_name under the email adress of $email put it up until you learn how to automatically do that";
# Clean up the vars before db-insert! #
$review = dbIn($review);
$name = dbIn($name);
$email = dbIn($email);
$review_name = dbIn($review_name);
$thisTime = time(); 
$query = "insert into reviews values ('', '$thisTime', '$review_name', '$name', '$email', '$review')"; 
$result = mysql_query($query); 
# Check for error #
if(!$result){
include("reviewheader.php");
echo "There has been an error submitting the review, please contact Darkbolt.";
include("reviewfooter.php");
} else { 
$subject = "A user submitted a review!"; 
# Message piled above - send mail to you, then redirect poster to header-list where his submission wil be listed first #
mail("[e-mail]", "$subject", "$mailmessage");
jump("index.php");
}
break;

# Post form for reviews #
case "post":
include("reviewheader.php");
# You'll have to create this #
include("post_form.php");
include("reviewfooter.php");
break;

# Single-mode #
case "single":
$review_id = $_GET['review_id'];
include("reviewheader.php");
echo "<a href=\"index.php?run_control=post\">Post review!</a><br>"; 
view_review($review_id);
goHead();
include("reviewfooter.php");
break;

# Default: list headers #
default:
include("reviewheader.php");
echo "<a href=\"index.php?run_control=post\">Post review!</a><br>";
goHead();
include("reviewfooter.php");
}
?>

Remember that each case in the switch will be treated as a standalone page. That is, if the switch is in single mode - url: index.php?run_control=single - it will ignore all other cases in the switch, including default action.
If you're gonna use the code "as is", the following must be implemented:
- you must save the script as index.php (or change the name in the code above)
- your submit button in the post-form must be:
<input type="submit" name="run_control" value="Submit review">
- you must post the form to index.php

What this does is to print a list of links to all reviews posted when the page is loaded, most recent on top. When clicking the links, it shows the review requested. When clicking the Post review-link it'll include the post-form and on submit it'll insert the code into the db and redirect the client back to the header-list.

I hope 😃

Difficult to code something without testing the code, and there was a parse error in the previous post where I forgot to backslash some " 😉

knutm

[mogster]

And there's an error in the Post review-link:

echo "<a href=\"review.php?run_control=post\">Post review!</a><br>";

should be

echo "<a href=\"index.php?run_control=post\">Post review!</a><br>";

Help! :rolleyes: :eek: 😃

[Darkbolt]

I realize this must be difficult for you, and I thank you for all your efforts thus far...

as for your more recent code, theres a parse error on line 14

while($headerRow = mysql_fetch_array($findHeaders) {

less I'm mistaken

as for what I meant before, i meant how would i have made a hyperlink to display a specific review