Double check

[JakesSA]

Ive got check boxes that I need to populate from two diffrent tables. In the following code, If a user has selected a 6 categories it will loop out each category 6 times in the whole set...I know why it is happening...its because Its loop out the second sql query, but its the only way I get them checked.

If anyone can help...thanks

$sql = "SELECT  cat.category_id,
                cat.name				
		   FROM categories cat";	   

$resultCat = mysql_query($sql, $connect);
echo "<form><table>";
while($data = mysql_fetch_array($resultCat))
{ 
  $sql2 = "SELECT  mcat.cat_select_id
 			FROM  tblmembers mem, categories cat, members_categories mcat
		   WHERE (mem.member_id = mcat.member_id) AND
       			 (mcat.cat_select_id = cat.category_id) AND
      			 (mem.customer_id = cat.customer_id) AND
     		   	 (mem.email = '$email')";

  $resultIn = mysql_query($sql2, $connect);
 while($selected = mysql_fetch_array($resultIn))
             {   

    echo "<tr><td><input type=\"checkbox\" name=\"".$data['name']."\" value=\"".$data['category_id']."\""; 
		 if($data['category_id'] === $selected['cat_select_id']) {
			   $selected['cat_select_id'] = ' checked';
					 echo $selected['cat_select_id']; }
						echo "></td><td>".$data['name']."</td></tr>";
           }
     	} 
     echo "<tr><td></td><td><input type='button' value='submit' name='submit'></td></tr>";
  echo "</table></form>";

[xblue]

Hi,

it's not really easy to know what you want - just a question, what criteria do you use to indent your code?
I don't see anything that happens based on user input for example.

anyway, if the problem is that you need ids from query one to use in your second while loop, I'd separate them e.g. like:

$sql = "SELECT  category_id, name FROM categories";
$resultCat = mysql_query($sql, $connect);
while ($data = mysql_fetch_array($resultCat)) {
    $id_list[]=$data['category_id'];
}

$sql2 = "SELECT  mcat.cat_select_id
         FROM  

         tblmembers mem, 
         categories cat, 
         members_categories mcat
         WHERE 
         (mem.member_id = mcat.member_id) AND
         (mcat.cat_select_id = cat.category_id) AND
         (mem.customer_id = cat.customer_id) AND
         (mem.email = '$email')";

$resultIn = mysql_query($sql2, $connect);
echo "<form><table>";
while ($selected = mysql_fetch_array($resultIn)) {
    echo "<tr><td><input type=\"checkbox\" name=\"".$data['name']."\" value=\"".$data['category_id']."\"";
    if (in_array($selected['cat_select_id'], $id_list)) {
        echo ' checked';    

    }
    echo "></td><td>".$data['name']."</td></tr>";
}
echo "<tr><td></td><td><input type='button' value='submit' name='submit'></td></tr>";
echo "</table></form>";

[JakesSA]

The first part (first loop) of the orginal query is to pull out the names and values of all the categories, the second part (or second loop) of the query is to pull out the data, that the user has selected previously.

What happens is that it loops out all the categoies 6x's if the user has selected 6 categories .......(40 categories X 6). Thats becuase looping the second query.

Any ideads

$sql = "SELECT  cat.category_id,
                cat.name                

           FROM categories cat";       

$resultCat = mysql_query($sql, $connect);
echo "<form><table>";
while($data = mysql_fetch_array($resultCat)) //<<<----------pull all the categories and categories names (First Loop)
{ 
  $sql2 = "SELECT  mcat.cat_select_id
             FROM  tblmembers mem, categories cat, members_categories mcat
           WHERE (mem.member_id = mcat.member_id) AND
                    (mcat.cat_select_id = cat.category_id) AND
                   (mem.customer_id = cat.customer_id) AND
                     (mem.email = '$email')"; //<<<--------------Global POST to find user

  $resultIn = mysql_query($sql2, $connect);
 while($selected = mysql_fetch_array($resultIn)) //<<<---Pull what the user has selected previously (Second Loop)
             {   

    echo "<tr><td><input type=\"checkbox\" name=\"".$data['name']."\" value=\"".$data['category_id']."\""; 
         if($data['category_id'] === $selected['cat_select_id']) {
               $selected['cat_select_id'] = ' checked';
                     echo $selected['cat_select_id']; }
                        echo "></td><td>".$data['name']."</td></tr>";
           }
         } 
     echo "<tr><td></td><td><input type='button' value='submit' name='submit'></td></tr>";
  echo "</table></form>";