I need help with INSERT

[darkfunkel]

I have been trying to do this for over a week and thought it time for me to seek help. I want to insert data from variables into the database, the Variable data will be inserted into a field of the same name I.E $foo will be entered into the field foo. The code I am using is shown below

$query = "INSERT INTO `releases` (`Filmgame_name`, `Review`, `Shout_Out`, `Length`, `Frames`, `codec`, `bitrate`, `sound`, `note`, `lang`, `size_in_mb`, `cover_link`, `edonkey_links`) VALUES('$Filmgame_name' , '$Review', '$Shout_Out', '$Length', '$Frames', '$codec', '$bitrate', '$sound', '$note', '$lang', '$size_in_mb', '$imdb_link', '$cover_link', '$edonkey_links')";

Could you help me fix this code please? the variables are defined from an URL I.E sql.php?foo=blah would insert blah into the table foo. If you could help me with this code I would be grateful

[nnichols]

If you execute your query with the following code it should give you meaningful errors which will help you figure out what is wrong -

$query = "your query";
$res = mysql_query($query, $db) or die('MySQL error: ' . mysql_error() . '<br>Query: ' . $query);

Hope this helps 😉

[scvsys]

Wow. The lack of line breaks made the reply form all wacky.

This looks like a routine query. I do these all the time without the backticks everywhere. Let's look at the query, formatted in a reasonable way:

$query = "INSERT INTO releases (
Filmgame_name, Review, Shout_Out,
Length, Frames, codec,
bitrate, sound, note,
lang, size_in_mb, cover_link,
edonkey_links)
VALUES
('$Filmgame_name' , '$Review', '$Shout_Out',
'$Length', '$Frames', '$codec',
'$bitrate', '$sound', '$note',
'$lang', '$size_in_mb', '$imdb_link',
'$cover_link', '$edonkey_links')";

Well look at that. I like to have just 3 or 4 fields per line, for readability. But if you look at your values list, there are one too many fields -- $imdb_link isn't in the field list. There's your problem. The fields and values need to match up.

Note that you also need to check your variables to make sure they're compatible with SQL. If they contain any single quote characters (among other things), your query will fail.

= scott

[scvsys]

Wow. The lack of line breaks made the reply form all wacky.

This looks like a routine query. I do these all the time without the backticks everywhere. Let's look at the query, formatted in a reasonable way:

$query = "INSERT INTO releases (
Filmgame_name, Review, Shout_Out,
Length, Frames, codec,
bitrate, sound, note,
lang, size_in_mb, cover_link,
edonkey_links)
VALUES
('$Filmgame_name' , '$Review', '$Shout_Out',
'$Length', '$Frames', '$codec',
'$bitrate', '$sound', '$note',
'$lang', '$size_in_mb', '$imdb_link',
'$cover_link', '$edonkey_links')";

Well look at that. I like to have just 3 or 4 fields per line, for readability. But if you look at your values list, there are one too many fields -- $imdb_link isn't in the field list. There's your problem. The fields and values need to match up.

Note that you also need to check your variables to make sure they're compatible with SQL. If they contain any single quote characters (among other things), your query will fail.

= scott

[darkfunkel]

using this code (a snippet)

 $query = "INSERT INTO `releases` ( `cat` , `Filmgame_name` , `Review` , `Shout_Out` , `Length` , `Frames` , `codec` , `bitrate` , `sound` , `note` , `lang` , `size_in_mb` , `cover_link` , `edonkey_links` , `imdb_link` ) 
VALUES (
'$cat', '$Filmgame_name', '$Review', '$Shout_Out', '$Length', '$Frames', '$codec', '$bitrate', '$sound', '$note', '$lang', '$size_in_mb', '$cover_link', '$edonkey_links', '$imdb_link'); 
$result = mysql_query($query)";
echo 'Item Entered.'; 

it seems to parse fine but when I check the database I get an error, below is a list of the tables in the database

uid cat Filmgame_name Review Shout_Out Length Frames codec bitrate sound note lang size_in_mb cover_link edonkey_links imdb_link

with a space being a new table, could you try and debug it please?

[darkfunkel]

any one got any ideas?

[mogster]

What error do you get?

And why the backticks?
The table list in the query also have double spaces around the comma separator - don't know if this might impact on the result.

Instead of:
INSERT INTO releases ( cat , Filmgame_name , Review , Shout_Out , Length

try

INSERT INTO releases (cat, Filmgame_name, Review, Shout_Out, Length ....

knutm

[darkfunkel]

with this code

$query = "INSERT INTO releases (cat, Filmgame_name, Review, Shout_Out, Length, Frames, codec, bitrate, sound, note, lang, size_in_mb, cover_link, edonkey_links, imdb_link) 
VALUES (
'$cat', '$Filmgame_name', '$Review', '$Shout_Out', '$Length', '$Frames', '$codec', '$bitrate', '$sound', '$note', '$lang', '$size_in_mb', '$cover_link', '$edonkey_links', '$imdb_link'); 
$result = mysql_query($query)";
echo 'Item Entered.';

it doesn't insert. I am positive that the connect string is right how could I make it show the MySQL error?

[nnichols]

As I said before -

$query = "INSERT INTO releases (cat, Filmgame_name, Review, Shout_Out, Length, Frames, codec, bitrate, sound, note, lang, size_in_mb, cover_link, edonkey_links, imdb_link) 
VALUES (
'$cat', '$Filmgame_name', '$Review', '$Shout_Out', '$Length', '$Frames', '$codec', '$bitrate', '$sound', '$note', '$lang', '$size_in_mb', '$cover_link', '$edonkey_links', '$imdb_link')"; 
$result = mysql_query($query) or die('MySQL error: ' . mysql_error() . '<br>Query: ' . $query);
echo 'Item Entered.';

at least this way it will give you a useful error message if/when it fails.