Limiting Uploaded File Size

[future_man]

Hello,

I'm working on some upload file functionality and have run into the following problem.

The application is setting the MAX_FILE_SIZE constant, and anytime an image is upload greater than this size the app blows with an ugly error.

I need to somehow catch this error and display a nicer message to the user.

I've tried using filesize() to do a compare on the max size, but the function blows with the same error.

Here's the code:

if ($action == "upload") {
	// check the filesize
	if(filesize($binFile) > $max_agent_upload) {
		echo "The file is too big!";
		exit;
	} else {
		if (isset($binFile) && $binFile != "none") {
			$data = addslashes(fread(fopen($binFile, "r"), filesize($binFile)));
			$strDescription = addslashes(nl2br($txtDescription));
			$sql = "INSERT INTO agent_tbl_Files ";
			$sql .= "(description, bin_data, filename, filesize, filetype, owner, agentnum) ";
			$sql .= "VALUES ('$strDescription', '$data', ";
			$sql .= "'$binFile_name', '$binFile_size', '$binFile_type', '$current_user', '$current_user')";
			if (!mysql_query ($sql, $link) ) {
				die (mysql_error());
			}
			echo "Your image has been added ($binFile_name).";
		}
	}
}

It works fine when the image is less than the max size.

Any help would be greatly appreciated.

Thanks,
John

[xblue]

check if $binfile exists. if the file is larger than the maximum size specified either in the form or in you server settings, it will not be received at all.

and please post the error message next time, all errors are "ugly errors" in some way 😉

[future_man]

Thanks xblue...

Actually, the problem seems to have compounded. Now I can't even get a small file to upload. It seems that that the script on has recently stopped working. I've done some research and it was suggested that it might be related to the file upload settings on the server.

Here's the code:

if ($action == "upload") {
    if (isset($binFile) && $binFile != "none") {
        $data = addslashes(fread(fopen($binFile, "r"), filesize($binFile)));
        $strDescription = addslashes(nl2br($txtDescription));
        $sql = "INSERT INTO agent_tbl_Files ";
        $sql .= "(description, bin_data, filename, filesize, filetype, owner, agentnum) ";
        $sql .= "VALUES ('$strDescription', '$data', ";
        $sql .= "'$binFile_name', '$binFile_size', '$binFile_type', '$current_user', '$current_user')";
        if (!mysql_query ($sql, $link) ) {
            die (mysql_error());
        }
        echo "Your image has been added ($binFile_name).";
    }
}

Here's the error I'm getting:

Warning: fopen("", "r") - Success in /home/quickoff/public_html/listings/dsp_accountedit.php on line 37

Warning: stat failed for (errno=2 - No such file or directory) in /home/quickoff/public_html/listings/dsp_accountedit.php on line 37

Warning: fread(): supplied argument is not a valid File-Handle resource in /home/quickoff/public_html/listings/dsp_accountedit.php on line 37

Any ideas?

Thanks,
John