Simple question: Problem with an If: True/False

[LiquidCD]

Okay, this is going to be a silly question but I am having a problem with a particular statement in my code.

I have a field in my table structure called 'valid_em'. This is setup as a text field that has a simple Yes or No in it. This is supposed to be a check to see whether or not the surname the email field is attached to is valid (by valid - I mean is it a working email address).

I tried to write some code that if a check of this field encounters a "No", it will place an image at the end of the data that displays the email as not being valid.

I thought my code was correct, but it is not. If I reset the if value to 0, and it puts the image at the end of every single point.

Somewhere then, my database structure and field may not be set correctly. So, do I need to change the field structure for valid_em or can I slightly modify my code. I prefer an answer on the correct way to approach this.

The code:

<?php 

//Set the number of columns for the page
$columns = 6;

$dbh=@mysql_connect ("$dbhost", "$dbuser", "$dbpass") or die ('I cannot connect to the database because: ' . mysql_error());
mysql_select_db ("$dbname"); 

$qrySurname__letter = "%";
// Output letters as links: (Ascii range from 65 to 90 are letters A to Z!) 
for($x=65;$x<=90;$x++)
{
if ($x==ord($subsel)) echo "<b>".chr($x)."</b>";
else
echo "<a href=\"surnametest3.php?letter=".chr($x)."\">".chr($x)."</a> "; 
} 

$letter = $_GET["letter"];
if (isset($letter)) 
{
$qrySurname = "SELECT * FROM surnames WHERE nm_surname LIKE '$letter%' ORDER BY nm_surname";
} else { 
$qrySurname = "SELECT * FROM surnames ORDER BY nm_surname";
}
$result = mysql_query($qrySurname);

//Need to know the number of rows, so use this line
$num_rows = mysql_num_rows($result);
//Set a new variable called $rows
$rows = ceil($num_rows / $columns);

//For this vertical display, need to run another loop, which will populate an array with our values
while($row = mysql_fetch_array($result)) {
	$data[] = $row['nm_email'];
	$data2[] = $row['nm_surname']; 
}
echo "<TABLE BORDER=1 cellpadding=5 align=center>\n";

for ($i = 0; $i < $rows; $i++) {
	 echo "<tr>";
	 for ($j = 0; $j <$columns; $j++) {
	    if(isset($data[$i + ($j * $rows)])) {
        echo "<td><li> <A HREF=\"mailto:".$data[$i + ($j * $rows)]."\">".$data2[$i + ($j * $rows)]."</li>";
	    }
	    if ($valid_em ==1) {  //<=== THINK PROBLEM IS HERE
		echo "<img src=\"exclamation.jpg\"></td>";
		}
	 }
	 echo "</tr>";
}
echo "</table>";
?>

[PHPdev]

First where are you ever setting a value into the $valid_em?

Secondly you are storing a "Yes" or "No" in the db or are you storeing a 1 or 0?

If storing a "Yes", "No" then you probably need to do something like

if (strcmp("Yes", $valid_em) == 0)

Let me know if this does not solve your problem...

PHPdev

[LiquidCD]

First question: The valid_em is only a field within my table structure. While this field is part
of the structure, I am only displaying the surname linked by the email address and doing
a check for a 'yes' or 'no' within the valid_em field.

So, to answer your other question, currently storing a "yes" or "no" in the valid_em filed
within the table.

Will try what you gave me and see how it works out (and will let you know either way).

[LiquidCD]

Based on your questions, I figured out my problem. For clarity in what I am doing here is some additional information:

Database structure (4 fields)

| nm_surname | nm_email | valid_em | valid_mem |

| Smith | [e-mail] | Yes | n/a |

| Jones | [e-mail] | No | |

.
.
.
n

Etc. There are 3400 surnames stored in this database.

When I build the page, I populate an array with nm_surname and nm_email and have it return a table with a max of 6 columns in vertical order. I added the array $valid_em$, and then made the call

if (strcmp("No", $valid_em[$i + ($j * $rows)])==0) {
		echo "<img width=13 height=12 align=absmiddle src=\"exclamation.jpg\" border=0></td>";

If the result returned is a "No", then it adds a small jpg image (exclamation point) to the end of the surname. This way, as people browse the database, they will know that the current email contact for that name is not valid.

I think I will look into using just 1's or 0's for this instead of Yes and No. Since there are volunteers who will assist with future updates, trying to make it as easy as possible for them.

Thanks for the questions..made me see where my problems were.

Richard

The changed code is:

while($row = mysql_fetch_array($result)) {
	$data[] = $row['nm_email'];
	$data2[] = $row['nm_surname'];
	$valid_em[] = $row['valid_em']; 
}
echo "<TABLE BORDER=1 cellpadding=5 align=center>\n";

for ($i = 0; $i < $rows; $i++) {
	 echo "<tr>";
	 for ($j = 0; $j <$columns; $j++) {
	    if(isset($data[$i + ($j * $rows)])) {
        echo "<td><li> <A HREF=\"mailto:".$data[$i + ($j * $rows)]."\">".$data2[$i + ($j * $rows)]."</li>";
	    }
	    if (strcmp("No", $valid_em[$i + ($j * $rows)])==0) {
		echo "<img width=13 height=12 align=absmiddle src=\"exclamation.jpg\" border=0></td>";
		}
	 }
	 echo "</tr>";
}
echo "</table>";