grabbing dynamic files

tito

I am using a great rating system. I php include it in a file, and it automatically creates a filename.dat to record the votes.

the code:

$ficdest=explode(".",basename($PHP_SELF));
$ficdest=$ficdest[0].".dat";
if(file_exists($ficdest)) {
$compteur=fopen($ficdest, "r");
$old_stats=file($ficdest);
$stats=explode("|", $old_stats[0]);
fclose($compteur);
$new_count=$stats[0];
if ($stats[3] != $REMOTE_ADDR) {
$new_count +=1;
}

the problem:

if the page is not terminated by .php, .html or .shtml it will ignore it and does not create the file, or simply create all the files for the different pages as rate.dat, all with the same name.

the question:

How can I alter the above code to interpret pages such as
http://site.com/stay.php?action=show&ID=1

If the page terminates as stay.php, all is fine. But what I need is to be able to catch the entire string.

I tried virtually all I know.

Thanks for any suggestions

diego25

Instead of
$ficdest=explode(".",basename($PHP_SELF));

try

$ficdest=$PHP_SELF . '?' . $QUERY_STRING;

Diego

tito

sorry, that did not work. Thanks for trying

diego25

What part didn't work as expected?

Diego

tito

the file was not created and therefore the vote was not registered

diego25

Oops, sorry. Actually, it should have been created, just not in the place you were looking at 🙂

try this then:

$ficdest=basename($PHP_SELF) . '?' . $QUERY_STRING;

That will create the file in the same directory as the file.

Diego

tito

that created a file named r.dat

tito

for example, when I use it with http://site.com/magazine/articles/article_117.php it creates me a file named article_117.dat

diego25

You know, you are supposed to do some debugging on your own too 🙂

Use this:

$ficdest=basename($PHP_SELF) . '?' . $QUERY_STRING . '.dat';

and remove

$ficdest=$ficdest[0].".dat";

Diego

tito

trust me I tried all combinations already.
the latest one returns rate.php?.dat

diego25

Fine, so check first if $QUERY_STRING is empty...If it's empty, then don't append it. If it's not empty, append it. That'll get rid of the question mark.

Diego

tito

query string is not empty
/stay.php?action=show&ID=1

but the funny part, instead of returning stay.php?action=show&ID=1.dat or to the least the last part of the query, 1.dat, it is returning the script that I included rate.php as rate.php?.dat, which itself is empty.

When I include rate.php in other dynamically generated pages without query string such as article_117.php I get article_117.dat
it seems to me that rate.php does not know where she is, so instead of creating the file, she creates herself.

diego25

Well, one way to solve that is to put the rate stuff into a function, and then call that function from the includer (i.e. the script that includes rate.php) script with:

func($PHP_SELF, $QUERY_STRING)

that way the right variables will get passed.

Diego

tito

in my common.php
I did:

func($PHP_SELF, $QUERY_STRING) {

entire rate script without the <? ?>

}

removed the include and before I event get a chance to include that function in stay.php, I got a blank page on refresh.