image upload with PHP4.3

meghanju

Hello....

I am encountering a problem while uploading images. I am using PHP-4.3 and apache 2.0.43. The uploaded image is always corrupted. The size of image also increases on uploading.
The code I am using is as follows:

upload.php

<html>
<body>
<form enctype="multipart/form-data" action="submit1.php" method="POST">
<table>
<tr>
<td>File to be uploaded</td>
<td><input type="file" name="img" value=""></td>
</tr>
<tr>
<td><input type="submit" value="Upload"></td>
</tr>
</table>
</form>
</body>
</html>

submit1.php

<html>
<body>
<?
$image = $HTTP_POST_FILES ["image"]["tmp_name"];
$image_name = $HTTP_POST_FILES ["image"]["name"];
if ($image != "") {
$dest = "upload";
$fname = $dest."/".$image_name;
move_uploaded_file($image,$fname)
or die ("couldnt copy file");
}
?>
I tried copy($image,$fname); also.
But the image is getting corrupted.
Can anybody help me......

--
Anjana

Vincent67

Anjana,

copy() should work fine. Also, enter the full path for $dest, like $det = "/home/usr/your/path/";

Hope this help....

Vincent

meghanju

I tried that too....
But no use...🙁
Is this a problem with PHP4.3. The same code works fine with PHP-4.0.6.

diego25

Always mention your PHP version 'cause sometimes it makes a lot of difference 🙂

Use $_FILES instead of $HTTP_POST_FILES.

Diego

bombshell

in php4.30,use $_FILES[]

$FILES['img']['name'] //the file name
$FILES['img']['type']//the file type
$FILES['img']['size']//the file size
$FILES['userfile']['tmp_name']// the file in the server temporary name

meghanju

Thanks for the help...
But.. still not working.... 😕

sijis

why can't you try something like this:

exec("mv $image '/html/location/images/$image_name'");

bombshell

<?php
// In PHP earlier then 4.1.0, $HTTP_POST_FILES should be used instead of $FILES.
if (is_uploaded_file($FILES['userfile']['tmp_name'])) {
copy($FILES['userfile']['tmp_name'], "/place/to/put/uploaded/file");
} else {
echo "Possible file upload attack. Filename: " . $FILES['userfile']['name'];
}
/ ...or... /
move_uploaded_file($_FILES['userfile']['tmp_name'], "/place/to/put/uploaded/file");
?>