Problems Processing Form Array

nigel_belanger

I have a form that is generated from data from a data base. I use the following to display

while ($x = mysql_fetch_row($dbaseQuery)
{
<input type="hidden" name="LineID[]" value="<?php echo $x[0]; ?>">
<input type="checkbox" name="DeleteItem[]" value="DELETE">
}

Now on the next page that processes the code, i have the following:

if ($UpdateCart) // Submit Form Variable - was it submitted?
{
for ($i = 0; $i <= count($LineID);$i++)
{
if ($DeleteFromCart['$i'] == "DELETE")
{
$RemoveItemQuery = "DELETE FROM dbase WHERE LineID = '".$LineID['$i']."' ";
echo $RemoveItemQuery;
$RemoveItemResult = mysql_query($RemoveItemQuery);
}
}
}

When I try to run this, it will not delete the items that I have checked to be deleted - what am I doing wrong?

Thank you very much for the help! I sure could use it...

xblue

I don't think this is the easiest approach.

for a start, I'd use the ids as values instead of these additional hidden fields:

<?php
while ($x = mysql_fetch_row($dbaseQuery) 
{ 
?>
<input type="checkbox" name="DeleteItem[]" value="<?php echo $x[0]; ?>"> 
<?php
}

then on your processing page, you can compose a comma-separated list of ids that were checked:

$id_list = implode(',', $_REQUEST['DeleteItem']); // or use $_POST or $_GET

and you'd need one query only, something like:
$sql = "DELETE FROM dbase WHERE LineID IN ($id_list)";
mysql_query($sql) or die (mysql_error());

ahundiak

Just to follow up a bit on what xblue posted, the basic problem is that $DeleteItem[] will only contain entries for those check boxes that were actually checked. So if you has say 10 items, and 3 were checked then count($DeleteItem) would be 3 while count(LineID) would be 10.

So your original approach just won't work. Store the id's in $DeleteItem as xblue suggested.

RedDragon

try this for deleting multiple items with checkboxes:

//form
<input type="checkbox" name="delete[]" value="<?php echo $id ?>" />

// process
for($x=0;$x<sizeof($delete);$x++) {
    mysql_query("DELETE FROM table WHERE (value='$delete[$x]')");
}