bad code

ishbo

Why does the following code not work?

<html>
<head>
<title>Your class Average</title>
</head>
<body>
<?php
// grade forumla - edit based on number of tests, quizzes, etc.
$grade = "(((($testg1 + $testg2) / 2) 40) + ((($quizg1 + $quizg2 + $quizg3 + $quizg4) / 4) 20) + ((($vocabg1 + $vocabg2 + $vocabg3 + $vocabg4) / 4) 20) + ((($hmwkg1 + $hmwkg2 + $hmwkg3 + $hmwkg4) / 4) 10) + ((($journg1 + $journg2 + $journg3 + $journg4 + $journg5) / 5) * 10)) / 100";

echo "$grade";

//To show the letter grade
if ($grade > 77){
echo "A";
}
else {
echo "Not even at least a C. sorry."
?>
</body>
</html>

$grade comes from this page:

<html>
<head>
<title>Enter your grades</title>
</head>

<body>

<form action="grade.php" method="post">
Test Grade 1: <input type="text" name="testg1">
Test Grade 2: <input type="text" name="testg2"><br><br>
Quiz Grade 1: <input type="text" name="quizg1">
Quiz Grade 2: <input type="text" name="quizg2">
Quiz Grade 3: <input type="text" name="quizg3">
Quiz Grade 4: <input type="text" name="quizg4"><br><br>
Vocab Grade 1: <input type="text" name="vocabg1">
Vocab Grade 2: <input type="text" name="vocabg2">
Vocab Grade 3: <input type="text" name="vocabg3"><br>
Vocab Grade 4: <input type="text" name="vocabg4"><br><br>
HMWK Grade 1: <input type="text" name="hmwkg1">
HMWK Grade 2: <input type="text" name="hmwkg2">
HMWK Grade 3: <input type="text" name="hmwkg3"><br>
HMWK Grade 4: <input type="text" name="hmwkg4"><br><br>
Journal Grade 1: <input type="text" name="journg1">
Journal Grade 2: <input type="text" name="journg2">
Journal Grade 3: <input type="text" name="journg3"><br>
Journal Grade 4: <input type="text" name="journg4">
Journal Grade 5: <input type="text" name="journg5"><br><br>

</form>

</body>
</html>

planetsim

Im not sure any errors or anything like that

ExSpectator

i use this

<select name="form[grade]>">
<option value=Option1> Option1</option>
<option value=Option2> Option2</option>
</select>

ishbo

To elaborate:
The form page works fine, but when the "calculate" button is hit, it takes you to grade.php and then gives Parse error: parse error in c:\apache\htdocs\grade.php on line 22. Exspectator, where do i need to place that code?

diego25

Why is
$grade = "(((($testg1 + $testg2) / 2) 40) + ((($quizg1 + $quizg2 + $quizg3 + $quizg4) / 4) 20) + ((($vocabg1 + $vocabg2 + $vocabg3 + $vocabg4) / 4) 20) + ((($hmwkg1 + $hmwkg2 + $hmwkg3 + $hmwkg4) / 4) 10) + ((($journg1 + $journg2 + $journg3 + $journg4 + $journg5) / 5) * 10)) / 100";

inside a string? If you put it inside a string, it won't do the math calculations!

Also, which one's line 22? Please don't make us count...Also the wordwrap here can make the count inprecise.

Diego

xblue

the power of ...? ah, right, the power of semicolons it was. there is one missing with your echo statement:

echo "Not even at least a C. sorry."

ishbo

Sorry for, well, basically, being a newbie. Line 22 happens to be the line after </html>. What do i do with the $grade = formula if not in a string?

thank you all.

ishbo

Xblue,
I just put in the semi-colon and I still get the parse error message for line 22.

Teen0724

Try spliting it up, make all the adverage things seperate and recombine them at the end. I belive in KISS, Keep It Simple Stupid.

diego25

Take it out of the string:

$grade = (((($testg1 + $testg2) / 2) 40) + ((($quizg1 + $quizg2 + $quizg3 + $quizg4) / 4) 20) + ((($vocabg1 + $vocabg2 + $vocabg3 + $vocabg4) / 4) 20) + ((($hmwkg1 + $hmwkg2 + $hmwkg3 + $hmwkg4) / 4) 10) + ((($journg1 + $journg2 + $journg3 + $journg4 + $journg5) / 5) * 10)) / 100;

Diego

ishbo

Taking it out of the string still returns the parse error in line 22