Adding incremental number to duplicate filenames

[kilbey1]

Another image question. This small bit of code checks to see if an image exists in the database with the same filename. I've got it set up so that each time it finds something existing, it tacks on 1_ to the beginning of the filename and uploads it. IE myimage.gif to 1_myimage.gif.

Fine, but then I see a problem. If someone uploads myimage.gif again, it would overwrite/reuse 1_myimage.gif. I suppose I would need to have 2_myimage.gif.

What is the solution here? The chance of having duplicates will be slim in this application, but I want to be prepared.

	while ($query_row = mysql_fetch_array ($query_image)) {

	if ($userfile_name == $query_row['picture']) {
		echo "Filename exists. Creating new filename.";
		echo " - ";
		echo $query_row[picture];
		echo "<BR>";
		$userfile_name = "1_".$query_row['picture'];
		echo "New filename.";
		echo " - ";
		echo $userfile_name;
		echo "<BR>";
	} 
	else {
		echo "Uploading image.<br>";
		echo "<BR><BR>";
		echo $query_image;
		//$userfile_name = "default.gif";
	} 

}

[D-ToX]

have you thought of using a while loop with $n++

[kilbey1]

Can you show me how this is done? I've set it up unsuccessfully like so:

	while ($n = 1; $n++; $query_row = mysql_fetch_array ($query_image)) {

	if ($userfile_name == $query_row['picture']) {
		echo $query_row[picture];
		echo "<BR><BR>";
		echo "Filename exists. Creating new filename.";
		echo "<BR>";
		$userfile_name = $n."_".$query_row['picture'];
		echo "New filename.";
		echo " - ";
		echo $userfile_name;
		echo "<BR>";
	} 
	else {
		echo "Uploading image.<br>";
		echo "<BR><BR>";
		echo $query_image;
		//$userfile_name = "default.gif";
	} 

}

and like

	while ($query_row = mysql_fetch_array ($query_image)) {
		$n = 0; 
		$n++; 
		if ($userfile_name == $query_row['picture']) {
			echo $query_row[picture];
			echo "<BR><BR>";
			echo "Filename exists. Creating new filename.";
			echo "<BR>";
			$userfile_name = $n."_".$query_row['picture'];
			echo "New filename.";
			echo " - ";
			echo $userfile_name;
			echo "<BR>";
		} 
		else {
			echo "Uploading image.<br>";
			echo "<BR><BR>";
			//echo $query_image;
			//$userfile_name = "default.gif";
		} 

[D-ToX]

thought about that reply and i suppose it was not of much use to you.

try using something like this

$newfile = substr($ImageUp, -9);
    if($ImageUp_name = '') {
    print("No file was selected!");
    }
    else {
    $global_db = mysql_connect('localhost', 'Username', 'Password');
    mysql_select_db('DBName', $global_db) or die("Connection error");
    $query = "INSERT INTO Filetable (File) VALUES ('$newfile$type')";
    $result = mysql_query($query) or die("ERROR");
    move_uploaded_file($ImageUp, "/full/path/to/upload/dir/$newfile$type");
    }

hope that helps a little more

[D-ToX]

btw i am new to this as well. but doing sorta the same thing.