Need help with file upload!

Discord

Hi i'm trying to write a script that will allow users to upload images into a specific dirrectory (/var/www/html/images/Profile/) However everytime i try to run my script i am unable to get it to work. I'm fairly certain this is a server setup issue and not code but here is my script anyway.

<?

if ($_FILES[img1] != "") {
	@copy($_FILES[img1][tmp_name], "var/www/html".$FILES[img1][name]) or die("Couldn't upload the file.");

	} else {
	die("No input file specified!");
}
?>

I have already checked my /ect/php.ini file and
file_uploads = On. The tmp directory is left blank so i'm assuming its using /tmp

Are there any other settings i need to add to allow file uploads?

miky58k

Well, there is one thing I've noticed, you don't have a trailing slash when you provide the copy to location - "var/www/html" (instead of "var/www/html/") unless this is just a typo on the message, you'll end up trying to copy the file to var/www/htmlfilename.jpg which is probably not what you want.

If thats not the problem, could you explain what you mean by "it won't work"? Does it just die when it tries to copy? If thats the case, I notice you are suppressing warnings on that line, what are the warnings telling you?

Discord

Sorry that was just a typo.. I've tried with the / and i get the same result. If i do show messages.. I don't recieve any error messages at all. But the images is not copied into the correct location.

miky58k

In looking at it lastnight, I thought maybe $FILES was a seperate array holding the name you want the file copied too - but just to make sure - in the copy line (with the / added on):

@copy($_FILES[img1][tmp_name], "var/www/html/".$FILES[img1][name]) or die("Couldn't upload the file.");

when you tell it where you want the file copied to - did you mean to put $FILES[img1][name] or $_FILES[img1][name] (underscore after $)? If you didn't mean to, I imagine that $FILES[whatever] will return an empty string. On my machine, I'm pretty sure this would cause an error, because it would try to create a file with the same name as a directory name, but perhaps your set up is different.

Discord

I fixed that but i'm still getting the same problem. No error messages, no files uploading.. Could this be a permissions issue that just isn't returning errors?

__greg

<?php
if(isset($HTTP_POST_VARS["submit"])) 
{ 
if ($HTTP_POST_FILES['userfile']['tmp_name'] == "none"){
echo "<center><br><br><br>You must enter an image</center>";
exit();
}

$target = "images/"; 
if (is_dir($target) AND is_writable($target)) 
{
   $filename = $HTTP_POST_FILES['userfile']['name'];

copy($HTTP_POST_FILES['userfile']['tmp_name'], "$target/$filename"); 
echo "$filename has been received.";
 echo "<form action='addreview.php' method='post'>
<input type='hidden' name='rev_cover' value=".$filename.">
<input name='proceed' type='submit' value='Proceed'>
</form>";
exit();
}
else
echo $target_dir. ': either invalid or write permission denied';
} 

 ?>

obviously you need to change it to work with your site, but play around with it. it works for me, the only place you might run into a problem is with unique filenames, if two filenames are the same i believe it will overwrite the first one.

here is the html form code to use with it:

<form enctype="multipart/form-data" action="<?PHP $PHP_SELF ?>" method="post">
<input type="hidden" name="MAX_FILE_SIZE" value="500000000">
          <input name="userfile" type="file" size="50">
<br>
<center>
<input name="submit" type="submit" value="Send File"></center>
</form>

also, if you dont want to deal with that, there is a good tutorial at the following link which shows how to store images in a mysql database. i couldnt get it to work, but im still very new to php, but you might be able to. if it works it would be a sweet little feature.
http://www.webdatabasebook.com/upload/index.php