Looping too many times

[micmac]

Hi all,
I can't seem to get this loop working properly.
Here is the script:

<?
$sql = "SELECT * FROM company_categories WHERE company_id='$id'";
    $result = mysql_query($sql);
    $total = mysql_num_rows($result);
    while($row = mysql_fetch_array($result)){
    $comp_cat_id = $row["comp_cat_id"];
    $company_id = $row["company_id"];
	$category_id = $row["category_id"];

$num = 1;
while ($num <= $total){

?>
                          <tr>
                          <td>
                              <input name="comp_cat_id<? echo $num ?>" type="hidden" value="<? echo $comp_cat_id ?>">
                              <input name="company_id<? echo $num ?>" type="hidden" value="<? echo $company_id ?>">
                              <input name="category_id<? echo $num ?>" type="text" size="16" maxlength="16" value="<? echo $category_id ?>">
                           </td>
                        </tr>
<?
$num++;
}
}
?>

It almost works except that the text input field and there values display 4 times (therefore if $total equaled 4 the results overall display 16 times over)
Any ideas how to get it to display the $total amount of times with the corresponding $category_id associated to it?

Cheers,
micmac

[dalecosp]

Sure looks like you coded it that way. You've got two "while" loops, and the second is run ($total) times for each iteration of the first...isn't it?

[micmac]

Thanks for the reply dalecosp....

I've changed the script so as to break the while loop but now, whilst i get the $total text input fields etc. the results returned to the input fields all display the same value (the last value in the DB table)

Here is the revised code:

<?
$sql = "SELECT * FROM company_categories WHERE company_id='$id'";
    $result = mysql_query($sql);
    $total = mysql_num_rows($result);
    while($row = mysql_fetch_array($result)){
    $comp_cat_id = $row["comp_cat_id"];
    $company_id = $row["company_id"];
	$category_id = $row["category_id"];
}
$num = 1;
while ($num <= $total){

?>
                          <tr>
                          <td>
                              <input name="comp_cat_id<? echo $num ?>" type="hidden" value="<? echo $comp_cat_id ?>">
                              <input name="company_id<? echo $num ?>" type="hidden" value="<? echo $company_id ?>">
                              <input name="category_id<? echo $num ?>" type="text" size="16" maxlength="16" value="<? echo $category_id ?>">
                           </td>
                        </tr>
<?
$num++;
}
?>

Any ideas greatly appreciated.

[tomhath]

You have an extra loop and several unneeded variables. Also search for older threads in the forums on how to make the form input fields arrays.

<?
$sql = "SELECT * FROM company_categories WHERE company_id='$id'";
    $result = mysql_query($sql);
    $num = 1;

while($row = mysql_fetch_array($result)){
?>
     <tr>
     <td>
      <input name="comp_cat_id<? echo $num ?>" type="hidden" value="<? echo $row["comp_cat_id"] ?>">
      <input name="company_id<? echo $num ?>" type="hidden" value="<? echo $row["company_id"] ?>">
      <input name="category_id<? echo $num ?>" type="text" size="16" maxlength="16" value="<? echo $row["category_id"] ?>">
     </td>
     </tr>
<?
     $num++;
   }
?>