Why won't this work?

syst3m

I made this login page and it says Parse error on line 34. I can't figure out what is wrong with it. Help!

<?php
print "<?xml version=\"1.0\" encoding=\"utf-8\"?>";
print "<!DOCTYPE html PUBLIC \"-//W3C//DTD XHTML 1.1 Strict//EN\" \"http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd\">";
print "<html xmlns=\"http://www.w3.org/1999/xhtml\" lang=\"en-US\" xml:lang=\"en-US\">";
print " <head>";
print "  <title>syst3m1337 :: Login</title>";
print "  <meta http-equiv=\"Content-Type\" content=\"text/html; charset=utf-8\" />";
print "  <link rel=\"stylesheet\" type=\"text/css\" href=\"main.css\" />";
print " </head>";
print " <body>";
print "  <form action=\"login.php\" method=\"POST\">";
print "   <div align=\"center\">";
print "    <span class=\"label\">Username</span><input type=\"text\" name=\"username\" />";
print "    <br />";
print "    <span class=\"label\">Password</span><input type=\"password\" name=\"password\" />";
print "    <div align=\"center\">";
print "     <input class=\"button\" type=\"submit\" value=\"Login\" /><input class=\"button\" type=\"reset\" value=\"Clear\" />";
print "    </div>";
print "   </div>";
print "  </form>";
print "  <p>";
function login($username, $password) {
 $users = array ("user1","user2","user3");
 $pwds = array ("pass1","pass2","pass3");
 $page = "private/index.php";
 $TF = "F";
 if (($username == "") || ($password == "")) {
  $TF = "I";
 }
 while ($a < 3) {
  if ((($username != "") && ($username != $users[a])) || (($password != "") && ($password != $pwds[a]))) {
   $TF = "W";
  }
  if ((&username == $users[a]) && ($password == $pwds[a])) {
   $TF = "C";
  }
  $a++;
 }
 if ($TF == "I") {
  print "  You must enter a username and password.";
 }
 elseif ($TF == "W") {
  print "  Invalid Login. Either the username or password you entered is incorrect.";
  print "  <br />";
  print "  Please try again.";
 }
 elseif ($TF == "C") {
  header("location:$page");
 }
 else {
  print "  ERROR. Please <a href=\"contact.php\">contact the webmaster</a>.";
 }
}
print "  </p>";
print " </body>";
print "</html>";
login($username, $password);
?>

rrijnders

if ((&username == $users[a]) ???

syst3m

I fixed it. I had &username instead of $username. Now I have a new problem. After they login, they don't go to the new page.

<?php
print "<?xml version=\"1.0\" encoding=\"utf-8\"?>";
print "<!DOCTYPE html PUBLIC \"-//W3C//DTD XHTML 1.1 Strict//EN\" \"http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd\">";
print "<html xmlns=\"http://www.w3.org/1999/xhtml\" lang=\"en-US\" xml:lang=\"en-US\">";
print " <head>";
print "  <title>syst3m1337 :: Login</title>";
print "  <meta http-equiv=\"Content-Type\" content=\"text/html; charset=utf-8\" />";
print "  <link rel=\"stylesheet\" type=\"text/css\" href=\"main.css\" />";
print " </head>";
print " <body>";
print "  <br />";
print "  <form action=\"login.php\" method=\"POST\">";
print "   <div align=\"center\">";
print "    <span class=\"label\">Username</span><input type=\"text\" name=\"username\" />";
print "    <br />";
print "    <span class=\"label\">Password</span><input type=\"password\" name=\"password\" />";
print "    <div align=\"center\">";
print "     <input class=\"button\" type=\"submit\" value=\"Login\" /><input class=\"button\" type=\"reset\" value=\"Clear\" />";
print "    </div>";
print "   </div>";
print "  </form>";
print "  <p>";
function login($username, $password) {
 $page = "private/index.php";
 $TF = "F";
 if ((($username != "") && ($username != "username")) || (($password != "") && ($password != "password"))) {
  $TF = "W";
 }
 if (($username == "") || ($password == "")) {
  $TF = "I";
 }
 elseif (($username == "username") && ($password == "password")) {
  $TF = "C";
 }
 if ($TF == "F") {
  print "  Login...";
 }
 elseif ($TF == "I") {
  print "  You must enter a username and password.";
 }
 elseif ($TF == "W") {
  print "  Invalid Login. Either the username or password you entered is incorrect.";
  print "  <br />";
  print "  Please try again.";
 }
 elseif ($TF == "C") {
  header("location:$page");
 }
 else {
  print "  ERROR. Please <a href=\"contact.php\">contact the webmaster</a>.";
 }
}
print "  </p>";
print " </body>";
print "</html>";
login($username, $password);
?>

Does header("location:$page"); need to be before EVERYTHING else or just before HTML code?

syst3m

Originally posted by rrijnders
if ((&username == $users[a]) ???

Thanks, but I just found that a few seconds ago, lol!

NSH

elseif ($TF == "C") {
header("location:$page");

the header redirect has to be executed before any html code is displayed..
therefore your form (and other html) is causing a problem ... i am suprised you aren't getting header errors....

jpmoriarty

can i also make a suggestion? if you're not using php for a while, why not break out of your php codes? ie change your script to:

<?xml version=\"1.0\" encoding=\"utf-8\"?>
<!DOCTYPE html PUBLIC \"-//W3C//DTD XHTML 1.1 Strict//EN\" \"http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd\">
<html xmlns=\"http://www.w3.org/1999/xhtml\" lang=\"en-US\" xml:lang=\"en-US\">
<head>
<title>syst3m1337 :: Login</title>
<meta http-equiv=\"Content-Type\" content=\"text/html; charset=utf-8\" />
<link rel=\"stylesheet\" type=\"text/css\" href=\"main.css\" />
</head>
<body>
<br />
<form action=\"login.php\" method=\"POST\">
<div align=\"center\">
<span class=\"label\">Username</span><input type=\"text\" name=\"username\" />
<br />
<span class=\"label\">Password</span><input type=\"password\" name=\"password\" />
<div align=\"center\">
<input class=\"button\" type=\"submit\" value=\"Login\" /><input class=\"button\" type=\"reset\" value=\"Clear\" />
</div>
</div>
</form>
<p>
<?php
function login($username, $password) {
 $page = "private/index.php";
 $TF = "F";
 if ((($username != "") && ($username != "username")) || (($password != "") && ($password != "password"))) {
  $TF = "W";
 }
 if (($username == "") || ($password == "")) {
  $TF = "I";
 }
 elseif (($username == "username") && ($password == "password")) {
  $TF = "C";
 }
 if ($TF == "F") {
  print "  Login...";
 }
 elseif ($TF == "I") {
  print "  You must enter a username and password.";
 }
 elseif ($TF == "W") {
  print "  Invalid Login. Either the username or password you entered is incorrect.";
  print "  <br />";
  print "  Please try again.";
 }
 elseif ($TF == "C") {
  header("location:$page");
 }
 else {
  print "  ERROR. Please <a href=\"contact.php\">contact the webmaster</a>.";
 }
}
print "  </p>";
print " </body>";
print "</html>";
login($username, $password);
?>

and you can then get rid of all the \" 's and change them to just " 's too - but i couldnt be arsed to do it!

NSH

Easy way to do it is copy the code in notepad, do a search for:

replace with

Hit replace all, bingo your done... very handy for multiple things other than quotes.....
just an fyi for anyone who never uses it...

syst3m

Ok. I understand my header problem. I will have to fix it. Thanks for all your help!