Browser Based Redirect

sparticus

Hey, I've been trying to get a browser based redirect working for a new site I'm designing. Basically I'm trying to point older browsers to a different skin of my site. I've found some code that should do this, but it comes with no instructions as to how to use it. Having tried it in various different ways I keep on turning up errors on one line. The Code is...

<?php 
// Redirect to:__(must have trailing slash) 
$redirect_uri = "http://www.iamsparticus.co.uk/"; 
// Page extension: (.htm .html .php .shtml etc) 
$extension = ".php"; 
// start: 
if ($name = strstr ($HTTP_USER_AGENT, "OPERA")) { 
____$browser = "opera";  //this is the line it throws out as an error
________} 
elseif ($name = strstr ($HTTP_USER_AGENT, "MSIE")) { 
____$browser = "ie"; 
________} 
elseif ($name = strstr ($HTTP_USER_AGENT, "WebTV")) { 
____$browser = "webtv"; 
________} 
elseif ($name = strstr ($HTTP_USER_AGENT, "Mozilla/4")) { 
____$browser = "nn4"; 
________} 
elseif ($name = strstr ($HTTP_USER_AGENT, "Mozilla/5")) { 
____$browser = "nn6"; 
________} 
elseif ($name = strstr ($HTTP_USER_AGENT, "Lynx")) { 
____$browser = "lynx"; 
________} 
elseif ($name = strstr ($HTTP_USER_AGENT, "w3m")) { 
____$browser = "w3m"; 
________} 
else { $browser = "unknown"; 
________} 
________ 
// redirect location 
Header ("Location: $redirect_uri"."$browser"."$extension"); 
?>

If I alter the order of the browsers it still always throws out the first "$browser" part of the code.
Anyone know why this happens, or perhaps can redirect me to a better browser redirect script?

coditoergosum

What exactly does the error say? What line is it throwing the error on? Are all of those underscores (_) in your code too?

Not sure where $name comes from either. Is it used somewhere else in the script? It would be simpler to just say if (strstr ($HTTP_USER_AGENT, "OPERA"))

Also, I'd build the redirect string you're using in the header function before actually calling the function.

sparticus

the error comes on line 8, and it reads
Parse error: parse error in /path/to/web/redirect.php on line 8
I'm not sure why all those underscores are there, I just copied and pasted from the code I was using which doesn't have them

coditoergosum

Hmm... what text editor are you using? It almost looks like it might be adding those underscores, and causing the error. I don't see anything wrong with your code... other than the underscores. It looks like it might be replacing tabs with those underscores.

I also just noticed that your if statements aren't going to work... the first if is always going to be true... $name is going to equal the results of the strstr because you're setting them equal right in the if statement. If you're doing comparison in an if statement you need to use 2 equal signs, like this:


if ($foo == "bar") {
// do stuff here
}

// here is what your if statment should look like
if (strstr ($HTTP_USER_AGENT, "OPERA")) {
$browser = "opera"; 
}

coditoergosum

sigh

Mods? Hello? Ban this guy already.

sparticus

Sorry, been away from my computer and not had a chance to get it working, I'll give it all a test tomorrow and see how it runs.
Thanks