Executed queries

[kriek]

I may be overlooking something very basic, but how could I display the number of MySQL queries that were executed on a given page?

Example: 8 MySQL queries executed

[nnichols]

Just run a simple counter - so every time you run a query increment the counter by 1. I assume this is because you have a loop which executes a varying number of queries.

In your loops just have -
$res = mysql_query('blah');
$num_queries++;

[kriek]

Thanks, that method worked, however I have a slight problem trying to output the stats correctly. I am using this function mysql_query_inccounter instead of mysql_query(). I then echo $querycount which contains the number of queries I made.

<?php
    $querycount = "0";
    function mysql_query_inccounter($query) {
        global $querycount;
        $querycount++;
        return mysql_query($query);
    }
?>

I soon found out that anything below the number 1 will echo a blank instead of the number zero, so I tried to receive and fetch the data, but I'm not sure why this isn't working. It automatically echoes "0 MySQL queries executed" even if there are queries being made.

 
<?php
    if (!($_GET['querycount'])) {
        echo "0 MySQL queries executed.";
    } else {
        echo "$querycount MySQL queries executed.";
    }
?>

I’ve tried a few different methods

 
if ($_GET['querycount'] == "") { 

if (!($_GET['querycount'])) { 

if ($_GET['querycount'] == "0") { 

[nnichols]

Can you post all the code for your script. I have a feeling that there is a much more efficient way of generating the page.

Based on what you have posted it should still echo the zero as you have initialised the var outside of the function.

[kriek]

Querycount.php

 
<?php
    $querycount = "0";
    function mysql_query_inccounter($query) {
        global $querycount;
        $querycount++;
        return mysql_query($query);
    }
?>

This is just one of many scripts on several different pages that I am going
to need to count queries from. Note: these are pages in a template system that
I wrote. So I am echoing $querycount in the main page.

news.php

 
<?php
    include 'Scripts/Querycount.php';
    include 'krieknews-v2/config.php';
    $db = mysql_connect($db_host, $db_user, $db_pass);
    mysql_select_db ($db_name) or die ("Cannot connect to database");
    $query = "SELECT title, news, author, date FROM news ORDER BY id DESC LIMIT 0,4";
    $result = mysql_query_inccounter($query);
    while ($r = mysql_fetch_array($result)) {
        $title = $r["title"];
        $news = $r["news"];
        $author = $r["author"];
        $date = strtotime($r["date"]);
        $date = date("F jS  Y", $date);
        echo "<TABLE class=\"Tab\">
                <TR class=\"TabRow\">
                  <TD class=\"TabData\">
<p><IMG src=\"p/file.gif\" alt=\"\"> <b>$date</b> by <a href=\"/Retro.php?id=20\">$author</a></p>
                  </TD>
                </TR>
              </TABLE>
              <TABLE class=\"Tab\">
                <TR class=\"TabRow\">
                  <TD class=\"TabData\">$news</TD>
                </TR>
              </TABLE>";
    }
    mysql_close($db);
?>

[nnichols]

You should use include_once() instead of include(). In the code where you echo the $querycount in the main page you should use something like this -

if(isset($querycount)) {
   echo $querycount.' MySQL queries executed.';
}
else {
   echo '0 MySQL queries executed.';
}

Hope this helps 😉

[kriek]

Thanks man -- works like a charm.

I definitely need to look into isset and unset. I have been neglecting to use them.