mail form problem

desertdirk

I hope it is ok to post the whole code here? When I try this mail form it does not work. After clicking the send button nothing happens. It is suppose to check for empty feilds then either submit or return with error message.

<HTML>
<HEAD>
<TITLE>All-In-One Feedback Form</TITLE>
</HEAD>
<BODY>

<?
$form_block ="
<FORM METHOD=\"POST\" ACTION=\"$_SERVER[PHP_SELF]\">

<P><strong>Your E-Mail Address:</strong><br>
<INPUT type=\"text\" NAME=\"sender_email\" VALUE=\"$_POST[sender_email]\" SIZE=30></P>

<P><strong>Message:</strong><br>
<TEXTAREA NAME=\"message\" COLS=30 ROWS=5 WRAP=virtual>$_POST[message]</TEXTAREA></P>

<P><INPUT TYPE=\"submit\" NAME=\"submit\" VALUE=\"Send This Form\"></p>
</FORM>";

if ($_POST[op] != "ds") {

//they need to see the form
echo "$form_block";

} else if ($_POST[op] == "ds") {

//check value of $_POST[sender_name]
if ($_POST[sender_name] == "") {
	$name_err ="<font color=red>Please enter your name!</font><br>";
	$send ="no";
}

//check value of $_POST[sender_email]
if ($_POST[sender_email] == "") {
	$email_err ="<font color=red>Please enter your e-mail address!</font><br>";
	$send ="no";
}

//check value of $_POST[message]
if ($_POST[message] == "") {
	$message_err ="<font color=red>Please enter a message!</font><br>";
	$send ="no";
}

if ($send != "no"){
	//it's ok to send,so build the mail
	$msg ="E-MAIL SENT FROM WWW SITE \n";
	$msg .="Sender's Name:$_POST[sender_name]\n";
	$msg .="Sender's E-Mail:$_POST[sender_email]\n";
	$msg .="Message:$_POST[message]\n \n";

	$to ="you@youraddress.com";
	$subject ="All-in-One Web Site Feedback";
	$mailheaders ="From:Town Web Site <>\n";
	$mailheaders .="Reply-To:$_POST[sender_email]\n\n";

	//send the mail
	mail($to,$subject,$msg,$mailheaders);

	//display confirmation to user
	echo "<P>Mail has been sent!</p>";

} else if ($send =="no"){
	//print error messages
	echo "$name_err";
	echo "$email_err";
	echo "$message_err";
	echo "$form_block";
}

}
?>
</body>
</html>

marque

I hope it is ok to post the whole code here?

Not usually but in this case, i think i needed to look through the whole code to see whats going on.

<INPUT type=\"hidden\" name=\"op\" value=\"ds \">

should be

<INPUT type=\"hidden\" name=\"op\" value=\"ds\">

notice the space? That gets sent though too so there for

$_POST[op] doesn't equal "ds" it equals "ds "

desertdirk

thank you very much
was this a glaring mistake you picked up. or are there debugging utilities that one uses for this sort of thing?

marque

Nope, for debuging this sort of thing i don't think there are, cause technically there is nothing wrong with the code.

There are ways which you can make foolproof code, such as automatically removing white spaces from a value. But most likely it will take you a long time to code, and be a complete waste of time.

If something doesn't work, but doesn't give you any errors, it's most likely a spelling mistake or whilespace somewhere.

desertdirk

ok thanks
like the man said . . . "the joys of coding"
dd