Login problems!

richardbotw

OK I've been going over this one all day yet still cant understand why my login won't work 🙁. For your information my database name is pooleflights and the username and passwords (which are beign verified) are in a table called Member in the username and password fields...

I've got the logon page....

<HTML>
<HEAD>

<script type="text/javascript">
function validate()
{
x=document.login
user=x.username.value
submitOK="True"
if (!user)
 {
 alert("You must enter a username")
 submitOK="False"
 }
if (submitOK=="False")
 {
 return false
 }
}
</script>

</HEAD>

<BODY>
Please enter your login details
<FORM NAME="login" ACTION="passwordverify.php" METHOD="post" onsubmit="return validate()">
<TABLE BORDER=0>
<TR><TD>Username: </TD><TD> <input type="text" name="username" size=18></TD></TR>
<TR><TD>Password: </TD><TD> <input type="password" name="password" size=18></TD></TR>
<TR><TD COLSPAN="2"><CENTER><input type="reset" name="clear"> <input type="submit" value="Login" name="submit"></TD></TR>
</TABLE>
</form></center>

</BODY>
</HTML>

The PasswordVerify file....

<HTML>
<HEAD>
<LINK REL=stylesheet TYPE="text/css" HREF="main.css">
</HEAD>

<BODY>
<?php
	include "common_db.inc";
	$linkid = db_connect();

$query = ("SELECT * FROM Member WHERE userid = '$_POST[username]'");
$result = mysql_query($query);
$row = mysql_fetch_array($result);
If ($row["password"] !== $_POST[password])
{
	echo ("Incorrect Login. Please try <A HREF=logon.html>again</A>");
}
Else
{
	echo ("Welcome $row[username], please <A HREF=main.html>proceed</A> to the main menu");
}
?>

</BODY>
</HTML>

And the common_db.inc file...

<?php
$mySQLHost = "www.sandj.34sp.com";
$mySQLUsername = "sandj";
$mySQLPassword = "cheesetits";
$mySQLDatabaseName = "pooleflights";


function db_connect()
{
$connection = mysql_connect($mySQLHost, $mySQLUsername, $mySQLPassword)
or die("Could not connect to MySQL");
$db = mysql_select_db($mySQLDatabaseName, $connection) 
or die("Could not select database");
}

?>

Can anyone help?? This is doing my head in, cheers Rich, Southport.

nnichols

I haven't read through all your code but straight away spotted the following problem - the
variables were out of scope so they have to be declared as globals or moved inside the function -

<?php

function db_connect() {

$mySQLHost = 'www.sandj.34sp.com';
$mySQLUsername = 'sandj';
$mySQLPassword = 'cheesetits';
$mySQLDatabaseName = 'pooleflights';

$connection = mysql_connect($mySQLHost, $mySQLUsername, $mySQLPassword)
or die("Could not connect to MySQL");
$db = mysql_select_db($mySQLDatabaseName, $connection) 
or die("Could not select database");

// you need to return the link identifier
return $connection;
}

?>

richardbotw

Yep one of my PHP mates told me to do that which has now been done, however the login still seems to not work with the following lovely error greeting me...

Warning: Supplied argument is not a valid MySQL result resource in /usr/local/psa/home/vhosts/sandj.34sp.com/httpdocs/sandj/passwordverify.php on line 13

Incorrect Login. Please try again

Password verfiy file is as follows...

<HTML>
<HEAD>
<LINK REL=stylesheet TYPE="text/css" HREF="main.css">
</HEAD>

<BODY>
<?php
	include "common_db.inc";
	$linkid = db_connect();

$query = ("SELECT * FROM Member WHERE userid = '$_POST[username]'");
$result = mysql_query($query);
$row = mysql_fetch_array($result);
If ($row["password"] !== $_POST[password])
{
	echo ("Incorrect Login. Please try <A HREF=logon.html>again</A>");
}
Else
{
	echo ("Welcome $row[username], please <A HREF=main.html>proceed</A> to the main menu");
}
?>

</BODY>
</HTML>

Any ideas? Seems to be this line:
$result = mysql_query($query); ??

nnichols

Give this a try -

<HTML>
<HEAD>
<LINK REL=stylesheet TYPE="text/css" HREF="main.css">
</HEAD>

<BODY>
<?php

include "common_db.inc";
$linkid = db_connect();

$query = "SELECT * FROM Member WHERE userid = '$_POST['username']'";
$result = mysql_query($query)
	or die('MySQL error: '.mysql_error().'<br>Query: '.$query);
$row = mysql_fetch_array($result);

If ($row["password"] !== $_POST[password]) {
	echo ("Incorrect Login. Please try <A HREF=logon.html>again</A>");
	}
Else {
	echo ("Welcome $row[username], please <A HREF=main.html>proceed</A> to the main menu");
	}

?>

</BODY>
</HTML>

You should check the name of the field in the query. Earlier you referred to "username" not "userid"