can anyone help?

[crazyrick]

For some reason the following script isn't working, it keeps on telling me "Failed to update!"

<?php

mysql_connect("localhost","root","");
mysql_select_db("tcw");

$values = mysql_query("SELECT * FROM trade WHERE id>0");
while($row = mysql_fetch_array($values))
{
	$id = $row[id];
	$min = $row[min];
	$max = $row[max];

$inner = mt_rand($min,$max);
$mid = mt_rand($min,$max);
$outer = mt_rand($min,$max);

$sql = "UPDATE trade SET inner = '$inner' AND mid = '$mid' AND outer = '$outer' WHERE id = '$id'";
$result = mysql_query($sql) or die("Failed to update!");
}

?>

[stolzyboy]

instead of this

$result = mysql_query($sql) or die("Failed to update!");

put this

$result = mysql_query($sql) or die(mysql_error());

this will give you a more clear error of why it isn't working, also try echoing out your $sql to see if the variables are actually carrying what you think they are

[crazyrick]

Query: UPDATE trade SET inner = '3' AND mid = '3' AND outer = '2' WHERE id = '1'
You have an error in your SQL syntax near 'inner = '3' AND mid = '3' AND outer = '2' WHERE id = '1'' at line 1

[nnichols]

Should be -

UPDATE trade SET inner = '3', mid = '3', outer = '2' WHERE id = '1'

[stolzyboy]

i just noticed that the fields you have in your database are mysql reserved words, if you go to

http://www.mysql.com/doc/en/Reserved_words.html

you will see all three in there, simply change them to something else and you should have no more problems

[crazyrick]

thanks, it works now 🙂