problem with global $_GET

[cantina]

My problem is that on my development machine my code works fine but on my hosts server i get a bunch of errors. I found that this is because my admin has register globals set to off. my question is how do I get around this problem(i.e. how to re-write the code). What I'm trying to do is test to see if there are any variables I need in the url and if there are set the corresponding variables in the page but if there are no variables in the url set the variables in the page to a default.

My page is at http://cybercantina.net/index.php -> for errors
and http://cybercantina.net/index.php?goto=main&template=x&style=x -> for what is supposed to happen.

the code i'm using is:
/*
if(!$_GET['goto'] ) {
header("Location: http://www.cybercantina.net/index.php?goto=main&syle=x&template=x");
}else{
$what_body = "main.php";
$what_template = "default_html.php";
$what_style = "cantinaGlobal.css";

if("$_GET[goto] == 'main' " || "$_GET[goto] == 'x' ") {
	$what_body = "main.php";
}else{
	$what_body = $_GET[goto];
	$what_body .= ".php";
}
if(!"$_GET[style]" || "$_GET[style] =='x' ") {
	$what_style = "cantinaGloabl.css";
}else{
	$what_style = $_GET[style];
	$what_style .= ".php";
}
if(!"$_GET[template]" || "$_GET[template] == 'x' ") {
	$what_template = "default_html.php";
}else{
	$what_template = $_GET[template];
	$what_template .= ".php";
}

}
*/
but without the comments
thank you in advance for your help. if there are any further questions please e-mail me at [e-mail].

[mogster]

Hi!

Take a look at your quotes, most likely the problem lies there. You should find a method that suits you, then stick to it. My suggestion would be to use "string" for strings and 'var' for values inside the brackets. A good point would also be to define the 'goto' at start of script.

Here's a rewrite:

## Define the var $goto and $style/$template ##
$goto = $_GET['goto'];
$style = $_GET['style'];
$tmplte = $_GET['template'];
## Start the check ##
if(!$goto) { 
header("Location: [url]http://www.cybercantina.net/index.p...le=x&template=x[/url]"); 
}else{ 
$what_body = "main.php"; 
$what_template = "default_html.php"; 
$what_style = "cantinaGlobal.css"; 

if($goto == "main"  || $goto == "x") { 
$what_body = "main.php"; 
}else{ 
$what_body = $goto; 
$what_body .= ".php"; 
} 
## You may want to look closer at the if-elses below - they're strange ##
if(!$style || $style =="x" ) { 
$what_style = "cantinaGloabl.css"; 
}else{ 
$what_style = $style; 
$what_style .= ".php"; 
} 
if(!$tmplte || $tmplte  == "x") { 
$what_template = "default_html.php"; 
}else{ 
$what_template = $tmplte ; 
$what_template .= ".php"; 
} 
} 

This is OK, and will check wether the goto is main OR x - both will return true in this case:
if($goto == "main" || $goto == "x") {

but this is strange:

if(!$style || $style =="x" ) {

What it does is first to ask wether the $style is set (and if it is - return false), then ask for a condition for $style.
Just do the last, I think:

if($style =="x" ) {

knutm

[superwormy]

foreach ($_GET as $key => $value) {

if ($value) {
$key = $value;
} else {
$key = "";
}

}

Something like that?

[cantina]

mogster:

The goofy if statements are to check $style out if it doesn't have a value or if the value is "x" then the condition is true causing it to set the variable $what_style/template to the default but i thank you for your input, it still doesn't work however because the register_globas is turned off on my host's servers and he is runnings IIS not apache so .htaccess doesn't work either.

superwormy:

could you please help me out with you code?
are the $key and $value special variables like $GET or could they be anything else. Does this create and array that I could access by using something like $GET['goto'] or would i have to use $key['goto']?

[theeper]

Depending on the version of PHP your host is running, you may need to access the POST and GET variables like this.

$HTTP_GET_VARS['goto']

or

$HTTP_POST_VARS['goto']

[cantina]

no, the server is running 4.x so it wants the $_GET[] variable but my admin has the register_globals is turned off and I can't find how to rewrite the code to work around this. It's supposed to make for better more secure coding if I could figure it out 😃