update problem

derksj

can someone tell me why my code doesnt update the data in my form

<body bgcolor="#FFFFe6">
<form method="post" action="update.php">
<?

define("SQL_HOST", "intranet.hr.nl");
define("SQL_USER", "login");
define("SQL_PWD", "password");
define("SQL_DB", "itcoordinatoren");

$db = mysql_connect(SQL_HOST,SQL_USER,SQL_PWD) or die("Unable to connect to database");
mysql_select_db (SQL_DB,$db);

$result = mysql_query("SELECT

tbldivisie.divisie,
tblcoordinatoren.naam,
tblcoordinatoren.ID,
tblcoordinatoren.afdeling,
tblcoordinatoren.telefoon
FROM tblcoordinatoren
INNER JOIN tbldivisie ON (tblcoordinatoren.divisieID = tbldivisie.divisieID) Order by divisie");
while ($myrow = mysql_fetch_array($result))

{
echo "<table border=\"1\" width=\"100%\"><tr><td width=\"25%\" align=\"left\">\n";
echo "<input type=\"text\" name=\"naam\" VALUE=\"".$myrow[naam]."\" size=\"25\"></td>\n";

echo "</td>\n";
echo "</tr>\n";
echo "</table>";

echo "<td><a href=\"update.php?ID=".$myrow["ID"]."\">Update</a>";

};
?>

update.php

<?
define("SQL_HOST", "intranet.hr.nl");
define("SQL_USER", "login");
define("SQL_PWD", "password");
define("SQL_DB", "itcoordinatoren");
$db = mysql_connect(SQL_HOST,SQL_USER,SQL_PWD) or die("Unable to connect to database");
mysql_select_db (SQL_DB,$db);

$sql = "UPDATE tblcoordinatoren
SET naam='$naam' WHERE ID = $ID";
$result = mysql_Query($sql);
?>

xblue

it will definitely fail in case register globals is off. use $_POST['naam'] instead of $naam then, same for id.

also you should change this:

$result = mysql_Query($sql);

$result = mysql_Query($sql) or die('Error: '.mysql_error().' in query: '.$sql);

if you'd like to know what is going wrong.

and please make use of the [php] tags when posting code, it is so much easier to read.

derksj

you mean someting like this


<?

define("SQL_HOST", "intranet.hr.nl");		// Naam of IP van MySQL server
define("SQL_USER", "");			// MySQL gebruikersnaam
define("SQL_PWD", "");		  	// MySQL password
define("SQL_DB", "itcoordinatoren");		// Naam van de database
$db = mysql_connect(SQL_HOST,SQL_USER,SQL_PWD) or die("Unable to connect to database");
mysql_select_db (SQL_DB,$db);


$sql = "UPDATE tblcoordinatoren SET naam='$_POST['naam']'  WHERE ID = $_POST['ID']";
$result = mysql_Query($sql) or die('Error: '.mysql_error().' in query: '.$sql);


?>

xblue

I'd rather do it this way to avoid confusion with the single quotes:

$sql = "UPDATE tblcoordinatoren SET naam='".$_POST['naam']."'  WHERE ID = ".$_POST['ID'];

derksj

i get this error

Error: You have an error in your SQL syntax near '' at line 1 in query: UPDATE tblcoordinatoren SET naam='' WHERE ID =

xblue

well, obviously the variables are not passed properly.

btw, I don't see a submit button or an ending form tag, are you just clicking on that update link and it fails?

this wouldn't be too surprising then, because the link doesn't pass the name, only the id, and this via GET not POST.