File Import

[bjblackmore]

Hi,
Can anyone see anything wrong with the following code? I have a txt file called import.txt that just has data in the form of..

testdata1,testdata2,testdata3

I've only got a few fields, so its not a huge file. When I run the code, the browser just sits there spinning, then times out.

function importfile(){
@$fp = fopen("$DOCUMENT_ROOT.'/import/import.txt'", "r");
if (!$fp) {
echo "There are currently no properties.";
exit;
} while (!feof($fp)) {
$property = fgetcsv($fp, 100, ",");
}
for ($i=0; $i<$property; $i++) {
echo $property[$i]."<br>";
}
}

Anyone see anything wrong?

Cheers

Ben

[altexis]

well... first of all I would write this
@$fp = fopen("$DOCUMENT_ROOT.'/import/import.txt'", "r");
like that:
$fp = @fopen("$DOCUMENT_ROOT.'/import/import.txt'", "r");

then I would use the count function for this for loop:
for ($i=0; $i<$property; $i++)
to
for ($i=0; $i<count($property); $i++)

also the while loop iterates and doesn't produce results
so I would rewrite it to:

while (!feof($fp)) {
$property = fgetcsv($fp, 100, ",");
for ($i=0; $i<$property; $i++) {
echo $property[$i]."<br>";
}
}

[bjblackmore]

Great Thanks! I'll give it a try! Was weird cause when I 1st tried my script it returned 2 lines, then just sat there. Then when I refreshed it didn't return anything, just timed out!
Cheers
Ben