Problem getting sql function to work

Darkbolt

I'm trying to get a function to work, that will retrieve and display all the entries in a sql table, but I keep getting the following errors in my script

Warning: Supplied argument is not a valid MySQL result resource in /home/sites/site14/users/darkbolt/web/darkbolt/index.php on line 40

Warning: Supplied argument is not a valid MySQL result resource in /home/sites/site14/users/darkbolt/web/darkbolt/index.php on line 47

the funtion is as follows

function displaynews() { 
$limit=20;
$numresults=mysql_query("SELECT * FROM db_news WHERE 1 ORDER by news_time DESC");
$numrows=mysql_num_rows($numresults);
if (empty($offset)) {
    $offset=1;
}
$result=mysql_query("select `news_time` , `cat` , `user` , `title` , `news` ".
    "from db_news".
    "order by news_time DESC limit $offset,$limit");
while ($data=mysql_fetch_array($result)) {
$htimed = date("m.d - Y", $data[news_time]); 
echo "<table border=\"0\"><tr><td>
<center><h4><a href=\"index.php?run_control=show&cat=$data[cat]&news_time=$data[news_time]\">$data[title]</a></h4></td><td>.$htimed.</td></tr>" ; 
echo "<tr><td colspan=\"2\">By: <b>.$data[user].</b></td></tr>"; 
echo "<tr><td colspan=\"2\">$data[news]</td></tr></table>"; 
}
}

line 40 would be

while ($data=mysql_fetch_array($result)) {

Any help you could offer would be much appreciated...TIA 🙂

Mordecai

Originally posted by Darkbolt

$result=mysql_query("select `news_time` , `cat` , `user` , `title` , `news` ".
    "from db_news".
    "order by news_time DESC limit $offset,$limit");

[/B]

Any time you use a period to add two strings together, it adds them without any extra spaces. So, when you have it with no spaces, the query becomes squished together, and is no longer functioning. This is a correct form:

$result=mysql_query("select `news_time` , `cat` , `user` , `title` , `news` ".
    " from db_news".
    " order by news_time DESC limit $offset,$limit");

Hope that helps.

Darkbolt

afraid it didnt 🙁

Mordecai

I tried it locally, and I think that's all I changed. I'll try again and see.

Results:
All I had to change was the spaces. I used this query as the table:
create table db_news (news_time INT, cat text, user text, title text, news text)

Darkbolt

I'm afraid it still doesnt work... This is how I have my table set up

CREATE TABLE db_news (
news_id int(10) unsigned zerofill NOT NULL auto_increment
news_time int(20) NOT NULL default '0',
cat varchar(150) NOT NULL default '0',
user varchar(150) NOT NULL default '0',
title varchar(150) NOT NULL default '0',
news text,
PRIMARY KEY (news_id)
) TYPE=MyISAM;

The problem I think is somewhere in the sql query....:-/

edit-I've just added the 'news_id' table, and altered the function accordingly...

function displaynews() { 
$limit=20;
$numresults=mysql_query("SELECT * FROM db_news WHERE 1 ORDER by news_time DESC");
$numrows=mysql_num_rows($numresults);
if (empty($offset)) {
    $offset=1;
}
$result=mysql_query("select 'news_id' `news_time` , `cat` , `user` , `title` , `news` ".
    "from db_news".
    "order by news_time DESC limit $offset, $limit");
while ($data=mysql_fetch_array($result)) {
$htimed = date("m.d - Y", $data[news_time]); 
echo "<table border=\"0\"><tr><td>
<center><h4><a href=\"index.php?run_control=show&cat=$data[cat]&news_time=$data[news_id]\">$data[title]</a></h4></td><td>.$htimed.</td></tr>" ; 
echo "<tr><td colspan=\"2\">By: <b>.$data[user].</b></td></tr>"; 
echo "<tr><td colspan=\"2\">$data[news]</td></tr></table>"; 
}
}

trooper

Its not the answer but it will help you a lot in working out what is wrong

mysql_query("SELECT * FROM db_news WHERE 1 ORDER by news_time DESC") or die (mysql_error());

and also on the next query

Why are you splitting the 2nd sql query up by using ". "?

that will give you a more helpful error message

HTH

Darkbolt

hey, thx alot, the problem was with my included db connection file, so its working just fine now(and i feel like an idiot lol!)🙂