Form Validation | Preview | Edit | Then Submit

LiquidCD

Greetings everyone,

Well, with the help of some tutorials I have been able to get my membership sign up page working. The form will input the data into the database, there is some simple error checking that I have that works okay, but I had a question regarding preview and editing and would like to do the following:

1) Form page: When the user clicks on the submit button, I would like it to go to a "Preview" so they can check their submitted information.
a) If all information is correct: Click "Submit"
b) If some of the information is wrong: Click "Edit"

Then once entered form data is correct, they can then submit into the database. Cannot seem to find anything clear on how to do this.

2) Register.php: This page does all the checking and if any fields are left blank, it will report the error and take them back to the page. PROBLEM: I am using radio buttons since they can only select one type of option. However, if an error is returned, the previously selected radio button is not retained. How do I fix this?

3) Mail function in register.php: I send two emails: One to the submitter and one to our member coordinator. In order to clean up the code, can I simply move the message information (using the same format and variable calls) into include or a txt file to be called?

Thanks!

Here is the code taken from tutorials. If anyone has suggestions for cleaning up the code, please let me know. I followed this pattern since it made the most sense to me and that I could get to work:

Membership Form:

<form name="form1" method="post" action="register.php">
  <table width="100%" border="0" cellpadding="4" cellspacing="0">
    <tr> 
      <td width="24%" align="left" valign="top"><div align="right"><strong>First 
          Name:</strong></div></td>
      <td width="76%"><input name="first_name" type="text" id="first_name" value="<? echo $first_name; ?>"></td>
    </tr>
    <tr> 
      <td align="left" valign="top"><div align="right"><strong>Last Name:</strong></div></td>
      <td><input name="last_name" type="text" id="last_name" value="<? echo $last_name; ?>"></td>
    </tr>
    <tr> 
      <td align="left" valign="top"><div align="right"><strong>Email Address:</strong></div></td>
      <td><input name="mem_email_addr" type="text" id="mem_email_addr" value="<? echo $mem_email_addr; ?>"></td>
    </tr>
    <tr> 
      <td align="left" valign="top"><div align="right"><strong>Alternate Email 
          Address:</strong></div></td>
      <td><input name="mem_alt_email" type="text" id="mem_alt_email" value="<? echo $mem_alt_email; ?>"></td>
    </tr>
    <tr> 
      <td align="left" valign="top"><div align="right"><strong>Street Address:</strong></div></td>
      <td><font face="Times New Roman, Times, serif"> 
        <input name="mem_addr" type="text" id="mem_addr" size="40" maxlength="55" value="<? echo $mem_addr; ?>">
        </font></td>
    </tr>
    <tr> 
      <td align="left" valign="top"><div align="right"><strong>City/Town/Village:</strong></div></td>
      <td><font face="Times New Roman, Times, serif"> 
        <input name="mem_city" type="text" id="mem_city" size="40" maxlength="40" value="<? echo $mem_city; ?>">
        </font></td>
    </tr>
    <tr> 
      <td align="left" valign="top"><div align="right"><strong>State:</strong></div></td>
      <td><font face="Times New Roman, Times, serif"> 
        <input name="mem_state" type="text" id="mem_state" size="15" maxlength="25" value="<? echo $mem_state; ?>">
        </font></td>
    </tr>
    <tr> 
      <td align="left" valign="top"><div align="right"><strong>Zip/Postal Code:</strong></div></td>
      <td><font face="Times New Roman, Times, serif"> 
        <input name="mem_zip" type="text" id="mem_zip" size="15" maxlength="15" value="<? echo $mem_zip; ?>">
        </font></td>
    </tr>
    <tr> 
      <td align="left" valign="top"><div align="right"><strong>Country:</strong></div></td>
      <td><font face="Times New Roman, Times, serif"> 
        <input name="mem_country" type="text" id="mem_country" size="40" maxlength="45" value="<? echo $mem_country; ?>">
        </font></td>
    </tr>
    <tr> 
      <td colspan="2"><font face="Times New Roman, Times, serif"><strong>Choose 
        your type of Membership:</strong></font></td>
    </tr>
    <tr> 
      <td colspan="2" valign="top"> <p> <strong><font face="Times New Roman, Times, serif"> 
          <input name="mem_type" type="radio" id="mem_type" value="<? $mem_type=Individual; ?>">
          Individual Member: </font><font color="#FF0000" face="Times New Roman, Times, serif"> 
          <em>$15 [USA], $18 USD [Canada], $21 USD [Overseas]<br>
          </em></font></strong><font face="Times New Roman, Times, serif">&middot; 
          2 issues of the LGGS newsletter (equivalent to a 1 yr membership), Proteviai<br>
          &middot; Unlimited surname submissions to LGGS website. </font></p></td>
    </tr>
    <tr> 
      <td colspan="2" valign="top"><font face="Times New Roman, Times, serif"><strong><font face="Times New Roman, Times, serif"> 
        <input name="mem_type" type="radio" id="mem_type" value="<? echo $mem_type=Bronze; ?>">
        Bronze Member: </font><font color="#FF0000" face="Times New Roman, Times, serif"> 
        <em>$25 USD<br>
        </em></font></strong><font face="Times New Roman, Times, serif">&middot; 
        Same as Individual Member plus; <br>
        &middot; Support of LGGS mission to assist Lithuanian Nationals with membership, 
        provide copies of newsletter to non-profit entities, and cover expenses. 
        </font></font></td>
    </tr>
    <tr> 
      <td colspan="2" valign="top"><font face="Times New Roman, Times, serif"> 
        <input name="mem_type" type="radio" id="mem_type" value="<? echo $mem_type=Silver; ?>">
        <strong>Silver<font face="Times New Roman, Times, serif"> Member: </font><font color="#FF0000" face="Times New Roman, Times, serif"> 
        <em>$100 USD<br>
        </em></font></strong><font face="Times New Roman, Times, serif">&middot; 
        4 issues of the LGGS newsletter (equivalent to a 2 yr membership) <br>
        &middot; Publication of your name as a Silver Member in Proteviai and 
        on the LGGS website. </font></font></td>
    </tr>
    <tr> 
      <td colspan="2" valign="top"> <div align="left"><font face="Times New Roman, Times, serif"> 
          <input name="mem_type" type="radio" id="mem_type" value="<? echo $mem_type=Gold; ?>">
          <strong>Gold<font face="Times New Roman, Times, serif"> Member: </font><font color="#FF0000" face="Times New Roman, Times, serif"> 
          <em>$300 USD<br>
          </em></font></strong><font face="Times New Roman, Times, serif">&middot; 
          Same as Silver Member plus;<br>
          &middot; Lifetime membership in Lithuanian Global Genealogy Society. 
          </font></font></div></td>
    </tr>
    <tr valign="top"> 
      <td colspan="2"><font face="Times New Roman, Times, serif"> 
        <input name="mem_type" type="radio" id="mem_type" value="<? echo $mem_type=Institutional; ?>">
        <strong>Institutional<font face="Times New Roman, Times, serif"> Member: 
        </font><font color="#FF0000" face="Times New Roman, Times, serif"> <em>$15 
        USD<br>
        </em></font></strong><font face="Times New Roman, Times, serif">&middot; 
        Societies, Family Associations, Libraries, and other non-profit entities.<br>
        &middot; Name of Institution here: 
        <input name="Name_of_Institution" type="text" id="Name_of_Institution" size="50">
        </font></font></td>
    </tr>
    <tr> 
      <td colspan="2" align="left" valign="top"><font face="Times New Roman, Times, serif">All 
        memberships include an annual directory of our members, which include 
        name, email, and address. This will allow members to find others in their 
        area for contact. If you wish to protect your privacy, you may choose 
        to have your address information withheld (select the &quot;No&quot; checkbox 
        on the membership form). In this case, only your name will be listed in 
        the directory.<br>
        <br>
        <em><strong>May we include your mailing address in the membership directory?</strong></em> 
        <input name="mem_directory" type="checkbox" id="mem_directory?" value="<? echo $mem_directory=Yes; ?>">
        Yes 
        <input name="mem_directory" type="checkbox" id="mem_directory?" value="<? echo $mem_directory=No; ?>">
        No</font></td>
    </tr>
    <tr> 
      <td align="left" valign="top">Desired Username</td>
      <td><input name="username" type="text" id="username" value="<? echo $username; ?>"></td>
    </tr>
    <tr> 
      <td align="left" valign="top">Information about you:</td>
      <td><textarea name="memo" id="memo"><? echo $memo; ?></textarea></td>
    </tr>
    <tr> 
      <td align="left" valign="top">&nbsp;</td>
      <td><input type="submit" name="Submit" value="Join Now!"></td>
    </tr>
  </table>
</form>

Thanks! Any tips or pointers would be appreciated.

LiquidCD

Now, Register.php (some sections commented out until I add later):

// Blah, Blah, connection information

// Define post fields into simple variables
$first_name = $_POST['first_name'];
$last_name = $_POST['last_name'];
$mem_email_addr = $_POST['mem_email_addr'];
$mem_alt_email = $_POST['mem_alt_email'];
...
...
...

/* Let's strip some slashes in case the user entered
any escaped characters. */

$first_name = stripslashes($first_name);
$last_name = stripslashes($last_name);
$mem_email_addr = stripslashes($mem_email_addr);
$mem_alt_email = stripslashes($mem_alt_email);
...
...
...

/* Do some error checking on the form posted fields */

if((!$first_name) || (!$last_name) || (!$mem_addr) || (!$mem_city) ||(!$mem_state) ||(!$mem_zip) ||(!$mem_country) ||(!$mem_type) ||(!$mem_directory)){
	echo 'You did not submit the following required information! <BR><BR>';
	if(!$first_name){
		echo "<LI>First Name is a required field. Please enter it below.<BR>";
	}
	if(!$last_name){
		echo "<LI>Last Name is a required field. Please enter it below.<BR>";
	}
...
...
...	include 'join_form.html'; // Show the form again!
	/* End the error checking and if everything is ok, we'll move on to
	 creating the user account */
	exit(); // if the error checking has failed, we'll exit the script!
}

/* Let's do some checking and ensure that the user's email address or username
 does not exist in the database */

 $sql_email_check = mysql_query("SELECT mem_email_addr FROM membership WHERE mem_email_addr='$mem_email_addr'");
/* $sql_username_check = mysql_query("SELECT username FROM users WHERE username='$username'"); */

 $email_check = mysql_num_rows($sql_email_check);
/* $username_check = mysql_num_rows($sql_username_check); */

 if(($email_check > 0)) { /* || ($username_check > 0)){ */
 	echo "Please fix the following errors: <br />";
 	if($email_check > 0){
 		echo "<strong>Your email address has already been used by another member in our database. Please submit a different Email address!<br />";
 		unset($email_address);
 	}
/* 	if($username_check > 0){
 		echo "The username you have selected has already been used by another member in our database. Please choose a different Username!<br />";
 		unset($username);
 	}
*/
 	include 'join_form.html'; // Show the form again!
 	exit();  // exit the script so that we do not create this account!
 }

/* Everything has passed both error checks that we have done.
It's time to create the account! */

/* Random Password generator. */
...
...
...

// Enter info into the Database.
$memo2 = htmlspecialchars($memo);
$sql = mysql_query("INSERT INTO membership (first_name, last_name, mem_email_addr, mem_alt_email, mem_addr, mem_city, mem_state, mem_zip, mem_country, mem_type, mem_directory, username, password, memo, signup_date)
		VALUES('$first_name', '$last_name', '$mem_email_addr', '$mem_alt_email', '$mem_addr', '$mem_city', '$mem_state', '$mem_zip', '$mem_country', '$mem_type', '$mem_directory', '$username', '$db_password', '$memo2', now())") or die (mysql_error());

if(!$sql){
	echo 'There has been an error creating your account. Please contact the webmaster.';
} else {
	$userid = mysql_insert_id();
	// Let's mail the user! (CAN I MOVE THESE INTO SEPARATE INCLUDE FILES?)

$subject = "Your Membership at Lithuanian Global Genealogical Society!";
$message = "
Dear $first_name $last_name,

Thank you for registering at our website, [url]http://www.lithuaniangenealogy.org,[/url]
for your $mem_type membership. Your support will allow us to continue our mission.

Once payment has been received, your membership will be activated and you will be sent a 
second confirmation email from our Membership Coordinator, Diane Rooney.

In the meantime, you may submit the surnames you are researching for inclusion in our 
database by visiting the following link:
[url]http://www.lithuaniangenealogy.org/databases/surnames/surnameform.html[/url]

Once again, thank you for your support!
The Board of Directors
Lithuanian Global Genealogical Society

------------------
(below this line will be activated soon)

You are two steps away from logging in and accessing our exclusive members area (coming soon)!.

To activate your membership, please click here: [url]http://www.lithuaniangenealogy.org/test/Mem_Area/activate.php?id=[/url]$userid&code=$db_password

Once you activate your memebership, you will be able to login with the following information:
Username: $username (coming soon)
Password: $random_password

Thanks!
The Webmaster

This is an automated response, please do not reply!";

$subject2 = "Membership Submission: $first_name $last_name";
$message2 = "
Dear Membership Coordinator,

$first_name $last_name has submitted the following information: 

(The information below has already been inserted into the online datasbase. 
 This will cut out the problem of us having to do it by hand. Neat eh?)

 First name: $first_name
 Last Name: $last_name
 Email: $mem_email_addr
 Alternate Email: $mem_alt_email
 Address: $mem_addr
 City: $mem_city
 State: $mem_state
 Zip: $mem_zip
 Country: $mem_country
 Membership Level: $mem_type
 Include name in the Membership Directory: $mem_directory
 Additional Information: $memo


 This email is automatically generated!";


mail($mem_email_addr, $subject, $message, "From: LGGS Webmaster<webmaster@lithuaniangenealogy.org>\nX-Mailer: PHP/" . phpversion());
mail($coordinator, $subject2, $message2, "From: LGGS Webmaster<webmaster@lithuaniangenealogy.org>\nX-Mailer: PHP/" . phpversion());
echo 'Your membership information has been mailed to your email address! Please check it and follow the directions!';
}

?>

mogster

'Ullo!

There's two ways to do this: javascript or php
You've posted far too much code to even think about editing it 😉, but here's some general examples on both:

Javascript:
Name your form, replace the formname underneath with that name, then add
onClick="doValidate();"
to the submit-button (which is to be set as type="button" - not submit.

<SCRIPT language="JavaScript">
<!--
function doValidate() {
if(document.formname.fieldname.value =="") {
alert(document.formname.fieldname + " is mandatory!");
} else if (document.formname.fieldname2.value =="") {
alert(document.formname.fieldname2 + " is mandatory!");
} else {
document.formname.submit();
}
}
//-->
</SCRIPT>

Php:
Do error check in the reception script:

<?PHP
if (empty($var1)) $error= $error. "<li>The field 'var1' is mandatory";
if (empty($var2)) $error= $error. "<li>The field 'var2' is mandatory";
if(empty($error)) {
$do_the_stuff;
} else {
echo "<ul>".$error."</ul>";
include("reg_form.php");
}
?>

Remember to echo the already submitted values into the form, it isn't considered very polite to erase all typed in data so he must start all over again.

knutm