checkbox array prob

[djkanebo]

I have a form e.g.,

|| 15 Ford Fiesta 10000

etc etc (the square is supposed to be a checkbox!)

There is a button at the end of the form which is 'Delete these cars!'

This calls another script, deleteCarProcess.php which seems to work fine.

In fact, I can delete selected items from the form as long as the form displays only 15 items for some reason. As soon as the form displays 16 or more items, the 'Delete these Cars' button stops functioning and doesn't even look for the script which the action is set to.
Is there some limit on the array size....

<input name=carsToRemove[] ??????

Has anyone else experienced this or know a way to get around it??

Help would be much appreciated as this has been doing my head in for a week now!

Thanx in advance, Djkane!

[tomhath]

Are you submitting the form with GET or POST? There is a limit on the length of a query string for GET.

Otherwise you'll need to post some code.

[djkanebo]

<form action=deleteCarProcess.php>

<div align=center>

  <input type=button value='Back' onClick="javascript:history.back()">
  <input type=button value='Return To Admin Menu' onClick="document.location.href='administratorHome.php'">
  <input type=button value='Logout' onClick="document.location.href='welcome.php?status=logout'">
</div>

<br>

<table class=border align=center width=75% cellspacing=0 cellpadding=5>
<tr><th>Remove A Ford</th></tr>

<tr><td>
<table width=100% cellpadding=3 cellspacing=3 border=0>
<tr>
<td></td>
<td align=left valign=center class="tabletitles">CarID</td>
<td align=left valign=center class="tabletitles">Manufacturer</td>
<td align=left valign=center class="tabletitles">Model</td>
<td align=left valign=center class="tabletitles">Engine Size (l)</td>
<td align=left valign=center class="tabletitles">Num of Doors</td>
<td align=left valign=center class="tabletitles">Bodystyle</td>
<td align=left valign=center class="tabletitles">Price (£)</td>
</tr>

<?php
while ($carInfo=mysql_fetch_array($result)) {

             $carID=$carInfo["carID"];
             $origin=$carInfo["origin"];
             $manufacturer=$carInfo["manufacturer"];
             $model=$carInfo["model"];
             $engineSize=$carInfo["engineSize"];
             $numDoors=$carInfo["numDoors"];
             $bodystyle=$carInfo["bodystyle"];
             $mpg=$carInfo["mpg"];
             $zeroToSixty=$carInfo["zeroToSixty"];
             $maxSpeed=$carInfo["maxSpeed"];
             $insuranceGroup=$carInfo["insuranceGroup"];
             $typicalInsuranceQuote=$carInfo["typicalInsuranceQuote"];
             $airbags=$carInfo["airbags"];
             $alarm=$carInfo["alarm"];
             $aircon=$carInfo["aircon"];
             $typicalContractPrice=$carInfo["typicalContractPrice"];
             $price=$carInfo["price"];


             echo "<tr valign=center> \n" .
	      "    <td align=center><input type=checkbox name=carToRemove[] value='$carID'></td> \n" .
	      "    <td align=left>  \n" .
                  "       $carID</td> \n" .
                  "    <td align=left>  \n" .
                  "       $manufacturer</td> \n" . 
                  "    <td align=left>  \n" .
                  "       $model</td> \n" . 
                  "    <td align=left>  \n" .
                  "       $engineSize</td> \n" . 
                  "    <td align=left>  \n" .
                  "       $numDoors</td> \n" . 
                  "    <td align=left>  \n" .
                  "       $bodystyle</td> \n" .  
                  "    <td align=left> \n" .
                  "       $price</td> \n" .      
                  "        <input type=hidden name=deleteDatabase value=\"yes\"> " .
                  "        <input type=hidden name=theCARID value=\"$carID\"> \n" . 
                  "        <input type=hidden name=theMANUFACTURER value=\"$manufacturer\"> \n" .
                  "        <input type=hidden name=theMODEL value=\"$model\"> \n" .
                  "        <input type=hidden name=theENGINESIZE value=\"$engineSize\"> \n" .
                  "        <input type=hidden name=theNUMDOORS value=\"$numDoors\"> \n" .
                  "        <input type=hidden name=theBODYSTYLE value=\"$bodystyle\"> \n" .
                  "        <input type=hidden name=thePRICE value=\"$price\"> \n" .
	      "</tr>\n\n" ;                 


         }

?>

      </table>
    </td>
</tr>

  <tr><td colspan=8><center><input type=submit name=submit value='Remove These Fords'></center></td></tr>
</table>

</form>

can you help??

[ScubaDvr2]

Holy crap I can't even read that. It's unclean code to write 50,000 lines with 1 echo statement. Break it up.

[djkanebo]

look, can you help or not??

it's simple to read!

[tomhath]

The only bugs that really jump out are the hidden fields (they get rewritten with the same name every time through the "while" loop) and the extra </table> tag inside the loop (the table was started outside the loop).

How about the code for deleteCarProcess.php after cleaning those up?

[djkanebo]

Here is the code for deleteCarProcess.php

(however, note that this works perfectly when the form shows only 15 or less items on it, so could this possibly be the problem?)

here goes anyway

<?php

if($submit)
{
	$db = mysql_connect("localhost", "d99kd", "********");
	mysql_select_db("d99kd",$db);

	if($carToRemove!="")
	{
		echo 	"<html> \n " .
			"  <head> \n " .
			"    <title>Online Car Recommender System - Remove Users</title> \n " .
			"    <META HTTP-EQUIV=\"Pragma\" CONTENT=\"no-cache\"> \n " .
			"    <META HTTP-EQUIV=\"Expires\" CONTENT=\"-1\"> \n " .
			"    <link rel=stylesheet href=style.css> \n " .
			"    <script language=\"javaScript\"> \n " .
			"       function goto(destination) { document.location.href=destination; } " .
			"    </script> \n " .
			"  </head> \n " .
			"  <body><br><BR> \n " .
		 	"    <table class=border align=center cellspacing=0 cellpadding=5> \n ".
			"      <tr><th>Cars Removed</th></tr> \n " .
			"        <tr> \n " .	
			"          <td> \n " .
			"            <table width=100% cellpadding=3 cellspacing=3 border=0> \n " .
			"              <tr> \n " .
			"                <td class=\"tabletitles\">Car ID</td> \n " .
			"                <td class=\"tabletitles\">Manufacturer</td> \n " .
			"                <td class=\"tabletitles\">Model</td> \n " .
			"                <td class=\"tabletitles\">Engine Size</td> \n " .
			"                <td class=\"tabletitles\">Num Doors</td> \n " .
			"                <td class=\"tabletitles\">Bodystyle</td> \n " .
			"                <td class=\"tabletitles\">Price</td> \n " .
			"              </tr> \n ";

		foreach($carToRemove as $thisCarToRemove)
		{
			$dbQuery="DELETE FROM cars WHERE carID='$thisCarToRemove'";
			$result = mysql_query($dbQuery,$db);
			echo  	"      <tr> \n " .
			      	"        <td>$thisCarToRemove</td> \n " .
			    	"        <td>$theMANUFACTURER<BR></td> \n " . 
				"	 <td>$theMODEL</td> \n " .
				"	 <td>$theENGINESIZE</td> \n " .
				"	 <td>$theNUMDOORS</td> \n " .
				"	 <td>$theBODYSTYLE</td> \n " .
				"	 <td>$thePRICE</td> \n " .
				"      </tr>\n ";
		}

		echo 	"            </table> \n " .
		     	"          </td> \n " .
		    	"        </tr> \n " .
		     	"    </table><br><BR> \n " .
		     	"    <center> \n " .
		     	"      <input type=button value=\"Click Here To Return To Admin Functions\" onClick=\"goto('administratorHome.php')\"> \n " .
		     	"    </center> \n";       
	}
}

?>

thanx for yer help so far tomhath ;-)

[tomhath]

I'd comment out these two lines first and make sure it's looping the correct number of times. Also echo out the number of elements in the array before going into the loop (or use print_r to show them all). You need to establish whether you got all sixteen ids passed into the the delete page.

$dbQuery="DELETE FROM cars WHERE carID='$thisCarToRemove'"; 
$result = mysql_query($dbQuery,$db); 

Ignore my comment about the extra </table> tags per the comment I added to my earlier post. I misread the code.

I have to go now. Won't be back for several hours. Good luck.

[djkanebo]

this is officially a cry for help!!!

this bug has been doing my head in for over a week now...

there are a few replies to read through but if anyone has the time and kindness to see if they can solve my problem i would appreciate it enormously!!

surely someone else out there has had this problem b4??
good luck 2 all and thanx ;-)

[djkanebo]

anyone ??????????????????????

[djkanebo]

this prob has now been solved...

thanx to tomhath and those others who tried to help

it was to do with the post method!