Problem with loop, please help!

kamu

hey all

this is my script

		$user = $HTTP_GET_VARS['user'];
		$filesize = filesize("users.txt");
		$file = fopen("users.txt", "r");
		$filedata = fread($file, $filesize);
		while( ! feof($file) or ! $line == $user ) {
			$lenofline = strlen($line);
			$lenoflines = $lenoflines + $lenofline;
			$line = fgets($file, 15);
		}
		$leftdata = fread($file, $lenoflines);
		$templen = $lenoflines + ( strlen($user) + 2 );
		$rightdata = substr($filedata, $templen);
		print $leftdata.$rightdata;

it comes up with this error

Fatal error: Maximum execution time of 30 seconds exceeded in C:\FoxServ\www\chat.php on line 35

line 35 is the while loop, the script trys to find $user in a text file, and prints the others WITH OUT $user, and it doest wanna work, and I dont know why.. please help?

autocolismo

edit your php.ini file and change:

max_execution_time = 30

max_execution_time = 3000

or other value you want.

kamu

it shouldnt need that. it has 7 lines in their.
30 characters, theirs somethingthing wrong with the code, I dont know WHAT!!!! GRR:mad:
but thanx anyway

autocolismo

in your code you might change "or" by "||".

and try using mysql IT ROCKX

you can create free databases in:

http://www.freesql.org

jpmoriarty

it shouldnt need that. it has 7 lines in their.
30 characters

yes but how big is the file? if it's massive then that's what will be making it take so long.

xblue

the problem seems to be here: you are reading the file until its end. then you start your while loop without resetting the file pointer, thus creating an endless loop.

I tested your code, simply adding rewind($file); after $filedata = fread($file, $filesize); solves the problem.

kamu

thanks alot all, and expecialy xblue!

kamu

grrr, the loop works.. but its not grabbing any data! far out

kamu

ok here is the user.txt file:

dog
fred
jim
bob
john

it grabs the $user and looks for it, when it find it, it uses the $lenoflines to grab the left data, and the rest of the filesize to exclude it, and it then prints out the data WITHOUT the $user

it doesnt want to work..

xblue

I don't know how your data is structured, but I'm wondering if you aren't going about this in a fairly complicated way.

a different approach to do what I understand you want:

$user = $HTTP_GET_VARS['user'];
$file_array = file("users.txt");
for ($i=0; $i<count($file_array); $i++) {
    if (trim($file_array[$i]) == $user) {
        unset($file_array[$i]);
    }
}
// don't forget to use nl2br() if you want the browser to display the linebreaks
echo implode('', $file_array);