Problem with an UPDATE form

boboli

Hi all... surely someone will be able to solve my stupid problem...
I have a table name risultati1 (results) with the following fields:
id_match
week
id_c (id of the team playing home)
id_f (id of the team playing away)
g_c (points scored by the home team)
g_f (points scored by the away team)

every week I have 4 matches and I would like to update all the results together without doing it separately...
this is the form I have created with a FIX week for trying purposal (it will become a variable)


<? 
include("dbinfo.inc.php" );

$db = mysql_connect("localhost", "$dbuser", "" ) or die("Problem connecting" ); 
mysql_select_db("$dbname",$db)or die("Problem selecting database" ); 
$result = mysql_query("SELECT * FROM risultati1 WHERE week='24'",$db); 

echo "<table width='100%' border='1' cellpadding='0' cellspacing='0' bordercolor='#9999CC' class='risultati' background='Images/prova2.jpg'>\n";
            echo "<tr bgcolor='#99CCFF'>\n"; 
            echo "<td colspan='4'><div align='center'><strong><font color='#000000' face='Arial, Helvetica, sans-serif'>Risultati</font></strong></div></td>\n";

while($myrow = mysql_fetch_array($result)) 
{ 
$id_match = $myrow["id_match"];
$week = $myrow["week"]; 
$id_c = $myrow["id_c"]; 
$id_f = $myrow["id_f"]; 
$g_c = $myrow["g_c"]; 
$g_f = $myrow["g_f"]; 
echo "<FORM METHOD=GET ACTION=\"ins_risultati.php\">";
include("risultati.inc.php" );
echo "<tr bordercolor='#9999CC'>\n"; 
echo "<td>$id_c</td>\n";
echo "<td>$id_f</td>\n";
echo "<td ><INPUT TYPE=\"TEXT\" NAME=\"g_c\" VALUE=\"$g_c\" SIZE=\"4\"></td>\n";
echo "<td><INPUT TYPE=\"TEXT\" NAME=\"g_f\" VALUE=\"$g_f\" SIZE=\"4\"></td>\n";
}
echo "</TABLE>\n"; 
$id_c=(urlencode($id_c));
$id_f=(urlencode($id_f));
echo "<INPUT TYPE=\"HIDDEN\" NAME=\"id_match\" VALUE=$id_match>";
echo "<INPUT TYPE=\"HIDDEN\" NAME=\"id_c\" VALUE=$id_c>";
echo "<INPUT TYPE=\"HIDDEN\" NAME=\"id_f\" VALUE=$id_f><BR>";
echo "<INPUT TYPE=SUBMIT VALUE=\"Inserisci i risultati\">";
?>

and this is the ins_risultati.php file


<?	

include("dbinfo.inc.php");

$db = mysql_connect("localhost", "$dbuser", "") or die("Problem connecting"); 
mysql_select_db("$dbname",$db)or die("Problem selecting database"); 

$id_c=(urldecode($id_c));
$id_f=(urldecode($id_f));

$sql="UPDATE risultati1 SET g_c='$_GET[g_c]', g_f='$_GET[g_f]' WHERE id_match='$_GET[id_match]'";
$result = mysql_query($sql) or die(mysql_error());

if(mysql_affected_rows($result) == -1) {
    echo "The database didn't get updated";
} else {
echo "The database got updated successfully"<BR>;
echo " You updated:$result fields";
}
?>

This is what happen:
-I only update the LAST match (last of 4)
-The names have a "+" instead of spaces
I receive this message on the screen:

Warning: mysql_affected_rows(): supplied argument is not a valid MySQL-Link resource in c:\programmi\easyphp\www\lf\ins_risultati.php on line 22
The database got updated successfully: 1

and finally this is the URL I have in the browser:

notebook/LF/ins_risultati.php?g_c=2&g_f=3&g_c=0&g_f=0&g_c=4&g_f=4&g_c=0&g_f=0&id_match=96&id_c=AS%252BPilarella&id_f=Ciao%252BWena

as you can see I have the 8 scores but only 1 ID_match and one match team names...

how can I solve my update ???

thanx for your help
Roberto

bogu

If study urlencode function you'll see that space is encoded with "+" and you query is not corect I think.
Try this:

$sql="UPDATE risultati1 SET g_c='".$_GET['g_c']."', g_f='".$_GET['g_f']."' WHERE id_match='".$_GET['id_match']."'";

matto

instead of spaces: this is caused by urlencode. use urldecode in order to "translate back" the literal.

...?g_c=2&g_f=3&g_c=0&g_f=0&g_c=4&g_f=4&g_c=0&g_f=0&...

look at the query string: you set (for example) $g_c 4 times! this is equivalent to

<?
$g_c = 2;
$g_c = 0;
$g_c = 4;
$g_c = 0;
?>

see the point? only the last value (0) will be received as the value for $g_c.

you should pick a different name for each variable passed, e.g.:

...?g_c1=2&g_f1=3&g_c2=0&g_f2=0&g_c3=4&g_f3=4&g_c4=0&g_f4=0&...

you could use arrays for g_c and g_f, too. if you name your inputs g_c[] (4 times) and g_f[] (4 times), the recipient script will create two arrays $g_c and $g_f. you can then do the updates in a loop:

in the html form:

first result: <input type=text name=g_c[]><br>
second result: <input type=text name=g_c[]><br>
third result: <input type=text name=g_c[]><br>
fourth result: <input type=text name=g_c[]>
... (same for g_f) ...

-->

for($i=0; $i<4; $i++)
{
  $currentvaluefor_g_c = $g_c[$i];
  $currentvaluefor_g_f = $g_f[$i];

  $sql = "update ... set g_c=".$currentvaluefor_g_c." ...";
  ...
}

boboli

I'm trying the changement... BUT I USED URLDECODE 😕 ...
see ins_risultati.php:

include("dbinfo.inc.php");

$db = mysql_connect("localhost", "$dbuser", "") or die("Problem connecting"); 
mysql_select_db("$dbname",$db)or die("Problem selecting database"); 

$id_c=(urldecode($id_c));
$id_f=(urldecode($id_f));
......

????
maybe I use it in the wrong position...
Thanx
Roberto

boboli

Originally posted by bogu
If study urlencode function you'll see that space is encoded with "+" and you query is not corect I think.
Try this:
$sql="UPDATE risultati1 SET g_c='".$_GET['g_c']."', g_f='".$_GET['g_f']."' WHERE id_match='".$_GET['id_match']."'";
[/B]

NOT WORKING...
having exactly the same results...
I will try the matto one...

Roberto

boboli

Originally posted by matto
you could use arrays for g_c and g_f, too. if you name your inputs g_c[] (4 times) and g_f[] (4 times), the recipient script will create two arrays $g_c and $g_f. you can then do the updates in a loop:

in the html form:

first result: <input type=text name=g_c[]><br>
second result: <input type=text name=g_c[]><br>
third result: <input type=text name=g_c[]><br>
fourth result: <input type=text name=g_c[]>
... (same for g_f) ...

I feel stupid (and maybe I'm a little fused...) but how can I paste it in the loop of the array ??? I have to show the team names in order to assign a match result correctly...

boboli

Originally posted by boboli
I feel stupid (and maybe I'm a little fused...) but how can I paste it in the loop of the array ??? I have to show the team names in order to assign a match result correctly...

I tried but my knowledge is not enough good to do it...

hope someone can help me...

:rolleyes: :rolleyes: :rolleyes: