Simple(?) echo problem

richardbotw

Hello, I've created a login page and when the user logs in, it echos their username saying "Welcome Smith5" (for example), please click here to proceed. Then it subsequently kick-starts a session for that user, and I want his username to echo on to the subsequent page, but it won't - any ideas why? It works fine for the first one but not for the next. Here it is (I've cut out the HTML)

passwordverify.php

<?php
session_start();
session_register("usertype");
session_register("username");
session_register("sessionident");
?>

include "common_db.inc";
$linkid = db_connect();

$query = "SELECT * FROM Member WHERE Username = '$_POST[username]'";
$result = mysql_query($query)
    or die('MySQL error: '.mysql_error().'<br>Query: '.$query);
$row = mysql_fetch_array($result);

If ($row["Password"] !== $_POST[password]) {
    echo ("Incorrect Login. Please try <A HREF=logon.php>again</A>");
    }
Else { 
$_SESSION[sessionident] = session_id(); 
$_SESSION[usertype] = $row["usertype"];
		$_SESSION[username] = $row["Userid"]; 


echo ("Welcome $row[Username]!  To proceed to the Main Menu - <A HREF=mainhome.php?$_SESSION[sessionident]>Click Here</A>!");
}

?>

Then mainhome.php...

<?php
session_start();
?>

<?php echo $_SESSION[Username]; ?>

Any ideas - I know I've mad eit hard my mixing cases, that it is not that that seems to be the issue here, just cant get what it isnt working. There are no errors, just the username will not display!

jpmoriarty

you'd have to do session_register() on the variable after you've defined it. I dont think you can define $_SESSION['']: you have to do it using the session_register command.

so change the
$_SESSION[username] = $row["Userid"];
line to

$userid = $row['Userid'];
session_register('userid');

and then on the next page you can call $_SESSION('userid') and it should be there.

richardbotw

Hey thanks for this it now works... only I've got one fatal flaw now I've just realised!!!

My site is based at: Poole Flights

Users register, get a unique username and password, then they can login view bookings, and stuff like that (soon) - ie: sessions are sorted.

ONLY these pages (within the session) are not meant to be viewed by anyone who hasn't registered!

I mean, check out....
This
ANy idea what I'm supposed to do. I believe I'll need an authentication variable that needs to be passed through the pages or something, and then there needs to be an if authenticated go ahead, if not go away - sort of script.

Or is there an easier way??

richardbotw

Hey thanks for this it now works... only I've got one fatal flaw now I've just realised!!!

My site is based at: Poole Flights

Users register, get a unique username and password, then they can login view bookings, and stuff like that (soon) - ie: sessions are sorted.

ONLY these pages (within the session) are not meant to be viewed by anyone who hasn't registered!

Or is there an easier way??

jpmoriarty

once they've logged in successfully, do something like this:

$valid_user=1;
session_register('valid_user');

Then at the top of every page that you want people to be logged in to see you can do:

if(!session_is_registered('valid_user'))
    header("loaction:login.php");

and that will redirect them to the login page if they havent had that valid_user session variable set.

remember you should put that right at the very top - before any html goes to the browser.