Undefined Variable Php_self? Help?

[Mike-2003]

I have Php_self in some of the code which comes up with a error saying 'Undefined variable Php_self'. I do have the global register on in the PHP.ini. The following is part of the code it says in error.

echo "<form name='NewEmpIDEntry' action='".$PHP_SELF."' method='get'>";

Any help would be greatly appreciated by this newbie.

Thanks

[mogster]

Did you restart the webserver after setting globals to on?

Stupid question, perhaps 😃
But else your code works fine with me.

knutm

[Mike-2003]

Yes, I did restart the webserver. Any suggestions?

[ihenman]

Are you trying too read in information from a form and process it in the same page?

if i.e. you have file form.php your code for this file is...

<form method="get" action="form.php" .... >
....

....

....

</form>

Then your PHP code below which processes the form you can run into this problem... Usually if your trying to run a loop on a page with something like

if(!submit)

<form>

else

execute PHP

If you create a seperate server side script file that processes the form input you should have better luck...

[Mike-2003]

I'm not sure want you mean by a separate server side script. This code was a hand me down from a user who is no longer around and I was trying to make it work. It looks like it is trying to input from the form.

It is in a function called 'employeeadd'.

function employeeadd() {
echo "<table width=100% cellspacing=0 cellpadding=0 border=0 bgcolor='#000099'><tr><td>";
echo "<table width=100% bgcolor='#000099'><tr>";
echo "<td align='center'><font class='text14bold'' color='#ffffff'>Add NEW Employee</font>";
echo "</b></font><font class='text12'>&nbsp;</font></td>";
echo "</b></font>";
echo "</td></tr></table>\n";
echo "</td></tr></table>\n";
echo "<table width=100% cellspacing=0 cellpadding=0 border=0 bgcolor='#000099'><tr><td>";
echo "<img src='images/spacer.gif' width=100 height=7>";
echo "</td></tr></table>\n";

            echo "<table width=100% bgcolor='#eeffee' class='reportsborder' cellspacing=1 cellpadding=1>";
            echo "<tr valign='top' align='left'>";
            echo "<td class='text18bold' width=100% align='center'>Enter New Employee</td></tr></table>";
            echo "<form  name='NewEmpIDEntry' action='".$PHP_SELF." method='get'>";
            echo "<input type='hidden' name='action' value='newempadd'>";

[BuzzLY]

First of all, there is a problem with your code. The line:

echo "<form name='NewEmpIDEntry' action='".$PHP_SELF." method='get'>";

has the wrong set of quotes. Plus, you don't have to concatenate strings with a variable.

Secondly, I strongly recommend you change it to use "$_SERVER[PHP_SELF]". It is a better programming practice to not rely on register_globals. If you do, and it gets turned off, you will have to go back through all of your php pages to fix them.

Try rewriting it as such:

echo "<form name='NewEmpIDEntry' action='$_SERVER[PHP_SELF]' method='get'>";

[Mike-2003]

Thanks BuzzLY , that worked.

I have one more question, I have the same problem in the line below. Would I use $_POST[color] or am I not even close?

echo "<table width=100% bgcolor='" . $color . "' class='reportsborder' cellspacing=1 cellpadding=1>";

Thanks

[BuzzLY]

It really seems like register_globals is not turned on... yes, I would use $_POST['color'] (assuming "color" is coming from a previously posted page). Again, you don't have to use concatenation -- you can have your variables directly inside the string.

One other thing. try to use PHP tags around your code. It makes it much easier to read. Here is what your line should look like:

echo "<table width=100% bgcolor=\"$_POST['color']\" class='reportsborder' cellspacing=1 cellpadding=1>";

[Mike-2003]

BuzzLY,

It now comes up with 'undefined index color'.

Could you explain the PHP tags you mentioned before?

Thanks

[BuzzLY]

where is "color" coming from? Is it coming from a form on a previous page? Or is simply a variable you are setting? "Undefined index color" simply means that "$_POST['color']" is invalid.

Incidentally, your error reporting is set to display notices if you are getting that message for invalid $_POST variables. You may want to disable Notices in your PHP.INI file. They are turned off by default, so it seems that someone has enabled them.

By PHP tags, I mean that you should enclose your code in them on the board, like this (without the *'s):

[PHP]
<?php
echo "This is PHP code";
?>
[/PHP]

This makes your code look like this:

<?php
echo "This is PHP code";
?>

[mogster]

I see Buzz here is giving good advice 😉
Just as a comment:
Are you sure you've edited the correct php.ini file?
This q may seem even more stupid than the last, but it really seems your globals is not set to on 😃

Reason I'm asking is that I've done this once, not bothering to check the php.ini path with phpinfo(). And the result was somewhat similar to yours.

But hey - coding for globals off is coding for the future, since this is set off as default in the recent versions of php.

knutm

[Mike-2003]

BuzzLY, thanks for explanation on the tags. I inherited this and as you can see I 'am struggling through it being a new to PHP.

I see the color defined on the main page, but on this current page I do not see it defined, it looks like this page is all functions. I have included what I'm seeing to hopefully help, it looks like a mess.

function employeeedit () {
echo "<table width=100% cellspacing=0 cellpadding=0 border=0 bgcolor='#000099'><tr><td>";
echo "<table width=100% bgcolor='#000099'><tr>";
echo "<td align='center'><font class='text14bold'' color='#ffffff'>Employee Edit</font>";
echo "</b></font><font class='text12'>&nbsp;</font></td>";
echo "</b></font>";
echo "</td></tr></table>\n";
echo "</td></tr></table>\n";
echo "<table width=100% cellspacing=0 cellpadding=0 border=0 bgcolor='#000099'><tr><td>";
echo "<img src='images/spacer.gif' width=100 height=7>";
echo "</td></tr></table>\n";

            $sql = "SELECT * from employees order by employees.LastName, employees.FirstName";

            if (($result = doSql($sql)) && (mysql_num_rows($result))) {

                    echo "<table width=100% bgcolor='\"$_POST['color']\" class='reportsborder' cellspacing=1 cellpadding=1>";
                    echo "<tr valign='top' align='left'>";
                    echo "<td class='text18bold' width=100% align='center'>Select Employee ID To Edit</td></tr></table>";
                    echo "<table width=100%><tr bgcolor='#ffffff'><td class='text9bold' width=8% align='center'>EmployeeID</td><td class='text9bold' width=10% align='center'>Employee Name</td><td class='text9bold' width=10% align='center'>Work Shift</td><td class='text9bold' width=10% align='center'>Status</td></tr>";
                    while ($query_data = mysql_fetch_array($result)) {
                    echo "<tr bgcolor='".$color."'><td class='text9bold' width=8% align='center'><a href='".$PHP_SELF. "?action=empeditselect&f_employeeid=".$query_data["EmpID"]."'</a>".$query_data["EmpID"]."</td><td class='text9bold' width=10% align='left'>".Trim($query_data["LastName"]).",".Trim($query_data["FirstName"])."</td><td class='text9bold' width=10% align='center'>".$query_data["WorkShift"]."</td><td class='text9bold' width=10% align='center'>".$query_data["Status"]."</td></tr>";
                    if ($color == "#eeffee") $color = "#ffffff";
                    else $color = "#eeffee";

[BuzzLY]

You have a couple of things going on here...

First of all, let's tackle this line:

echo "<table width=100% bgcolor='\"$_POST['color']\" class='reportsborder' cellspacing=1 cellpadding=1>";

This line implies that "color" is coming from a previously posted page. If it is NOT, you should not be using $_POST. The question is... did you have a form with a field called "color" that the user clicked a submit button? If you didn't, then assign a color value to the variable $color. This will solve your second problem, which I'll mention in a moment. You were also missing the closing ' for bgcolor.

So, this line should be rewritten as such:

$color = "#FFFFFF";
echo "<table width=100% bgcolor='$color' class='reportsborder' cellspacing=1 cellpadding=1>";

The other part of your problem was in these lines:

if ($color == "#eeffee") $color = "#ffffff"; 
else $color = "#eeffee";

You didn't have $color set initially, but it was set for each subsequent line. Since we set $color for the table (and I assume you are using the same color for the alternating lines...), that should take care of that problem.

You have a few other things going on as well, Mike, like your while statement is missing a closing }... However, I am not going to give you any more help on this until you enclose your code in

 tags.  It's much too hard to read otherwise.

Before you use this board much longer, I strongly urge you to read the board [url=http://www.phpbuilder.com/board/showthread.php?s=&threadid=10218925]guidelines[/url].

Hope this helps... good luck.

[Mike-2003]

BuzzLY,

Thanks! And I'm in the process of putting the tags in. 😉

[BuzzLY]

Mike,

Don't put the tags in your code. You put those tags around your code when you POST IN THIS FORUM. :rolleyes:

So... instead of seeing this:

function employeeedit () {
echo "<table width=100% cellspacing=0 cellpadding=0 border=0 bgcolor='#000099'><tr><td>";
echo "<table width=100% bgcolor='#000099'><tr>";
echo "<td align='center'><font class='text14bold'' color='#ffffff'>Employee Edit</font>";
echo "</b></font><font class='text12'> </font></td>";
echo "</b></font>";
echo "</td></tr></table>\n";
echo "</td></tr></table>\n";
echo "<table width=100% cellspacing=0 cellpadding=0 border=0 bgcolor='#000099'><tr><td>";
echo "<img src='images/spacer.gif' width=100 height=7>";
echo "</td></tr></table>\n";

$sql = "SELECT * from employees order by employees.LastName, employees.FirstName";

if (($result = doSql($sql)) && (mysql_num_rows($result))) {

echo "<table width=100% bgcolor='\"$_POST['color']\" class='reportsborder' cellspacing=1 cellpadding=1>";
echo "<tr valign='top' align='left'>";
echo "<td class='text18bold' width=100% align='center'>Select Employee ID To Edit</td></tr></table>";
echo "<table width=100%><tr bgcolor='#ffffff'><td class='text9bold' width=8% align='center'>EmployeeID</td><td class='text9bold' width=10% align='center'>Employee Name</td><td class='text9bold' width=10% align='center'>Work Shift</td><td class='text9bold' width=10% align='center'>Status</td></tr>";
while ($query_data = mysql_fetch_array($result)) {
echo "<tr bgcolor='".$color."'><td class='text9bold' width=8% align='center'><a href='".$PHP_SELF. "?action=empeditselect&f_employeeid=".$query_data["EmpID"]."'</a>".$query_data["EmpID"]."</td><td class='text9bold' width=10% align='left'>".Trim($query_data["LastName"]).",".Trim($query_data["FirstName"])."</td><td class='text9bold' width=10% align='center'>".$query_data["WorkShift"]."</td><td class='text9bold' width=10% align='center'>".$query_data["Status"]."</td></tr>";
if ($color == "#eeffee") $color = "#ffffff";
else $color = "#eeffee";

[BuzzLY]

... we see this instead:

function employeeedit () { 
echo "<table width=100% cellspacing=0 cellpadding=0 border=0 bgcolor='#000099'><tr><td>"; 
echo "<table width=100% bgcolor='#000099'><tr>"; 
echo "<td align='center'><font class='text14bold'' color='#ffffff'>Employee Edit</font>"; 
echo "</b></font><font class='text12'> </font></td>"; 
echo "</b></font>"; 
echo "</td></tr></table>\n"; 
echo "</td></tr></table>\n"; 
echo "<table width=100% cellspacing=0 cellpadding=0 border=0 bgcolor='#000099'><tr><td>"; 
echo "<img src='images/spacer.gif' width=100 height=7>"; 
echo "</td></tr></table>\n"; 


$sql = "SELECT * from employees order by employees.LastName, employees.FirstName"; 

if (($result = doSql($sql)) && (mysql_num_rows($result))) { 

echo "<table width=100% bgcolor='\"$_POST['color']\" class='reportsborder' cellspacing=1 cellpadding=1>"; 
echo "<tr valign='top' align='left'>"; 
echo "<td class='text18bold' width=100% align='center'>Select Employee ID To Edit</td></tr></table>"; 
echo "<table width=100%><tr bgcolor='#ffffff'><td class='text9bold' width=8% align='center'>EmployeeID</td><td class='text9bold' width=10% align='center'>Employee Name</td><td class='text9bold' width=10% align='center'>Work Shift</td><td class='text9bold' width=10% align='center'>Status</td></tr>"; 
while ($query_data = mysql_fetch_array($result)) { 
echo "<tr bgcolor='".$color."'><td class='text9bold' width=8% align='center'><a href='".$PHP_SELF. "?action=empeditselect&f_employeeid=".$query_data["EmpID"]."'</a>".$query_data["EmpID"]."</td><td class='text9bold' width=10% align='left'>".Trim($query_data["LastName"]).",".Trim($query_data["FirstName"])."</td><td class='text9bold' width=10% align='center'>".$query_data["WorkShift"]."</td><td class='text9bold' width=10% align='center'>".$query_data["Status"]."</td></tr>"; 
if ($color == "#eeffee") $color = "#ffffff"; 
else $color = "#eeffee";

Please tell me that you understand this now...