Help? While loop not working

[Mike-2003]

I have a While loop which I thought would execute some code when the id link is clicked, but it takes me back to the home page. I thought I have it right. Also is there a way to condense the one line?
Any help would be appreciated.

Thanks.

                        while ($query_data = mysql_fetch_array($result)) {
                        echo "<tr bgcolor='".$color."'><td class='text9bold' width=8% align='center'><a href='$_SERVER[PHP_SELF]'?action=empeditselect&f_employeeid=".$query_data["EmpID"]."'</a>".$query_data["EmpID"]."</td><td class='text9bold' width=10% align='left'>".Trim($query_data["LastName"]).",".Trim($query_data["FirstName"])."</td><td class='text9bold' width=10% align='center'>".$query_data["WorkShift"]."</td><td class='text9bold' width=10% align='center'>".$query_data["Status"]."</td></tr>";
                        if ($color == "#eeffee") $color = "#ffffff";
                        else $color = "#eeffee";

                    }

            } else {
                    echo "No Employees found";
            }
            echo "</table>";

}

[trooper]

hi there

2 things

1 - if you posting code in phpbuilder always use the

php tags

that way the code will wrap properly on the screen 😃

2 to make it easier use the =<<< syntax

Like this

$data =<<<EOD
html code in here
EOD;
print $data;

Remember that there must be NO spaces after EOD and also NO spaces after EOD;

HTH

GM

Originally posted by Mike-2003
I have a While loop which I thought would execute some code when the id link is clicked, but it takes me back to the home page. I thought I have it right. Also is there a way to condense the one line?
Any help would be appreciated.

Thanks.

                        while ($query_data = mysql_fetch_array($result)) {
                        echo "<tr bgcolor='".$color."'><td class='text9bold' width=8% align='center'><a href='$_SERVER[PHP_SELF]'?action=empeditselect&f_employeeid=".$query_data["EmpID"]."'</a>".$query_data["EmpID"]."</td><td class='text9bold' width=10% align='left'>".Trim($query_data["LastName"]).",".Trim($query_data["FirstName"])."</td><td class='text9bold' width=10% align='center'>".$query_data["WorkShift"]."</td><td class='text9bold' width=10% align='center'>".$query_data["Status"]."</td></tr>";
                        if ($color == "#eeffee") $color = "#ffffff";
                        else $color = "#eeffee";

                    }

            } else {
                    echo "No Employees found";
            }
            echo "</table>";

}

[/B]

[mo0ness]

i recommend u use sumthing better, shorter and more suitable than $query_data, maybe sumthin like "$row", becoz what ur doing here, is fetching the field names from a database in order for you to retreive further records. Your forming an array with this name you set. Also; make sure you have actually set a valid $result and $query, as they all link up, if theres an error in any 1 of those lines, ur error will be said to be on the line of you while statement.

eg:

<?php

$query = "SELECT * FROM $database";

// before anything else, u could also test and make sure that your SQL statement has actually worked (this is for good practice, a little bit off topic)...

if ($query)
{

$result = mysql_db_query($dbname);

while ($row = mysql_fetch_array($result))
{

$field1 = "$row[Field_1]";
$field2 = "$row[Field_2]"; // etc etc

}

// any other html (tables, font, links etc)

// when you wish to use the data you retreived, print the $field1 or $field 2

}
else
{
print "Query failed: ".mysql_error(); // this shows where the line is incase you didnt know :-)

?>

Hope this helps, theres a few "extra" bits there which are a lil bit off topic IE: mysql_error(); - but hey, if u want a good and effecient result no matter what output you get, its best you take note of these kinda things! Good luck :-)

[Mike-2003]

This worked great! The only thing which is not working is the '?action' which is suppose to use the employee id in a function which is located in the first page so the record can be edited. Did I miss something?

                        while ($row = mysql_fetch_array($result)) {
                        $Emp_id = "$row[EmpID]";
                        $Last   = "$row[LastName]";
                        $First  = "$row[FirstName]";
                        $Shift  = "$row[WorkShift]";
                        $Stat   = "$row[Status]";
                        echo "<tr bgcolor='".$color."'><td class='text9bold' width=8% align='center'><a href='$_SERVER[PHP_SELF]'?action=empeditselect&f_employeeid='".$Emp_id."'</a>".$Emp_id."</td>";
                        echo "<td class='text9bold' width=10% align='left'>".$Last.",".$First."</td>";
                        echo "<td class='text9bold' width=10% align='center'>".$Shift."</td>";
                        echo "<td class='text9bold' width=10% align='center'>".$Stat."</td></tr>";
                        if ($color == "#eeffee") $color = "#ffffff";
                        else $color = "#eeffee";

                    }

            } else {
                    echo "No Employees found";
            }
            echo "</table>";

[diego25]

Check out the source code outputted by your PHP script. You'll see that there are single quotes around the Emp_id. You'll need to remove those quotes.

Diego

[Mike-2003]

Thanks for the tip on the functions. I removed the single quotes, but it still goes back the the home page when clicking on the link for the employee id.

Any suggestions?

Thanks.

[diego25]

There is also another set of single quotes around the PHP_SELF part that shouldn't be there.

Diego

[Mike-2003]

That got it!

Thanks for the help.🙂