undefined index - isset?

[jonathen]

Hi,

My script works fine until I turn on all notices, then I get this error:

Notice: Undefined index: L_USERNAME

This is referring to:

$L_USERNAME=$_POST['L_USERNAME'];

Now I realise this is because $L_USERNAME is not set, so I tried replacing it with:

if (isset($L_USERNAME=$_POST['L_USERNAME']));

...which now gives me this error:

Parse error: parse error, unexpected '=', expecting ',' or ')'

Yet my syntax highlighting (Ultraedit) shows the syntax as correct! What is the correct syntax? I know I could simply switch off the failure notices, but I want my coding to be clean 🙂

Any help appreciated,

Jonathen

[RedDragon]

isset can only check one variable!

so try using this:

if(!$L_USERNAME) {
$L_USERNAME = $_POST['L_USERNAME'];
}

[jonathen]

Now I get two errors:

Notice: Undefined variable: L_USERNAME

&

Notice: Undefined index: L_USERNAME

Any ideas?

[MeX]

hi!!

if (isset($_POST['L_USERNAME'])) {
   $L_USERNAME=$_POST['L_USERNAME'];
}

hope that helps!!

ceeyaa.MeX

[jonathen]

Thank you, that does help - it removes those index errors, but it still doesn't get around the undefined variable (later on in the script) which is this line:

$sql = "SELECT * FROM users WHERE Username='$L_USERNAME' and Password='$L_PASSWORD'";

That line now causes this error:

Notice: Undefined variable: L_USERNAME in index.php on line 24
Notice: Undefined variable: L_PASSWORD in index.php on line 24

[MeX]

hi jonathen!!

well, if you use the vars for a db-query you should check if all are set correctly and the fire the query!!

if (isset($_POST['L_USERNAME'])) {
   $L_USERNAME = $_POST['L_USERNAME'];
}
if (isset($_POST['L_PASSWORD'])) {
  $L_PASSWORD = $_POST['L_PASSWORD'];
}
if (isset($L_USERNAME) && isset($L_PASSWORD)) {
   $sql = "SELECT * FROM users WHERE Username='$L USERNAME' AND Password='$L_PASSWORD'";
// YOUR CODE
} else {
// ERROR HANDLING e.g.
echo 'NOT ALL FIELDS CORRECTLY FILLED!<br>';
}

OR my recomed mehtod:

$L_USERNAME = (isset($_POST['L_USERNAME'])) : $_POST['L_USERNAME'] : '';
$L_PASSWORD = (isset($_POST['L_PASSWORD'])) : $_POST['L_PASSWORD'] : '';
if ($L_USERNAME != '' && $L_PASSWORD != '') {
   // HERE YOUR QUERY
} else {
   // HERE THE ERROR HANDLING
}

hope that helps!!

ceeyaa.MeX