problems increasing a variable by one

dotcomtim

I am still need bigtime help with my script!

$inuse = false;
while ($inuse == false)
{
	$check_profiles = DBGetValue ("SELECT screenname FROM ".PROFILES_TABLE." " .
	 	"WHERE screenname = '".addslashes ($screenname)."' ");
	$check_validate = DBGetValue ("SELECT screenname FROM ".VALIDATE_TABLE." ".
		"WHERE screenname = '".addslashes ($screenname)."' " .
		"AND TO_DAYS(tmstmp) + 3 > TO_DAYS(NOW()) ");

if (isset($check_validate))
{
    $screenname_count++;
    $screenname = $screenname.$screenname_count;
    $inuse = false;
}
else
{
    $errs['screenname'] = "The screen name you requested is already in use"; 
    $inuse = true;
}
}

I am getting two problems with my script; the first is that I am not getting screename2 if screenname and screenname1 are taken instead I am getting screenname11; the second problem is that if it does find a available screenname it doesn't finish the script and add the user..

jpmoriarty

do a search for variable variables - theres loads of stuff on here about it if you look around.

dotcomtim

I have searched the forums and believe that I have solved the second problem; well as far as I can see it seems be working .. the loop ends once a variable has been found.

My first problem how ever is not quite working the way I expected it to; I searched the forums and it looks like what I have done should be work but it doesn't.

$screenname_count++; should produce the next numeric value.
$screenname=$screenname.$screenname_count; should give me the users screenname plus add the numeric value.

But what I am getting are the following screenname1, screenname12, screenname123, etc...
But what I am expecting was the following screenname1, screenname2, screenname3, etc...

epimeth

the problem is that every time the while loop is entered you append $sreenname_count to $screenname... so what you actually have is

$screenname = 'screenname';
$sreenname_count = 1;

then you append count to the name getting

$screenname = 'screenname1';

and then you update the count and append again...

$screenname = 'screenname12';

and so on

you either have to strip the count from the screenname every time you go into the loop or change

addslashes($screenname) to addslashes($screenname.$sreenname_count)

and change the body of if(isset...)) to
$screename_count++;
$inuse = false;

(don't update screenname)

jpmoriarty

from http://www.phpbuilder.com/board/showthread.php?s=&threadid=10230518&highlight=variable+and+variables :

for($i=1;$i<=5;$i++)
{
$var = "nom".$i;
echo $$var;
}

so what you'd want would be something along the lines of:

    if (isset($check_validate))
    {
        $screenname_count++;
        $screennamevar = "screenname".$screenname_count;
        $screenname = $$screennamevar;
        $inuse = false;
    }
    else
    {
        $errs['screenname'] = "The screen name you requested is already in use"; 
        $inuse = true;
    }