Notice: Undefined variable

[jonathen]

Why do I get so many of these with full error notices on? I don't understand where I need to define the variable, and they work without definition; it's just I need to get them defined to have clean code.

Is there a way of defining a non-defined variable using if(isset) or if(empty) ? None of what I have tried seems to work...

TIA

Jonathen

[planetsim]

Most likely you have Register Globals off. Meaning any posted information must be

$_POST['index']

index being the name of the input. so if its submit its $_POST['submit']

OR if your getting information from Sessions, Cookies etc
I suggest reading up on Predefined Variables in the PHP Manual.

http://www.php.net/manual/en/language.variables.predefined.php

[jonathen]

Thanks for that, but that's not the problem. Globals is on, and that page is referring more to predefined variables that will not work with globals off.

I am using:

if (isset($_POST['DATEONE'])) {
   $DATEONE=$_POST['DATEONE'];
}
if (isset($_POST['DATETWO'])) {
   $DATETWO=$_POST['DATETWO'];
}
if (isset($_POST['BRAND'])) {
   $BRAND=$_POST['BRAND'];
}

...which is fine... however, later on in the script I call $DATEONE like so:

$result = mysql_query("SELECT * FROM sales WHERE Brand=\"$Brand\" ORDER BY Date",$db);
if($DATEONE!="" AND $DATETWO!="")
{
	$result = mysql_query("SELECT * FROM sales WHERE Date between \"$DATEONE\" and \"$DATETWO\" and  Brand=\"$Brand\" ORDER by Date",$db);
	echo " <div align='center'><b>$DATEONE</b>----<b>$DATETWO</b></div><br>";
}

...which gives me this error:

Notice: Undefined variable: Brand in brand.php on line 55

Notice: Undefined variable: DATEONE in brand.php on line 56

Any ideas? This is driving me nuts!

[planetsim]

Well it doesnt seem that it exists. in your if's try adding echo $DATEONE etc and see if it returns a result

[cgraz]

If you continue having problems, you could always change your error reporting in php.ini from

error_reporting = E_ALL

to :

error_reporting = E_ALL & ~E_NOTICE

Cgraz

[epimeth]

if (isset($_POST['DATEONE'])) {
   $DATEONE=$_POST['DATEONE'];
} else $DATEONE="";

if (isset($_POST['DATETWO'])) {
   $DATETWO=$_POST['DATETWO'];
} else $DATETWO="";

if (isset($_POST['BRAND'])) {
   $BRAND=$_POST['BRAND'];
} else $BRAND="";

[jonathen]

Thank you so much, epimeth - finally it competely works! This has been driving me nuts, and it's so nice when you finally find the answer.

Thanks again

🙂

[Riffking]

Hi Epimeth,

I wonder if you could help me with the following,

My server hosts have turned off 'Register Globals' and turned on 'Safe Mode' and the PHP version is 4.1.2

My guest book loads and post messages okay, but when i press the next button, i should get ' No more Entries' message...But instead, i get this:

Notice: Undefined index: 30 in /home/site/112/web/GB.php on line 90

Notice: Undefined index: 30 in /home/site/112/web/GB.php on line 91

On line 90 and 91 of my script is the following code:

for ($n = $NumLow; $n < $NumHigh; $n++) {
print $DataArray[$n];
if (!$DataArray[$n]) {
Print "<b>

		     No More Entries</b>";
	 exit;
  		}
 }

?>

Where line 90 is: print $DataArray[$n];

Can You help?

Thanx

Riff

[Weedpacket]

Same problem: you're not checking to see if $Database[$n] exists before using it. In this case, $Database[30] does not exist. In other words, you're not actually checking to see that there are no more entries before you try to look at them.

[Mordecai]

To append to Weedpacket's notes toward Riffking:
Try using count($DataArray) rather than $NumHigh. Count() is a function that returns the number of indeces in an array.

[Riffking]

Hi guys, just a couple of days ago, my host decided to turn Register Globals OFF and Safe Mode ON, this however caused problems in my forms and guestbook, that had previosly worked fine, but now don't. Host's Server runs PHP 4.1.2

After finally getting it working, i was thenhaving problems logging into my sites (host) admin control panel, and was getting a php related error, while the problem was there, my guestbook was giving me the messages that i have posted.

Only late last night, i was able to log in to the control panel, i then checked the guestbook which then worked perfect. So it must have been the hosts doing some upgrade work or something.

as for your replies:

Maybe i should have posted the whole script, cos it wasn't easy understanding the replies.

You can see the guestbook at my Still under construction site:

http://www.voycemusic.co.uk

Go to bottom left scroll menu, scroll to guestbook, and click on that.

If you notice any discrepencies, please let me know,

in the meantime,

Thanx for your input guys!

Riff

[epimeth]

first of all, I must say this...
I don't like flash, but damn this site looks nice!

for ($n = $NumLow; $n < $NumHigh; $n++)

is wrong... you are counting until $NumHigh, which I assume is whatever number appears to the right of "to" in the guestbook...

if you have 22 items in the data array, but try to access $DataArray[23], you will get an error since $DataArray[23] doesn't exist.

So you should try

for ($n = $NumLow; ($n < $NumHigh) && ($n < count($DataArray)); $n++)

[Riffking]

Hey thanx for the warming comments epimeth,

I think i know what you mean about the NumHigh bit, i shall most certainly try it. Unfortunately i can't try it right now since my hosts are upgrading and have shifted files around, Pain in the butt!

When you viewed the guestbook, after the last entry, if you clicked the 'next 5' button, did you see the comment; 'No More entries'? cos that's what should have shown. I was getting a php error message a day or so ago but i think it was something to do with the hosts making changes/upgrades. I don't see it now.

I've only been into web design for around a year and abit and have only started to look at PHP programming, so i am a complete newbie to php scripting although not bad at ation script as in the guest book, because people can leave comments which others will read, i managed to script a bit of code that doesn't allow the user to input 'common foul language' phrases, haven't got them all, but it works okay.

As soon as i implement the new bit of code, i shall post here to know how it's gone,

in the meantime;

Thank you very much for your input, time and speedy response.

Riff

[epimeth]

I see "no more entries" so maybe its been fixed....

and anyway, you're quite welcome

[Riffking]

Thanx epimeth,

If i can be of any help, please let me know, i will be pleased to help.

Haven't corrected the correspondence forms on the site yet, so if you need to contact me, please do via;

[e-mail]

Thanx

Peace

Riff

[cyanblue]

Hm... I don't quite understand this... 🙁

I remember having no problem using $_POST['whatever'] before, but now I get that strange 'Undefined Index' notice...

I have used epimeth's method to check if the variable is set or not... It worked... It got rid of those notices... But, why am I doing this extra step??? Was there something important that I am missing??? 🙁

register_global is set to Off
W2K
IIS5
PHP 4.2.3

Thanks... Any help would be appreciated ... 🙂

[Weedpacket]

It would be your error reporting level.

You can get over all these problems if you just make sure variables have values before you read them.