entering email into a field

[epimeth]

You have an error in your SQL syntax near '@webspinners.co.il,09 956 3749,2,April 10, 2003,April 24, 2003)' at line 1

$firstname = $_POST['firstname'];
$lastname = $_POST['lastname'];
$email = $_POST['email'];
$phone = $_POST['phone'];
$noguests = $_POST['noguests'];
$arrive = $_POST['arrive'];
$depart = $_POST['depart'];

$dbconn = mysql_connect() or die(mysql_error());
mysql_select_db('hotel') or die(mysql_error());

$sql = 'INSERT INTO `reservations` VALUES ('.$firstname.','.$lastname.','.$email.','.$phone.','.(int)$noguests.','.$arrive.','.$depart.');';

$result = mysql_query($sql) or die(mysql_error());

mysql_close($dbconn);

the create table sql code follows

CREATE TABLE reservations (
  id tinyint(4) NOT NULL auto_increment,
  firstname char(50) NOT NULL default '',
  lastname char(50) NOT NULL default '',
  email char(50) NOT NULL default '',
  phone char(50) NOT NULL default '',
  noguests tinyint(4) NOT NULL default '0',
  arrive char(50) NOT NULL default '',
  depart char(50) NOT NULL default '',
  PRIMARY KEY  (id)
)

so whats going on? is '@' some sort of an escape character in mySQL?

[dustbuster]

Try this:

$sql="INSERT INTO reservations (firstname,lastname,email,phone,noguests,arrive,depart) values ('$firstname','$lastname','$email','$phone','$noguests','$arrive','$depart')";

The names in the first set of brackets are the names of the columns in your table. If your noguests is in the format 1,2,3... you don't need to cast it to an int.

If that doesn't work you can rtfm at mysql.com and search for insert. It has helped me alot in the past.

[epimeth]

works now... strings in SQL need to be enclosed in quotes... duh...

and I had to put in the column names, thanks dust...

as far as I remember, you didn't need to put in the column names if you use all of them except for the primary keys in the VALUES statement, but I could be wrong...

[dustbuster]

No prob
I will look into that. If it is true it will save me some time.

[cgraz]

no you don't need to, but it's always a good idea to do it. If you (meaning any php'er) is prone to make simple parse errors, you will most likely forget to put in a field or do something that will cause your order to be off. Then fixing it won't be pleasant. IF you're trying to shorten your code, then use a loop (especially handy when you have lots of fields)

   foreach($_POST as $key) {
      $keys[] = $key;
   }

   $query = "INSERT INTO your_table (" . implode(",", $keys) . ")";
   $query .= " VALUES('" . implode("','", $_POST) . "')";

   $result = mysql_query($query) or die(mysql_error());

That's how I do it; it's especially great when you have 10+ fields.

cgraz

[epimeth]

now that is a good idea...

so many functions, so little time... its a good thing you guys are here 🙂